Last active
June 14, 2021 13:29
-
-
Save AndrewMuise/055317f183ead7e65f6eb05129882021 to your computer and use it in GitHub Desktop.
background throttling creates unpredictable behaviour after restoring unfocusable, frameless, transparent window
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!DOCTYPE html> | |
<html> | |
<head> | |
<meta charset="UTF-8"> | |
<!-- https://developer.mozilla.org/en-US/docs/Web/HTTP/CSP --> | |
<title>Hello World!</title> | |
</head> | |
<style> | |
body:hover { background-color: wheat !important} | |
</style> | |
<body style="-webkit-app-region: drag; background: white; border: thin solid black"> | |
<h1>Hello World!</h1> | |
We are using Node.js <span id="node-version"></span>, | |
Chromium <span id="chrome-version"></span>, | |
and Electron <span id="electron-version"></span>. | |
<div> | |
<button id="minimize" style="-webkit-app-region: no-drag">Minimize Me</button> | |
<button id="quit" style="-webkit-app-region: no-drag">Quit</button> | |
</div> | |
<div> | |
Reproduction steps | |
<ol> | |
<li>Note that hovering over the buttons changes the background colour, you can drag the window by grabbing inside the border and moving around</li> | |
<li>Click the `Minimize` button. the window will minimize and restore after 2 seconds</li> | |
<li>Hover effects still work, `Quit` will close the application. you can still drag the window by dragging around the body</li> | |
<li>Focus any other window, like selecting this very window</li> | |
<li>Returning to the fiddle, you will now be unable to drag the window, or interact with the buttons, however the hover will still change the background colour</li> | |
</ol> | |
</div> | |
<!-- You can also require other files to run in this process --> | |
<script src="./renderer.js"></script> | |
</body> | |
</html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// Modules to control application life and create native browser window | |
const {app, BrowserWindow, ipcMain} = require('electron') | |
const path = require('path') | |
function createWindow () { | |
// Create the browser window. | |
const mainWindow = new BrowserWindow({ | |
width: 800, | |
height: 600, | |
webPreferences: { | |
preload: path.join(__dirname, 'preload.js'), | |
nodeIntegration: true, | |
contextIsolation: false, | |
backgroundThrottling: false, | |
}, | |
focusable: false, | |
transparent: true, | |
frame: false, | |
}) | |
// and load the index.html of the app. | |
mainWindow.loadFile('index.html') | |
// Open the DevTools. | |
// mainWindow.webContents.openDevTools() | |
ipcMain.on("minimize-me", () => { | |
mainWindow.minimize() | |
setTimeout(() => mainWindow.restore(), 2000) | |
}) | |
ipcMain.on("quit", () => { | |
app.quit() | |
}) | |
} | |
// This method will be called when Electron has finished | |
// initialization and is ready to create browser windows. | |
// Some APIs can only be used after this event occurs. | |
app.whenReady().then(() => { | |
createWindow() | |
app.on('activate', function () { | |
// On macOS it's common to re-create a window in the app when the | |
// dock icon is clicked and there are no other windows open. | |
if (BrowserWindow.getAllWindows().length === 0) createWindow() | |
}) | |
}) | |
// Quit when all windows are closed, except on macOS. There, it's common | |
// for applications and their menu bar to stay active until the user quits | |
// explicitly with Cmd + Q. | |
app.on('window-all-closed', function () { | |
if (process.platform !== 'darwin') app.quit() | |
}) | |
// In this file you can include the rest of your app's specific main process | |
// code. You can also put them in separate files and require them here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// All of the Node.js APIs are available in the preload process. | |
// It has the same sandbox as a Chrome extension. | |
window.addEventListener('DOMContentLoaded', () => { | |
const replaceText = (selector, text) => { | |
const element = document.getElementById(selector) | |
if (element) element.innerText = text | |
} | |
for (const type of ['chrome', 'node', 'electron']) { | |
replaceText(`${type}-version`, process.versions[type]) | |
} | |
}) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// This file is required by the index.html file and will | |
// be executed in the renderer process for that window. | |
// No Node.js APIs are available in this process because | |
// `nodeIntegration` is turned off. Use `preload.js` to | |
// selectively enable features needed in the rendering | |
// process. | |
const ipcRenderer = require('electron').ipcRenderer; | |
document.getElementById("minimize").addEventListener('click', () => { | |
ipcRenderer.send('minimize-me') | |
}); | |
document.getElementById("quit").addEventListener('click', () => { | |
ipcRenderer.send('quit') | |
}); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/* Empty */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment