Created
May 8, 2013 01:38
-
-
Save BenjaminPoulain/5537575 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Index: Source/WebCore/ChangeLog | |
=================================================================== | |
--- Source/WebCore/ChangeLog (revision 149704) | |
+++ Source/WebCore/ChangeLog (working copy) | |
@@ -1,3 +1,13 @@ | |
+2013-05-07 Benjamin Poulain <[email protected]> | |
+ | |
+ We should not ref() the RefPtr twice in CanvasStyle | |
+ | |
+ Reviewed by NOBODY (OOPS!). | |
+ | |
+ * html/canvas/CanvasStyle.cpp: | |
+ (WebCore::CanvasStyle::CanvasStyle): | |
+ We leak the ref of PassRefPtr, we should not ref() it a second time. | |
+ | |
2013-05-07 Anders Carlsson <[email protected]> | |
Begin unraveling the mess that is QuotesData | |
Index: Source/WebCore/html/canvas/CanvasStyle.cpp | |
=================================================================== | |
--- Source/WebCore/html/canvas/CanvasStyle.cpp (revision 149696) | |
+++ Source/WebCore/html/canvas/CanvasStyle.cpp (working copy) | |
@@ -127,14 +127,12 @@ | |
: m_type(Gradient) | |
, m_gradient(gradient.leakRef()) | |
{ | |
- m_gradient->ref(); | |
} | |
CanvasStyle::CanvasStyle(PassRefPtr<CanvasPattern> pattern) | |
: m_type(ImagePattern) | |
, m_pattern(pattern.leakRef()) | |
{ | |
- m_pattern->ref(); | |
} | |
CanvasStyle::~CanvasStyle() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment