Plugin to fix the dreaded "Cannot read property 'width' of null." crash for "In Stars And Time"

BU_FixOliviaAnimatedPictures.js

/*:
@plugindesc Fix 'cannot read property "width" of null' crash in Olivia_AnimatedPictures.
@author Benjamin Urquhart
*/


{
    // Add functions that causes the crash here.
    let functions = ["resetFrame", "updateAnimatedPictureFrame"]

    for(let name of functions) {
        console.log("Patching " + name);
        (function(name) {
            let orig = Sprite_Picture.prototype[name];
            Sprite_Picture.prototype[name] = function(bitmap) {
                // The plugin relies on Sprite_Picture.loadBitmap returning fast enough to
                // set the bitmap field on the sprite object. This is usually the case, 
                // but not guaranteed. If the function takes a bit longer to return
                // than normal, the field is not set and we crash.
                
                // However, Bitmap.prototype._callLoadListeners provides the bitmap
                // as an argument, so we can just use that here instead.
                
                // tl;dr race condition.
                if(!this.bitmap) {
                    if(bitmap) {
                        console.warn("Load listener " + name + " was called before return of Sprite_Picture.loadBitmap");
                        this.bitmap = bitmap;
                    }
                    else {
                        // Bail
                        console.warn("Attempted call to " + name + " with no bitmap");
                        return;
                    }
                }
                return orig.call(this, ...arguments);
            }
        })(name);
    }
}