Skip to content

Instantly share code, notes, and snippets.

@BrianLitwin

BrianLitwin/review_#1113.md

Last active March 10, 2019 01:23
Show Gist options
  • Save BrianLitwin/19a1ce3855923aea09332c7ebd5edc0c to your computer and use it in GitHub Desktop.
Save BrianLitwin/19a1ce3855923aea09332c7ebd5edc0c to your computer and use it in GitHub Desktop.
Download ZIP
Raw
review_#1113.md

  • loads a combined graph for every adapter provided

  • check that repo exists w/ RepoIdRegistry

  • call adapter.load for each

outcomes:

  • returns repo_not_loaded
    • if one of paramters to adapter.load isn't right => sourcecredDirectory or repoId
  • loads successfully => returns a combined graph from the provided adapters individual graphs
  • returns a plugin failure

would it be crazy to write more specific errors? ways it could fail: repoId not provided

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment