Created
November 26, 2019 16:29
-
-
Save BrianLitwin/7758507e64175972352902c21d24a55d to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) don't allow a user to click out of the modal when with invalid text (on-click nil) | |
2) don't allow a user to finalize a doc w/ invalid input (on-click nil) | |
3) don't show a "please select an existing item" error when All Strategies selected (update spec (if optional .. )) | |
4) don't show 1 filter selected if user is typing ? | |
-> (if on-clear (on-clear) (on-click) ... but see below | |
5) don't show 1 filter selected or weirdness when you click outside the dropdown ... | |
-> what happens when you click outsided the dropdown? What's called? | |
update the :on-click methods and possibly the same for asset_tab's dropdown - rm on-clear | |
i think the intent is to call (on-click `nil`) in those places anyway | |
try to be imperative and not create implicit dependencies |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment