Skip to content

Instantly share code, notes, and snippets.

@BrianLitwin
Last active February 22, 2019 19:56
Show Gist options
  • Save BrianLitwin/86428bcd819c392c4afcc6dc1c024837 to your computer and use it in GitHub Desktop.
Save BrianLitwin/86428bcd819c392c4afcc6dc1c024837 to your computer and use it in GitHub Desktop.
  • Commit message
    • Brief, desciptive (not overly descriptive)
    • 50 characters
    • written in the imperative mood ("add" instead of "added")
    • no trailing puncuation
    • should either be in sentence case (i.e., the first letter of the first word capitalized), or of the form “area: change description”.
  • Description
    • Why is the change important?
    • Did you consider and reject alternate formulations of the same idea?
    • Are there relevant issues or discussions elsewhere?
  • Test plan
    • Describe what someone should do to verify that your changes are correct
    • automated tests
    • manual tests
    • tests of the form “verify that when you change the code in this way, you see this effect.”
    • shell commands and expected outputs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment