notes for #1059.md

Part III

Chrome 71, Mac

1. re: -> the white columns: appears to be an issue in Chrome: https://stackoverflow.com/questions/52395298/chrome-shows-thin-line-if-table-has-td-background-image. Firefox and IE don't have issue.
2. Highlight will get stuck sometimes:

Again, only on Chrome, not Firefox or IE. this is due to the 'focus:within' property tripping after you click on a button

3. description:

/* To apply 'hoverHighlight', provide a backgroundImage with
 * two <image> data types (eg linear gradients).
 * The first backgroundImage will be the default background.
 * The second backgroundImage will be applied over the first
 * when the user hovers or tabs over the element.

Part II

• white columns in screenshot
• :focus selector
• add documentation to highlight

Part I

sourcecred/sourcecred#1059 (review) :

• use #EBF1F5

• highlight rows at all depths

• put ss in commit message/ pr description

• figure out a way to test without using aphrodite internals sourcecred/sourcecred#1059 (comment)

• don't create aphrodite styles dynamically sourcecred/sourcecred#1059 (comment)

• remove beforeEach() and afterEach() functions sourcecred/sourcecred#1059 (comment)

• update table mock in test sourcecred/sourcecred#1059 (comment)

• Refactor the loop-test-case to fail if someone adds another depth sourcecred/sourcecred#1059 (comment)

sourcecred/sourcecred#1059 (review)

• Fix mouse-only effects (accessibility)
• increase contrast further