IronScripter Prequel 1

ISPrequel1-Monitors.ps1

function Get-MonitorInfo {
    [CmdletBinding()]
    Param(
        [Parameter(ValueFromPipelineByPropertyName=$true)]
        [string[]]$ComputerName = $env:COMPUTERNAME
    )

    $MonitorSelect = @(
        @{
            N = 'ComputerName'
            E = { $_.PSComputerName }
        },
        @{
            N = 'ComputerType'
            E = [scriptblock]::Create("'$(Get-CimInstance -Class Win32_ComputerSystem -ComputerName $ComputerName | select -ExpandProperty Model)'")
        },
        @{
            N = 'ComputerSerial'
            E = [scriptblock]::Create("'$(Get-CimInstance -Class Win32_Bios -ComputerName $ComputerName | select -ExpandProperty SerialNumber)'")
        },
        @{
            N = 'MonitorSerial'
            E = { (-join( $_.SerialNumberID | %{[char]$_ } )) | ?{$_ -ne 0} }
        },
        @{
            N = 'MonitorType'
            E = { (-join( $_.UserFriendlyName | %{[char]$_ } )) | ?{$_ -ne ''} }
        }
    )

    Get-CimInstance -Class wmiMonitorID -namespace root\wmi -ComputerName $ComputerName | Select $MonitorSelect
}

• Correct typos
• Identify additional needed class (Win32_Bios)
• Properly check nulls/zeroes
• Add ComputerName parameter with a default value pointing to localhost
• Use a select statement instead of creating multiple individual psobjects
• Pre-define select statement and perform additional calls inside of the literal to reduce the number of variables
• Switch from Get-WmiObject to Get-CimInstance
• Convert to a function