Skip to content

Instantly share code, notes, and snippets.

@DDuarte
Last active December 19, 2015 20:58
Show Gist options
  • Select an option

  • Save DDuarte/6016435 to your computer and use it in GitHub Desktop.

Select an option

Save DDuarte/6016435 to your computer and use it in GitHub Desktop.
TDB 335.52 -> 335.53 changelog
Commit log from '3875ae0' to 'e4c57d8' (most recent changes are listed on top):
e4c57d8 TDB 335.53 - 2014/03/29
205294b DB/Text: Added the missing page texts for the book "The Archmage Antonidas - Part I"
d8779da DB/Text: Added the missing page texts for the book "Portals are NOT Garbage Bins!"Closes #3362
a3e56b0 Core/Dependencies: Upgrade to jemalloc-3.5.1
f7659e5 Core/Battlegrounds: Fix log errors about creatures not foundMove "Battleground::GetBGCreature: creature not found for BG" error log to INFO level when the caller expects no creatures to be found, like on Battleground startup.
Closes #3538
8c44259 Core/Misc: Fix some static analysis issuesFix uninitialized values, most of which are false positives, always initialized before being accessed.
Add some asserts and additional NULL checks as sanity checks. Use SpellMgr::EnsureSpellInfo() if the spell id is valid and always supposed to return a valid not-NULL SpellInfo* .
30894c2 Quest: Direhorn RaidersRemove duplicate kill credit
46b8bc8 Fix non-pch build and remove blank line
808a199 Quest: The Power of the ElementsRemove hack SAI, use aura script
1767418 Core/SAI: Allow only creature sources to use the event types SMART_EVENT_DISTANCE_CREATURE and SMART_EVENT_DISTANCE_GAMEOBJECT for now.
76641bc Core/SAI: Only allow SMART_EVENT_TARGET_BUFFED to be used from creature sources.
78e9a3e Core/SAI: Implement two new event types that are triggered when a certain creature/gameobject entry or guid gets within a given distance of the source.
84365f4 Scripts/Icecrown Citadel: Fixed Muradin/Saurfang attacking each other during Gunship BattleCloses #11786
ef1bb62 Build system: Fix clang buildSee wiki for latest build instructions under Mac OS X!
f357597 Buildsystem: Changed required CMake version to 2.8.9 and removed a check for version we no longer support in msvc settings
ce93838 DB/Creature: Fix Living Storm coordsBy Magnifikator closes #11785
5570e32 Core/Misc: Fix assertion triggeredChange an assertion added in 6dcd8c8545a65a7bfbd0daaa16f650d8c3a90262 with a NULL check, properly handling the case of a NULL parameter.
Fixes #11771
ed801e3 DB/Quest; Fix Preying Upon the Weak trapsBy untaught, closes #6858
de66390 Update 2014_03_24_02_world_creature_classlevelstats.sql
b4dec55 Cmake: Added level restriction for msvc 2013
5acdd63 DB/Misc: Miscellaneous fixesBy dr-j, closes #11780
Fix wrong loot in two chests for quest 'The Shadow Tomb'.
Fix turning in of 13120 Deaths Gaze.
Fix torching sunfury hold.
899b6da Update readme for cmake version for c++11 stuff
4c83f51 DB/SAI: Ferocious Yeti spamming BerserkBy dr-j closes #11776
361ceb2 DB/SAI: Elemental SlaveBy untaught, updates #11742
6e73e39 DB/SAI: UmpiBy dr-j, closes #11775
e0c6001 DB/SAI: Fix Dun Garok Rifleman spamBy dr-j, closes #11773
53005cc DB/Quest: Fix wrong ExclusiveGroupBy untaught, Closes #11715
a0e873f Update README.md
aeff794 Core/Logging: Fixed filenames of backup logsCloses #11765
894eb9a DB/Misc: Set comment of creature_classlevelstats to textBy Magnifikator closes #11762
9d0f59f DB/Quest: Fixes Gino's visibility and quest chainBy nelegalno and Rushor, closes #9030
a777e42 DB/SAI: Fix Shadowsworn CultistBy dr-j, closes #11767
cd20be2 Scripts/Icecrown Citadel* Deathbringer Saurfang will now evade if any player stands on the gunship
* Fixed players being stuck in combat after defeating gunship
* Fixed players not sticking to gunships
c3d2236 Core/Misc: Removed unused defines, added missing include and removed a few warnings
3affa3a Buildsystem/GCC: Enforce version 4.7.2 and enable c++11 compilation
e469ff5 Fixed build without PCH
a4d8a26 Scripts/Icecrown Citadel: Icecrown Gunship Battle
d292559 Merge pull request #11763 from MitchesD/miscScripts/ZulAman/Halazzi: convert text to create_text and fixed despawn of cat
550cbca Core/Transports: Enabled LoS on transports
d9d0884 Scripts/ZulAman/Halazzi: convert text to create_text and fixed despawn of cat
3a1a55b Core/Spells: Fixed target selection hooks running twice for each effect if both target A and B were using the same hook type (OnObjectAreaTargetSelect, OnObjectTargetSelect, OnDestinationTargetSelect)
3c16c63 Core/Transports: Fixed crashes happening when a transport was despawned with players/dynamicobjects on it
529cabe Core/Map: Save weather, light and music overrides in map to send them to players logging in
0758c47 Core/Spells: Fixed crash happening when a spell script set target to NULL in OnObjectTargetSelect hook for spells using nearby target selection
75f16f0 DB/SAI: Fix startup errorBy untaught, closes #11587
6dcd8c8 Core/Misc: Fix some static analysis issuesFix some static analysis issues about:
- uninitialized values, most of which are false positives, always initialized before being accessed
- unchecked return values
- dead code never executed
- bad formatting leading to wrong behavior
Please ensure EventMap is never used with event id set to 0 or those events will never execute.
409f4bf Merge pull request #11761 from MitchesD/miscScripts/Spells: fix logic fail in q9874
e40d4e6 Scripts/Spells: fix logic fail in q9874
9e99db0 Core/Misc: Fix some static analysis issuesAdd some asserts and additional NULL checks as sanity checks.
ada0598 Core/Transports: Fixed creatures micro movement on transport when attacking something (fixes interrupting melee animation)
d728899 DB/SAI: Fix Bloodscalp Axe ThrowerBy dimasiu Closes #11758, closes #11755
33316bd Merge pull request #11747 from untaught/Trinity1Core/Scripts: Move 'The Defias Traitor' script to SAI
bcf6edd Merge pull request #11749 from untaught/Trinity2Core/Scripts: Move condition for 'npc_marin_noggenfogger' gossip menu op...
9ad8c32 Merge pull request #11757 from untaught/Trinity3Core/Scripts: Move 'npc_deathly_usher' scripts to SAI.
a9121c6 Merge pull request #11746 from untaught/Trinity0Core/Scripts: Move condition for 'npc_skorn_whitecloud' gossip menu opti...
0c3633e Core/GameObjects: Added workaround for elevators having different position for every playerCloses #11504
4c27c83 Core/Misc: Fix some static analysis issues
8a9bfbb Core/Scripts: Move 'npc_deathly_usher' scripts to SAI.
46ccb1d Core/Creatures: Added check for creature_equip_template.id = 0. 0 is a special value telling core to unequip all items
9a5e89c DB/Quest: Fix reputation for repeatable Timbermaw hold quests
894a9bb DB: Fix typos in game_tele
f59eabd Core/Scripts: Move condition for 'npc_marin_noggenfogger' gossip menu option to DB and remove 'npc_marin_noggenfogger' script
38c33f6 Core/Scripts: Move condition for 'npc_skorn_whitecloud' gossip menu option to DB and remove 'npc_skorn_whitecloud' script
4bcbcf5 Core/Script: Logical fixes
42d53d9 Core/Game: Logical fix
a762f72 Authserver: Fix typo
38611a6 DB/Quest: Add Empowerment to Shadowmourne quest lineThanks @Foldor. Closes #11425
c31ffd7 Core/Scripts: Move 'The Defias Traitor' script to SAI
1a0b3e5 DB/SAI: Stop Ferocious Yeti spammingBy untaught, closes #11731
678d886 Merge pull request #11732 from Dehravor/loot-exploitCore/Loot: Fix an exploit that allowed players to loot infinite amount of items that have condition(s)
7401ab7 Core/Loot: Fix an exploit that allowed players to loot infinite amount of items that have condition(s)
3ce545a DB/Misc: Fix more startup errorsUpdates #11587
3adc8f2 DB/Quest: Sneak Previewby untaught and MitchesD, closes #11710
126eb12 DB/Quest: The Bones of NozronnBy untaught, closes #11720
f8938c2 Merge pull request #11718 from untaught/masterInstance Script/Stratholme: Correct logic in Baron Run event and add SAI...
69fb964 Fixed build with TRINITY_DEBUG
263c5ca Core/Maps: Fixed height calculations used in WorldObject::UpdateGroundPositionZ/WorldObject::UpdateAllowedPositionZ, they will now take vmaps into account.
f0f4a62 Core/Transports: Added support for DynamicObjects on transports
f26a028 Core/Misc: Fix some static analysis issuesFix some static analysis issues about uninitialized values. Most of them are false positives, always initialized before being accessed.
5f7e0f6 Instance Script/Stratholme: Correct logic in Baron Run event and add SAI for Ysida Harmon
fe30ddc DB/Quest: The DesertersBy untaught closes #11665
157bf45 DB/Creature: Fix 2 mobs incorrectly using prowlBy untaught and mario-64, closes #11703
a1aa454 Scripts/Krikthir the Gatewatcher: Fix EVENT_ANUBAR_CHARGE event not being triggeredFix EVENT_ANUBAR_CHARGE not being triggered due to value 0 being set to the EVENT_ANUBAR_CHARGE enum, even if 0 is a special value for EventMap to specify no event was triggered.
Issue added in a127c0e1a7612094c2bf8b2f5092f55aa96f0556
e30b471 Scripts/AhnKahet: Fix some uninitialized valuesInitialize all class fields in the constructor, even if they are set in Reset() and they shouldn't be accessed before Reset() is called.
This fixes 2 Coverity reports.
3b247f6 Scripts/ZulGurub/Jeklik: Add missing "break"
61c9891 Core/Gossip: Fix crash added in 6c64fa8de36dad958821c6078b3f2f5f5753a2fcFix NULL dereference crash caused by a typo in 6c64fa8de36dad958821c6078b3f2f5f5753a2fc
a884007 DB/SAI: No Rest For The WickedBy MitchesD, closes #11709
6c64fa8 Core/Gossip: Add security to C++ scripted gossip options by checking guid of the object that the player is interecting with. Idea by @LilleCarlCloses #11567
78398ed DB/SAI: The book of the RavenBy untaught, closes #11570
1c6f2c9 Merge pull request #11694 from Rochet2/patch-1Core/Gossip: Change max menu items to 32
cfdd942 Core/Gossip: Change max menu items to 32Tested and a gossip menu can show max 32 items on a menu.
When sending 40 options: http://puu.sh/7rqb6.jpg
5221bd8 Core/Items: Fixed an exploit allowing people to put more gems than number of sockets on items.Closes #11652
6f1005a Core/Misc: Get rid of whitespaces added in 96e0a7d71f1c5146aa64502d49e0cc2260f7ca16
d4416c0 Merge pull request #11627 from Rochet2/OnPlayerSaveCore/Players: Call sScriptMgr::OnPlayerSave inside Player::SaveToDB rather than before calling it.
1f98435 Update Player.cppDont trigger save hook on player create
96e0a7d Merge pull request #11666 from kontownik/scripting_projectCore/Scripts: Introduce ItemScript::OnItemRemove, called when an Item is actually destroyed.
4d215e7 Update 2014_03_09_00_world_spell_group.sql
5817951 DB/Spells: Fix Thunderclap bugging Infected WoundsBy untaught. Closes #6291.
ba28b16 Scripts/TheStormPeaks: Possible crash fixApply safe NULL checks added in 7d881a073961887d446d4430905f315b52928bb1 to similar code in same script
d357597 Scripts/Commands: Fix crash in ".kick" commandFix a NULL dereference exception happening when using .kick command caused by a strtok(NULL) call without a previous call to the string to be tokenized.
Issue added in 101cad1f2872a87be925b74b9d17760381bb9808
de91f71 SQL: Renamed a few files to match our naming standards
3c1f635 Herman Walker, Grumman Slatefist and Shenarial are now officially battlemasters. Karg Skullgore & Sawemba have been reassigned to their duty of random BGs battlemasters.
b8cfd27 DB/Items: Fix some startup errorsUpdates #11587
932173f DB/Creature: Fix wrong npcflag for Alchemist KanhuBy MrSmite, closes #11671
db3c4b3 DB/Loot: Harbinger SkyrissBy MitchesD, closes #11670
91850fa Core/Scripts: New ItemScript trigger, OnItemRemove
437b97f Update 2014_03_03_00_creature_text.sql
2bea809 DB/SAI: Loken's OrdersBy dr-j, closes #4855
c908fc4 Rename 2014_03_03_00_gossip.sql to 2014_03_03_01_world_gossip.sql
844332c DB/Gossip: Add missing textsNote: https://github.com/TrinityCore/TrinityCore/blob/master/src/server/scripts/Kalimdor/CavernsOfTime/EscapeFromDurnholdeKeep/old_hillsbrad.cpp needs to be moved into db.
de522e5 DB/Creature: Commander Stoutbeard's yellCloses #7948
e4ab18a Dep/ACE: Fix assertion triggered on shutdownFix assertion triggered on shutdown on Windows platform Debug mode by back-porting fix from ACE revision 96226.
Fixes #9770.
3a40d8a Core/Player: delete queststatus (weekly/monthly/seasonal) on deleting character thx @Expecto - also rename some prepared statementsCloses #11658
994b14b Rename 2014_02_27_01_world_sai.sql to 2014_02_27_02_world_sai.sql
d5d2805 Core/MMAPs: Replace an assert with error logReplace an assert in PathGenerator::BuildPolyPath() about invalid poly reference with an error log.
Fixes #11493 .
dd2746c DB/SAI: The Grimtotem Weaponby dr-j closes #3119
075fa51 DB/SAI: Fix The Multiphase SurveyCloses #6279 by untaught.
367da1e DB/Trainers: Fix some spells avariabilityCloses #11248
edcd757 DB/Gameobject: Dun Argol CageBy dr-j, closes #11649
ce01544 DB/Gameobject: cage door quest Freedom for all creaturesUpdates #4823, this only closes door, it still needs scripting.
61890bc Scripts/Onyxia Lair: Fix debug assertions about iterators
272009e Core/MMAPs: Add support for raycastAdd an optional parameter "straightLine" to PathGenerator::CalculatePath() which will use raycast instead of path finding and will return only complete path from start to end position.
Implement this new type of path in SPELL_EFFECT_CHARGE , fixing strange behaviors when using Charge with mmaps enabled.
a5d860c DB/Items: Fix some startup errorsUpdates #11587
50e0c39 Core/Battlegrounds: Fix invalidated iterator crashPartially revert e1bee86ee6f5c3ab7b1da6d1b54c98c2851f11ec and restore 9ba3d07fc22864daa51b2faf327ac3336569e463 to store battleground queues as std::list instead of std::deque because deque::erase() invalidates all iterators.
3610200 DB/Quest: Fix Bride of the EmbalmerBy untaught closes #11546
392f95a DB/Items: Fix some startup errorsUpdates #11587
81618fb Merge pull request #11642 from Dehravor/group-stateCore/Group: Fix online state when member logs out
f7bc86a Core/MMAPs: Update recastUpdate recast from https://github.com/memononen/recastnavigation/commit/1be9de72d87dcfdecf6bea30f5461745f7d7afe6 to https://github.com/memononen/recastnavigation/commit/740a7ba51600a3c87ce5667ae276a38284a1ce75 .
This differs from https://github.com/TrinityCore/TrinityCore/commit/aa645683b8b25bfb35cb977678daf5c56c1531e6 because it includes a fix https://github.com/memononen/recastnavigation/commit/77ebf643531c90ea712b496e23c48f0b0671f43d which correctly extract tile connections when using rcMergePolyMeshes(), used by mmaps_generator.
MMAPs version is now set to 5.
Re-extract MMAPs using mmaps_generator , any old extracted MMAPs will not work.
fb90e13 Core/Group: Fix online state when member logs out
66b4b5e DB/Quest: Fix Corrosion PreventionBy untaught closes #11630
d1a992b DB/Conditions: Fix gnome mount vendors for non-gnomes
d291519 DB/Creature: Fix db errors added on fd8a669
9b182b4 DB/Creature: Add trigger flag to Multiphase DisturbanceUpdates #6279
fd8a669 DB/Creature: Remove random movement from "Webbed Creature"By baric, closes #9607
28484a1 DB/Creature: Misc fixes to Thomas Yance and guards aroundUpdates: #3905
6d9bd3d DB/Quests: Corrected a typo, because typos suck.
3f6cc33 DB/Quest: Update OfferRewardText for quest 396Notice: i realize of the typo, but wowhead shows that text, if anyone have a prof of it's wowhead typo i will fix it.
Closes #11534
6d396eb DB/Creature: Commander Hogarth must be male human.Closes #11581
537a6df DB/Misc: Coding standards
160d024 DB/Misc: Fix more startup errorsBy Fateswhisper and me. Updates #11587
NOTE: ref "Missing WDB data." we have more of those and since i don't fill WDBVerified it's correct.
419287e DB/Misc: Fix some startup errorsUpdates #11587
b90f07d Core: Trigger OnSave hook for PlayerScript on all save events
27d69cf Core/Chat: Fix BuildChatPacket calls so scripts that use OnPlayerChat can actually change the textCloses #11625
873bf28 Misc Move file to proper place
29027a1 DB/Creature: Correct Felmist gas cloud model
61096a6 Merge pull request #11616 from Ascathor/masterCore/LFR: Fix a theoretical error with item_level
c223b88 Core/LFR: Fix a theoretical error with item_level Despite the check never happening (player->GetAverageItemLevel() < 0 is impossible), it is more efficient. Also improves codestyle consistency. Original fix by @emsy.
52ac656 DB/Reputation: Fix Oracle and Frenzyheart Tribe reputationCloses #11106
4c9949d DB/Creature: Delete some double spawnsUpdates #1515
ecdf304 DB/Creature: Fix another trigger visible to players
3d80783 DB/Creature: spawn Stabled Argent WarhorseBy Foldor, closes #11479, updates #11043
50d9900 Scripts/Ulduar: Fix Algalon the Observer outro phase(fixes kill credit and some achieves).
cb237a4 Core/PlayerDump: fix mail items and gifts export
006d72a Core/MMAPS: Fix invisible wall issue in MMAPS.Fix invisible wall issues in MMAPS caused by tile connections not being extracted correctly.
This reverts aa645683b8b25bfb35cb977678daf5c56c1531e6 and restores an old version of recastnavigation, most likely https://github.com/memononen/recastnavigation/commit/1be9de72d87dcfdecf6bea30f5461745f7d7afe6 .
Re-extracting MMAPS is required.
b9db1ab DB/Quest: Fix 3 quests textsBy MrSmite, closes #11585, closes #11582
96c50c4 DB/Items: Fix some startup errorsBy Fateswhisper, updates #11587
1aada1f Merge pull request #11584 from Dehravor/groupGroup related fixes
b722730 Core/DB/Achievements: - fixed arena season title achievements and rewards - added mailtemplate support for `achievement_reward` table - fixed typo in GetBattleMasterBG which causes achievement reward mail expire in 1 dayRef #8777
a5a6799 Scripts: Added missing stuff in 1d1aeda86ca69e78daf85c3c4b1b29509c374ad7
1d1aeda Core: Fix build
6688370 Merge pull request #11457 from MitchesD/krikthirScripts/Krikthir the Gatewatcher: converted to EventMap and small optimalization
a127c0e Scripts/Krikthir the Gatewatcher: converted to EventMap and small optimization
a352e5b DB/Creature: Fix another trigger visibilityUpdates #5182, by mweinelt
0f82a5f DB/Creature: Fix more triggers visibilityCloses #8178
18823bc DB/Creature: Fix more triggers visibilityIf anyone can post a complete list of triggers visible to players but no to gms create a ticket with them, thx.
7a188c8 Core/SAI: Fix assertion in SMART_ACTION_CALL_RANDOM_RANGE_TIMED_ACTIONLISTFix assertion triggered in SMART_ACTION_CALL_RANDOM_RANGE_TIMED_ACTIONLIST if max entry is less than min entry
2974057 DB/Creature: Fix another trigger visibilityThey where visible to players and invisible to gms.
08cd624 Core/Group: Any party member may mark targets (this does not apply to raid groups)Also ensure that the targeted player is not hostile.
2e897d0 Core/Group: Fix exploitThe master looter should be in the group.
6eac6ec DB/Creature: Fix trigger visibilityThey where visible to players and invisible to gms.
916d84b Core/Group: Add sanity checks to CMSG_LOOT_METHOD's handlerIf lootMethod or lootThreshold is invalid, portrait menus become unusable to the entire raid.
94b912f DB/Items: Added "few" missing items.
28946ac Core/SAI: Improve error logLog both target and current Object when checking if a Creature/GameObject have SmartAI enabled.
dbed818 Core/SAI: Fix crashDisable script type SMART_SCRIPT_TYPE_TIMED_ACTIONLIST actions if they are trying to overwrite the timed action list while iterating it.
This was invalidating the iterator and deleting any smart action stored in it, including the current executed one.
Valgrind log:
Invalid read of size 1
at SmartScript::OnUpdate(unsigned int) (SmartScript.cpp:3258)
by SmartAI::UpdateAI(unsigned int) (SmartAI.cpp:331)
by Creature::Update(unsigned int) (Creature.cpp:544)
Address 0x1807d9b2 is 10 bytes after a block of size 40 alloc'd
at operator new(unsigned long) (vg_replace_malloc.c:319)
...
by SmartAIMgr::LoadSmartAIFromDB() (SmartScriptMgr.cpp:231)
by World::SetInitialWorldSettings() (World.cpp:1724)
by Master::Run() (Master.cpp:169)
by main (Main.cpp:142)
aaa4b3a Scripts/Eastern Plaguelands: Fix flypath exploitFix npc id 17209 in Eastern Plaguelands enabling taxi cheat to players just by talking to it.
fdc7111 Merge pull request #11580 from Dehravor/wardenCore/Warden: Fix crash
Fix NULL dereference crash in case Warden is disabled (in configs or on Mac OS X platform) and client sends a CMSG_WARDEN_DATA opcode
592b57a Shared/Logs: Code cleanupRemove unneeded check added in 89af6097f37587e178ac412252326351ca655075
12cafcf Core/Warden: Fix crash
89af609 Shared/Logs: Make AppenderFile more thread-safeIn case of dynamic file names don't store the FILE* handle in a shared class variable but keep it only at function scope.
Valgrind log:
at _IO_un_link (genops.c:69)
by fclose@@GLIBC_2.2.5 (iofclose.c:55)
by AppenderFile::CloseFile() (AppenderFile.cpp:94)
by AppenderFile::_write(LogMessage const&) (AppenderFile.cpp:66)
by Appender::write(LogMessage&) (Appender.cpp:102)
by Logger::write(LogMessage&) const (Logger.cpp:63)
by Log::write(LogMessage*) (Log.cpp:279)
by Log::vlog(std::string const&, LogLevel, char const*, __va_list_tag*) (Log.cpp:267)
by Log::outMessage(std::string const&, LogLevel, char const*, ...) (Log.h:129)
Address 0x2a1bd2d0 is 0 bytes inside a block of size 568 free'd
at free (vg_replace_malloc.c:468)
by fclose@@GLIBC_2.2.5 (iofclose.c:85)
by AppenderFile::CloseFile() (AppenderFile.cpp:94)
by AppenderFile::_write(LogMessage const&) (AppenderFile.cpp:66)
by Appender::write(LogMessage&) (Appender.cpp:102)
by Logger::write(LogMessage&) const (Logger.cpp:63)
by Log::write(LogMessage*) (Log.cpp:279)
by Log::vlog(std::string const&, LogLevel, char const*, __va_list_tag*) (Log.cpp:267)
by Log::outMessage(std::string const&, LogLevel, char const*, ...) (Log.h:129)
672e06a Shared/Logs: Add workaround for "w" flag used with dynamic name filesIgnore "w" flag and always use "a" for log files with dynamic name since the file handle is created at every log line and "w" would delete any other logged line from previous _write() calls.
The best solution would be to overwrite only at first call and append at any other call.
79e30bb Revert "DB/Misc: A lucky bag random fixes"This reverts commit 3fcb1bf09140e59a878911cd889d5047cf8a0ca6.
b76e2db SQL: Maybe I'll have more luck :(
3fcb1bf DB/Misc: A lucky bag random fixes
b9074f34@Core/Achievements: rename some AchievementCriteriaDataTypes to keep consistent
84e7344 Core/Spells: Possible crash fixGet Unit target with the proper method instead of retrieving Object target and then casting it to Unit, possible dereferencing NULL.
Updates #11560
20a1f4d Core/CrashHandler: Add more informations about localsHandle SymTagData with inner type of SymTagPointerType.
Increase buffer sizes to avoid buffer overflows.
Avoid infinite loops by logging the children of each type only once.
Avoid too deep nesting by adding a max nesting level.
Print the address for arrays instead of just the name.
b000fdc Core/Entities: allow interaction with gameobject questgivers if player can take or return questsCloses #11269
Closes #8898
Closes #10204
Closes #11410
Closes #7053
Closes #6189
Closes #9474
59e14b2 DB/Gameobject: Fix Dire PoolCloses #9893
1b2e4d8 Remove whitespaces from previous commit
d0c9970 Authserver / Worldserver: Fix warnings about unused variables
0d51fd5 Core/Auras: Implemented SPELL_AURA_MOD_COOLDOWNCloses #9671
3092421 Merge pull request #11568 from Rochet2/VendorChecksCore: Add rest of checks from SendListInventory to BuyItemFromVendorSlot
72ed06d Core/Achievements: Use ACE_OS::localtime_r instead of localtime in my previous commit for thread safety.Thanks to @Shauren
f29463c Core/Achievements: Implement criteria type ACHIEVEMENT_CRITERIA_TYPE_ON_LOGIN and criteria requirements ACHIEVEMENT_CRITERIA_REQUIRE_NTH_BIRTHDAY and ACHIEVEMENT_CRITERIA_REQUIRE_KNOWN_TITLE. Fixes anniversary achievements.By @Schmoozerd
a2022d6 DB/SAI: Fix Dire Maul entrance leversUpdates #6298
4959336 Core: Add rest of checks from SendListInventory to BuyItemFromVendorSlot
0e2c86f Rename 2014_01_21_world_access_requirement.sql to 2014_02_04_00_world_access_requirement.sql
988c289 Merge pull request #11095 from gerripeach/pull_request3Core/LFG: Minimum item level in Wotlk heroic dungeons
d006f4b Core/Spells: Fixed AoE damage reduction auras, original patch by @Unholychick
996e911 Core/Groups: Fixed UnitIsPartyLeader lua function
f1bfd43 Core/Misc: remove error log, which returns false positives
e59f3f7 Core/Chat: Fix a new issue caused by c0224dd7ca9a39034518bd7e6285702636749929 which would trigger false positives for CHAT_MSG_AFK and CHAT_MSG_DND.
8f29fb9 Core/Spell: Handle SPELL_AURA_FORCE_REACTION missing casesAlways check forced reputation ranks before any other faction check to get the reaction between 2 units.
Fixes #5790
11b4856 Core/Spells: fix crash when loading custom spell attr with invalid spellid
2df3fe3 Core/Scripts: Fix quest The Totem of Kar'dash alliance version.Remove some hungarian notation for horde side version.
Closes #11035
822092e DB/Creature: Fix warnings with creature_formations loading
c0224dd Core/Chat: Fix an exploit where it was possible to speak in universal language in say/yell/emote by sending CMSG_MESSAGECHAT using cheats.
19172ee Build: Use override/final keywords for VS 2012 and newer. (VS 2013 still defines __cplusplus as 199711L)
b054275 Shared/Logs: Fix crash in Console log outputCorrectly handle the return value of vsnprintf() which returns -1 if the buffer is too small http://msdn.microsoft.com/en-us/library/1kt27hek.aspx . In this case just truncate the output.
This caused a crash on character delete if Logger.entities.player.dump was enabled and set to 3.
Fixes #11539
68d48ec Core/Arena: Fix arena season not always appearing to clientsArena season sent to client with SMSG_INIT_WORLD_STATES opcode was not sent if Player was on a zone with id 0 on login. Initializing the zone id to -1 will always trigger UpdateZone() properly on login.
Fixes #10623
83e0cc3 SQL: Update 2014_01_31_01_world_item_template.sql
956fde1 DB/item_template: Set defaults of spellcharges_X to 0 instead of NULLCloses #10748
Signed-off-by: Duarte Duarte <dnpd.dd@gmail.com>
5666c7c Core/Achievs: Rename a few unknown achievement criteria flagsSource tomrus88, Mangos
ad26d2e SQL: Fixed two issues with 2014_01_31_00_world_spell_custom_attr.sqlEngine should be MyISAM and not MRG_MyISAM
MySQL doesn't play nice with hex values so converted them to decimal
Closes #11537
a242662 Core/Spells: Fix DK Ghoul's damage after ad8eb434c02e451effd0949aaa7d2b7999d91597. I misread 'SpellScript::m_damage' for 'SpellScript::damage'.By @joschiwald
efeb541 SQL: Update old .sql files to keep consistency with auth_database.sqlAlso update characters_database.sql (generated by mysqldump)
d749b72 Core&DB/Spells: Move custom spell attributes from code to DB, `spell_custom_attr` table`spell_custom_attr`
- `entry` uint PK
- `attributes` uint (enum SpellCustomAttributes of SpellInfo.h)
9495194 Fix warnings introduced on littleendian in 2134cb610d45727a0623741f7416a360882133faThis fix prevents possible issues on bigendian machines. Don't use c style casts ppl, it's evul.
856e093 Scripts/HoR: Fix log errorFix "DoZoneInCombat called for creature that has empty threat list" error caused by DoZoneInCombat() called by IsSummonedBy() in a script before the Creature is allowed to enter combat.
378d27f Core/Splines: Fix "velocity > 0.1f" errorUpdates #6191.
ad8eb43 Core/Misc: Missing changes and get rid of useless method in acd46085d1f496657e27e0d5f823f53d466702dc
acd4608 Core/Spells: drop last leftovers of hardcoded spell target selection and move it into spellscriptsCloses #1719
Closes #3186
747184a DB/Creature: Fix some factionsUpdates #11501
1b48c7b DB/Creature: Fix some factionsUpdates #11501
9433374 DB/Creature: Fix some factionsUpdates #11501
ef45560 DB/Creature: Fix some factionsUpdates #11501
60a3b31 DB/Creature: Fix some factionsUpdates #11501
b595599 DB/Creature: Typo fix.
818430b DB/Creature: Fix some factionsUpdates #11501
b5a0750 DB/Creature: Fix some factionsUpdates #11501
25d0aca DB/Creature: Fix some startup errorsUpdates #11501
a1e2137 DB/Creature: Fix some factionsUpdates #11501
4567faa SQL: Rename in correct name
166f7d4 Core/Spells: addition to 96060bf0078441e779c4cfcaa80f66ac5e97a3ff
f9ab8ec DB/Creature: Fix some factionsUpdates #11501
6b3c5b7 DB/Creature: Fix some factionsUpdates #11501
6c17bcf DB/Creature: Fix some factionsUpdates #11501
ac7828a DB/Creature: Fix some factionsUpdates #11501
0d5c10d DB/Creature: Fix some factionsUpdates #11501
ffea6d0 DB/Creature: Fix some factionsUpdates #11501
9d863e2 DB/Creature Fix 2 models of mobsBy alpharius, closes #11210
95f49c6 DB/Creature: Fix some factionsUpdates #11501
2f103a7 DB/Misc: Fix startup error added on 22508d1
c97d69e DB/Creature: Fix some factionsUpdates #11501
c7310d2 DB/Creature: Fix some factions and levelsUpdates #11501
22508d1 DB/Gameobject: Spawn TEMP Greater MoonlightBy Darkman1983, closes #4945
0b3ae67 DB/Misc: Fix Lunar Festival Invitation teleport coordinatesBy Vincent-Michael, updates #4945
ec020ea SQL: Rename in correct name
6c140a0 DB/Conditions: Requiere DK to use Scourge GryphonBy dr-j, closes #11133
9d108de DB/Quest: Treats for Great-father WinterBy dr-j, closes #11320
c38b974 DB/Creature: Fix Shaman ElementalsBy Vincent-Michael, closes #11261
c536207 DB/Creature: Delete incorrectly spawned Gharsul the RemorselessCloses #11242
56a04c7 DB/Quest: Seek the FarstridersBy MrSmite, closes #11244
6dc1529 Core/Spells: move paladins judgements to spellscripts
db2718c DB/Creature: Fix Seeping Feral EssenceBy Fateswhisper closes #11517
139ee0c Fix incorrect debug log in authserver
38436f2 Core/Gameobjects: Fix not being able to use the fishing node/float after 6b25c2b4147a237ab07c99dbd3563cedfda2f8fc
2134cb6 Remove unneeded bigendian checks (they're already part of EndianConvert).
ffe1e6e Core/LFG: Minimum item level in Wotlk heroic dungeonsWotLK Heroics, beside Trial of the Champion, Pit of Saron, Halls of Reflection and The Forge of Souls unlock with an average item level of 160.
Also Trial of the Champion (normal) and The Forge of Souls (normal) unlock with an item level of 160.
http://www.wowwiki.com/Dungeon_Finder?oldid=2404648#Wrath_of_the_Lich_King_dungeons
79a2a0c Core/Spell: Fix logic fail in 96ae4caf6258882cf89ff6d4bb3ac5aa0a3474f7
d39b36b Tools/VMAP: Fix a logic error in processArgv of vmapexport
d2e782a Core/Spells: Add SPELL_ATTR0_CU_REQ_CASTER_BEHIND_TARGET to some Backstab spellsOriginal fix by Bruescrues
Closes #10767
Signed-off-by: Duarte Duarte <dnpd.dd@gmail.com>
96ae4ca Core/Spells: Fix typo in 955fb907c549fea0088f8c105714cc9fb931da15
955fb90 Core: Fix warnings
fbddda5 Core/Spells: move more spells to spellscripts
5c36a50 DB/SAI: The Earthen OathBy dr-j closes #6966
744d6f1 DB/SAI:Emergency Protocol: Section 8.2, Paragraph DBy dr-j, closes #11206
880a5f5 Merge branch 'master' of github.com:TrinityCore/TrinityCore
527d054 DB/SAI: Fix freed from the HiveBy dr-j, closes #11438
96060bf Core/Spells: move some spells so spellscripts
798bbc3 DB/SAI: Blast the Infernals!By dr-j, closes #11428
3c0b906 DB/SAI: The Power of the ElementsBy dr-j and untaught, closes #6479
bc63c33 DB/SAI: Fix Highlord DemitrianBy Raszagal closes #11436
784ebb8 Tools: Fix build for MacACE_thread_t returned by ACE_Thread::self is a struct in Mac OS
f48eb03 DB/Loot: FelweedBy SQLfix closes #11329
b408517 DB/Quest: Dragonmaw Race: Wing Commander IchmanBy Raszagal closes #11429
68a0864 DB/SAI: Remove Obsolete SAI from Gordunni ProxyBy dr-j closes #11207
88a5d01 Core/Calendar: Crash fixAttempt to fix #11512 crash by adding a NULL check since GetEvent() can return NULL.
dbd7cd3 Rename 2014_01_24_03_world_sai.sql to 2014_01_24_03_world_sai.sql
a9ac43e DB/SAI: Fix Administering the SalveBy dr-j closes #11375
edc292b DB/Creature: Rhapsody ShindiggerBy MitchesD closes #11191
725d5dc DB/SAI: Fix Scalewing SerpentBy burned, closes #6285
6b25c2b Core/Gameobjects: Fix an exploit where it was possible to use gameobjects from any distance. Fixes for example picking up the WSG flag from any distance using hacking tools.
c6650ec Core/Spells: Move Pilgrims Bounty BuffFood in AuraScript (mimimi)
dcc20a7 Merge pull request #11508 from Dehravor/talent-wipeCore/SkillHandler: Check if player is using proper NPC on talent reset
e619246 Core/SkillHandler: Check if player is using proper NPC on talent reset
9531073 Scripts: Gossip can crash with null instance
d7f76f2 Merge pull request #11396 from natepizzle/masterSpellAuraEffects
08bc9da Merge pull request #11499 from Dehravor/taxi-nodeCore/Taxi: Fix exploit related to unexplored nodes
abc1eff Core: Fix non pch build
b169d6b Fix build
f0c4224 Core/Spells: move killing spree to spellscriptCloses #10597
Closes #11468
46e1b93 Scripts: A lots of changes here and there (maybe useless?!?)
92c3ca7 Core/CrashHandler: Add more informations about localsLog "NULL" for NULL pointers.
Log the correct type instead of <user defined> for pointers and log its fields recursively.
Log locals of all threads.
Log the address if retrieving the value threw an exception.
Increase buffer sizes to avoid buffer overflows.
d6c5307 Scripts/Spells: use new hook in some spellscripts
30a7ea9 DB/Creature Fix faction of some creaturesBy Justiciar, closes #10711
7d8b65b Core/Chat: Disallow sending CMSG_MESSAGECHAT with CHAT_MSG_SAY, CHAT_MSG_EMOTE or CHAT_MSG_YELL while the sender is not alive. Also replaced all WorldSession::_player calls by 'sender'By @TakenBacon
cb19647 Core/Loot: Fix an exploit with CMSG_LOOT using non-creature guids which would allow you to loot despawned chests in some cases.By @Kiddie
f731116 Scripts/AhnKahet: fix some issues on prince taldaram script
a5b04e0 Core/SpellScripts: Implemeted SpellScript hook OnDestinationTargetSelect to easier modify SpellDestinations
e8e23ef Core/Taxi: Fix exploit related to unexplored nodes
40b9ea3 DB/SAI Fix The Torch of RetributionBy FireEmerald closes #11356
17f1180 DB/Creature: Fix Rubble Stalker KologarnBy Vincent-Michael, closes #5507
3871421 DB/Loot:Icetouched EarthragerRemove Incorrectly dropping mote of earth, by dr-j closes #11216
e619ec2 DB/Vendor: Add Boots - Lesser Accurecy recipeBy dr-j, closes #8113
d22cd69 DB/Graveyard: gm island graveyardBy Vincent-Michael, closes #9789
df90f58 DB/Item Fix Living Ruby PendantBy Odyssey, fixes #11314
f722d7e DB/Creature: Fix VoidspawnerBy Kittnz, closes #11382
b53d9a7 DB/Creature: Fix for Tenebron Egg ControllerBy untaught closes #11321
2917c39 DB/Game_Event: Fix Boxey BoltspinnerBy Hitox closes #11409
3527630 DB/Conditions Fix gnome mount vendorsBy dr-j closes #11406
52aa14f DB/SAI: Fix Dragon maw scoutBy dr-j closes #11414
4c0c982 DB/Conditions: Fix Banishing CrystalBy MitchesD closes #11430
984b712 DB/Quest: Fix Karuk's Oath availabilityBy Raszagal closes #11451
57e599f Scripts/ZulGurub/Jeklik: fixed flying in first phase, reworked spawn and rewritten to EventMapCloses #11277
9fbca6e Dep/Recast: Add diff file for previous commit
6788148 Shared/OpenSSLCrypto: Add switch to fix build under Mac
0db2549 Dep: Rename custom typedef to prevent redefinition under Mac OS
516a634 Misc: Fix warnings
e3c013d DB/SAI: Fix Aludane Whitecloud spawing adds
101ac7f Misc: Minor cosmetic changes here and there
bebb581 Core/SAI: I need more sleep...
bf0d8c1 Core/SAI: Implement three more event phases which makes a total of 9 (from 6).Ref. #11486
e169e24 DB/SAI: Fix Saronite Mine SlaveBy dr-j closes #11452
9d85d0d Core/Misc: Fix compile.Forgot to save file
3207066 Core/Weather: Weather updates are now sent to all players in the zone instead of the first player it finds in the zone and all players nearby.Thanks to @Nawuko, @Magnifikator and @Shauren
Closes #11380
Fixes #11370
cde9717 Core/Spell: Retaliation no longer does anything while the warrior is stunned.Closes #11481
f79a881 Merge pull request #11459 from Bonitas/masterCore/Spells: Fix proc for spells that should trigger on taken hots
70c6828 Merge pull request #11464 from Dehravor/ticket-memory-leakCore/Tickets: Fix memory leak when malformed CMSG_GMTICKET_CREATE is received
d4479d9 Missing changes in 313b294d6b7b248738e30f8164ee4624a66ac5b5
313b294 Core/RBAC: Fix difference problems with 4.3.4
138a336 CoreCore/CrashHandler: Handle CRT asserts in Windows buildHandle CRT asserts in Windows crash handler instead of popping up a Abort/Retry/Ignore window
3102da5 Misc/SQL: Rename SQL from fa2616fe4efa4651d48710c7458cd2d479e9338b
8a5c544 Merge pull request #11469 from Dehravor/timetest-crashCore/Misc: Fix crash
3802cc2 Core/Creature: Fix compile and logic in previous pull request. Also implemented UNIT_NPC_FLAG_MAILBOX.Thanks @Shauren
00f5460 Core/Misc: Fix crash
f626416 Merge pull request #11299 from Carbenium/MailboxCmdCore/Command: Add mailbox command
939a253 Core/CrashHandler: Fix issues on Windows crash handlerFix few issues on WheatyExceptionReport:
- fix NULL dereference exception in GetLogicalAddress() when TC assert in triggered ( *((volatile int*)NULL) = 0; )
- fix infinite loop in DumpTypeIndex() when dumping std types like std::string
- fix FormatSymbolValue() pointing to wrong address when accessing local variable values
- use portable types instead of x86 specific types, this fixes some wrong address issues on x86 platform
- use bigger buffers to format symbols to avoid buffer overflows
c7b78a2 Core/Commands: Using the '.gm vis off' command now instantly makes the GM invisible to non-GM players, instead of waiting until Player::UpdateObjectVisibility was called from a different method.Ref. #11467
e1f1e0c Core/Misc: Split the calculating of the corpse reclaim delay and sending of SMSG_CORPSE_RECLAIM_DELAY in two different methods.
55bde59 Merge pull request #10386 from Discover-/Health-FunnelCore/Spells: Health Funnel now always damages the warlock, even if it do...
18ab91b Core/Misc: The timer that indicates how long it takes until the player can reclaim their corpse now starts counting down when the player releases its spirit instead of when they die. Fixes an issue where the 'Accept' button in the reclaim corpse window would already be clickable but have no effect (WorldSession::HandleReclaimCorpseOpcode::L754).
c18fd03 Core/Scripts: Fix the cleanup in 54dbf870b8fc1f0aef1ef95c8786303998762173.
8367944 Core/Scripts: Fix kill credit for quest The Hunter and the Prince(13400).
e609779 Core/Tickets: Fix memory leak when malformed CMSG_GMTICKET_CREATE is received
68af937 Core/Calendar: Add documentation regarding fix in previous commit
ca6fd8a Merge pull request #11462 from Dehravor/add-event-memleaksCore/Calendar: Fix memory leaks due to BytebufferException thrown
c431f46 Core/Items: Fixed swapping equipment sets in combat
3a9a634 Core/Calendar: Fix memory leak when guild announcement is created
51e3887 Core/Calendar: Fix memory leak when malformed CMSG_CALENDAR_ADD_EVENT is received
09a73a3 Core/Spells: Fix proc for spells that should trigger on taken hots
735cebf Core/Commands: The .setskill command is now usable even if the player doesn't already have the skill learned.
bbd84d2 Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
ebfdeb0 Core/Spells: Rename Spell::EffectSummonDeadPet with Spell::EffectResurrectPet and get rid of two TODO's that are already done.
e2376fc Merge pull request #11397 from Dehravor/guild-view-offinoteCore/Guild: Don't allow players to view officer notes without proper rights
ea740de Rename 2014_01_02_00_trinity_string.sql to 2014_01_17_00_trinity_string.sql
101cad1 Show Kick, Mute and Ban in world
c1a4683 Core/Misc: When a player changes its faction its only removed from all its arena teams if cross-faction interaction is turned off.
940e522 Core/Entities: bg vehicle will also have charmer's faction (save faction before charm and restore old faction after charm)
45dc95c Core/Items: Fix an exploit where the player was able to send CMSG_SET_AMMO with items they didn't have in their bags. Only a visual bug (not sure if it gave bonuses too, which iirc do appear in later expansions).
61f4528 Core/Misc: Fix an exploit where moving while consuming something that would fade when the player stands up would stay if the player started moving and using the effect at the same time. Thanks to @FrozenSoul and @jildor.Fixes #6271
cbba22b Core/SAI: Fix assertion triggered in SmartScriptRemove assertion in SmartScript added in b8625f41bd6131e7fb3ff126780da18d5d2959fd and handle SmartScripts with GetBaseObject() returning NULL , like SmartTrigger . In this case SmartScript::mTargetStorage cannot be sanitized and might contain references to free'd WorldObjects if the script doesn't last a single Map::Update() call.
6e01c0b DB: update more creature templates
d78e69c Core/Instances: Fix memory leak in InstanceSaveMgrFix memory leak in InstanceSaveMgr added in 1f170c99efec6c89b9a454a3aa17511341f61659 .
Make InstanceSave::SetToDelete() private since it's not supposed to be used by anything other than InstanceSave or its friend class InstanceSaveMgr .
88ecc95 Core/Entities: Fix combat state setting when FFA PvP flag is setDescription:
Currently there is an issue, when you are in FFA areas, but you dont have PvP flag activated.
You should get the PvP-In-Combat delay timer, but instead you just get the usual timer as if you would not fight in PvP.
Reproduction:
1) Get two players in FFA area Gurubashi arena down in the battle area (.tele Gurubashi)
2) Fight each other
3) When stopping combat, the combat state will switch off immediately. But it is supposed to switch off after some delay, because it was a PvP fight.
Closes #11103
Signed-off-by: Duarte Duarte <dnpd.dd@gmail.com>
80a3983 Core/Player: Fix compile error introduced in ##11377 merge
949dc9b Merge pull request #11377 from Yelvann/masterCore/Instances: Fix exploit too much players in instances/raids
b8625f4 Core/SAI: Fix crash in SmartScriptFix crash in SmartScript storing WorldObject* instead of guid as targets in SmartScript::mTargetStorage , used by SMART_TARGET_STORED target type , SMART_ESCORT_TARGETS and other escort related code.
Fixes #11228 , #10157 .
Valgrind log:
Invalid read of size 4
at : Object::GetTypeId() const (Object.h:140)
by : SmartScript::IsPlayer(WorldObject*) (SmartScript.h:73)
by : SmartScript::ProcessAction(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:330)
by : SmartScript::ProcessEvent(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:2662)
by : SmartScript::ProcessAction(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:2226)
by : SmartScript::ProcessTimedAction(SmartScriptHolder&, unsigned int const&, unsigned int const&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:2238)
by : SmartScript::ProcessEvent(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:2685)
by : SmartScript::UpdateTimer(SmartScriptHolder&, unsigned int) (SmartScript.cpp:3198)
by : SmartScript::OnUpdate(unsigned int) (SmartScript.cpp:3244)
by : SmartAI::UpdateAI(unsigned int) (SmartAI.cpp:331)
by : Creature::Update(unsigned int) (Creature.cpp:544)
by : void Trinity::ObjectUpdater::Visit<Creature>(GridRefManager<Creature>&) (GridNotifiers.cpp:340)
de1d75a Spells: Fix Alcohol-Free Brewfest SamplerCloses #10956
Signed-off-by: Duarte Duarte <dnpd.dd@gmail.com>
23acf75 Core/Movement: Add LOS check for fleeingmovement target point.Prevents fleeing or feared units from going to upper floor ignoring walls/ceilings with mmaps on(and usually get stucked).
Current implementation just randomly selects a distance and angle against the frighting unit, when in narrow circumstance such as underground caves, such targeting point would be at another floor.
Closes #11300
Ref #9475 (needs fixed confirmation)
0eadb41 Merge pull request #11310 from Ric101/can_quest_rewardCore/Players: On CanRewardQuest, use the same item dest vector for all potential rewards
Solves issues where the player has enough bag space for each item individually, but not all of them together.
Example to reproduce previous issue:
Obtain Battle of the Crimson Watch (10781)
Make sure you only have 1 slot available in your inventory
Turn in the quest, watch as you don't receive one of the rewards
65c941b Merge pull request #11342 from Carbenium/SvalaScripting/Utgarde Pinnaccle: Fix visual during Svala's transformation
b83c252 Scripts/NPCs: Remove core script for rogue trainers which was overriding db conditionsSAI and conditions for rogue trainers to provide elegant leter to rogues provided that is level 24 or higher, does not have elegant letter and does not have taken, rewarded or complete the quest which elegant letter starts
Closes #11378
Signed-off-by: DDuarte <dnpd.dd@gmail.com>
a1f0798 DB/Guild: Fix incorrect input length limitsThere is one incorrect field length related to guilds in the database, which can be used to cause an overflow client-side, by sending CMSG_GUILD_INFO_TEXT with long strings.
The guild information has the same 500 characters client-side limit as the guild bank tab information, but on server-side it can be 65k characters long. A lengthy guild info makes the whole Guild panel unusable.
Length of the other fields match the client's limits in the database: guild bank tab name (16), public note (31), officer note (31), motd (128), guild bank tab info (500).
Closes #11395
Signed-off-by: DDuarte <dnpd.dd@gmail.com>
0b5728f Core&Conf: Small cosmetic fixesCloses #11392
Signed-off-by: DDuarte <dnpd.dd@gmail.com>
e42cc9d Merge pull request #11426 from Dehravor/invalidate-playerCore/Entities: Implement SMSG_INVALIDATE_PLAYER
c9d81bd Merge pull request #11427 from Dehravor/force-renameCore/Entities: Don't allow to login while character is forced to rename
4d3b7e6 Core/Entities: Don't allow to login while character is forced to rename
619f42c Core/Entities: Implement SMSG_INVALIDATE_PLAYER
086622b Core/Battlegrounds: Fix offline players not being resurrected when Battleground endsFixes #7081
6f6ad95 Core/Wintergrasp: Fix typo in CMSG_HEARTH_AND_RESURRECT handlerFix CMSG_HEARTH_AND_RESURRECT handler trying to resurrect players with 100x hp/mana/energy ( SetHealth()/SetPower() were sanitizing the input anyway ) .
8fcfabe Core/Spells: Fix potions cooldown in combatFix a cooldown issue related to potions allowing Players in combat to use more than 1 potion in a row, especially with high latency.
This also fixes an exploit about using infinite potions in combat just by skipping the client-side check.
The original implementation c064c2e2e1eebd43b273365583dd181293bafa22 was missing a check in Spell::CheckCast() about this particular case since Potion cooldown is added only after the Player goes out of combat.
Fixes #1259 .
41b6131 Core/Battlefield: some codestyle changes
7378bae Scripts/PoS/Garfrost: cleanup saronit blocks after death
7ec7fcf Core/SAI: drop unneeded code
dc09715 DB/Spawns: remove duplicate NPCs on Zeppelin from Orgrimmar to Thunder BluffCloses #11420
6fff9d0 Fix build
e80d1f3 Scripts/BloodFurnace: * cleanup InstanceScript * fix broggok poison cloudScripts/Naxxramas/Grobbulus:
* fix poison cloud
* fix mutating injection
1a5c0ad DB/Creature: update more creature templates
2b9234b DB: update some creature templates
a60ba24 Core/Entities: add some log messages in CheckCreatureTemplate * Happy Error Spam
619edff Misc:* Tools: Fixed a compile warning
* Commands: Fixed npcflag format in .npc info
15cbe58 Core/Movement: Fixed vehicle passengers disappearing clientsideCloses #11411
95f14f9 Scripts/HoS: update Maiden of Grief
ad84759 Core/Threading: Handle CMSG_ZONEUPDATE only in WorldSession update - changing zones triggers changing chat channels, what is not a thread safe operation
738afcc DB/Spells: correct more spelldifficulty_dbc entries * add log message to find wrong entries
853b9e9 DB/Spells: remove duplicate/invalid entries from spelldifficulty_dbc * For new entries: use spellid0 as id to avoid conflicts with dbc file
cd76d32 Core/Entities: correct creature damage, offhand damage should work too * todo: some creatures need dmg_multiplier update in creature_template
ff61e4d Scripts/Halion: Fixed Soul Consumption's pull effect.Thanks to Winterfell for pointing out the issue.
1f170c9 Core/Instances: Fix Instance bindingFix players not being bound to instance if the group was disbanded before killing any boss.
Fixes #437
9d6904f Core/Vehicles* Fixed vehicle orientation on transports
* Fixed exiting vehicles on moving transports
e794e85 Core/Guild: HandleRoster should always have a valid session
03fbc0a Core/Guild: Implement GR_RIGHT_VIEWOFFNOTE
360fb8a Update SpellAuraEffects.cpp
8b897bc Update SpellAuraEffects.cpp
1b6d0a9 Update SpellAuraEffects.cppAdded Several Well Fed Item-Spells
82181a8 Core/Loot: Fix Master Loot exploitFix Master Loot exploit allowing any online Player to receive loot.
e773c9a Update more copyright note for 2014. I have no excuse for my fail :/
b5e0caa Merge pull request #11394 from Dehravor/guild-create-logCore/Guild: Fix an exploit related to CMSG_GUILD_CREATE
1428732 Core/Guild: Fix an exploit related to CMSG_GUILD_CREATE
2000405 Update copyright note for 2014.Happy new year.
0c2f534 Core/Quests: Fix crash on startupFix a crash on startup when loading Quest POIs if quest_poi table referenced POIs not in quest_poi_points table, caused by 5de48a67c6b650e98271acc704de8c4ed432bf4f .
Fixes 11390.
fd72065 Merge pull request #11391 from Nawuko/waypoint-fixCore/Waypoints: Revert partly f1a82a578be525624c416ba5f882b2f1a7e13536 t...
3209a32 Core/Waypoints: Revert partly f1a82a578be525624c416ba5f882b2f1a7e13536 to fix a crash caused by accessing uninitialized splines
0e7805b Db/Classlevelstats: Little fix for base warrior damage. I won't be working on this anymore until next year
3018ff4 Core/Creature: Obtain Attack power and base damage from creature_classlevelstats table.
1cdc2e8 Core/Movement: Fixed creature movement on transports
9a1282a Core/Spells: Fixed movement from SPELL_EFFECT_PULL_TOWARDS_DEST
997d2ad DB/classlevelstats: Update mage exp0, exp1, exp2 base damage
ba43e38 DB/classlevelstats: Exp1 & Exp2 Paladin base damage. Exp1 57 to 60 and 71 to 73 estimated. Exp2 67 to 70 and 81 to 83 estimated.
27c58c3 DB/Classlevelstats: Fix damage for Exp0 Paladin Class. 25, 55, 59, and 61 to 83 are estimated all others are accurate.
64b42c7 Scripts/Misc: Code cleanupRemove some NULL checks not needed anymore after 3744c141841917075c295c3c38643e3d156eb9d4 .
Fix an invalid Creature to TempSummon cast.
6ec7b03 Merge pull request #11386 from Nawuko/vincent-fixCore: user defined literals need a space in front
6d21d33 Core: user defined literals need a space in front
0895cdc Buildsystem: Fix GCC not being recognized on UbuntuFix CMake not recognizing /usr/bin/cc as GCC on Ubuntu ( 13.10 x64 ) .
799daaa Core/Transports: Fix array overflowFix an array overflow in TransportMgr::GeneratePath() spline code.
Valgrind log:
Invalid read of size 4
at : G3D::Vector3::operator*(float) const (Vector3.h:650)
by : Movement::C_Evaluate(G3D::Vector3 const*, float, G3D::Matrix4 const&, G3D::Vector3&) (Spline.cpp:103)
by : Movement::SplineBase::SegLengthCatmullRom(int) const (Spline.cpp:171)
by : Movement::SplineBase::SegLength(int) const (in /home/jackpoz/trinity/bin/worldserver)
by : Movement::Spline<double>::initLengths() (SplineImpl.h:86)
by : TransportMgr::GeneratePath(GameObjectTemplate const*, TransportTemplate*) (TransportMgr.cpp:125)
by : TransportMgr::LoadTransportTemplates() (TransportMgr.cpp:78)
Address 0x1d07d154 is 8 bytes after a block of size 300 alloc'd
99b0ee1 DB/ClassLevelStats: All stats for testing.
b1431bd DB/Classlevelstats: Base damage for expansion 1
adf12d8 Core/Instances: Fix exploit too much players in instances/raids
6c74d66 DB/Classlevelstats: Add base damage for exp2
5d3a6fe Updated the compilation requirements to compile the core.For more informations read the following thread: http://www.trinitycore.org/f/topic/9214-updated-trinitycore-requirements-deprecation-of-old-compilers/
5c64dad Scripts/Misc: Fix uninitialized valuesFix uninitialized values in scripts reported by valgrind.
Fix target and GetOwner() NULL dereferences .
c40cdc2 Core/Chat: Fix assert triggered by .npc addFix an assert in Aura::_UnapplyForTarget() caused by ".npc add" changing the guid of the spawned Creature.
e016ef3 Merge branch 'master' of github.com:TrinityCore/TrinityCore
0e0b00c Scripting/War Master Voone: Fix Cleave spell and minor cleanup.
90c63e4 Scripts/Misc: Fix uninitialized valuesFix uninitialized values in scripts reported by valgrind.
079905e Core/Transports* Fixed transport orientation
* Fixed transport position desynchronization for stoppable transports
* Ignore spawnMask errors for objects spawned on transports
9af36d8 Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
4c66a3f Scripting/Boss Jandice Barov: Fix wrong spell id.
3744c14 Scripts/Misc: Ensure Creatures are in instances when requiredCreate ScriptedAIs that require a InstanceScript reference only if the InstanceScript exists, so if these Creatures are in an instance. ScriptedAIs that don't require a InstanceScript reference have not been modified.
This fixes many possible NULL dereference crashes happening when spawning a scripted Creature outside of an instance.
Fixed a GetOwner() and a ToPlayer() NULL dereference crashes too.
765cd83 DB/Creature_classlevelstats: update attack power.
2a7f030 Core/Misc: Fix warningsFix warnings appearing with -Wstrict-aliasing flag.
b854e5b DB/SAI: Fix for quest 12449 & 12417 from MitchesD. Closes #11373
6304c8d DB/Creature_classlevelstats: Add attack power. Rogue class still lacking data.
e62ad6a DB/Creature_classlevelstats: Prepare table for attack power and damage.
533180f Core/Battlegrounds: Removed unneeded code
29acf99 Core/Transports: Fixed new spawned transports not being visible for players already present on map
8d57e08 Merge pull request #11359 from MitchesD/obsidian_sanctumScripts/ObsidianSanctum: added creature_formations for surrounding creatures and some clean up
3921f20 Scripts/ObsidianSanctum: added creature_formations for surrounding creatures and some clean up
51af314 DB/SAI: Fix AI for Lord Kragaru
e255d1d Core/Transports: Fix possible crashFix a crash happening when deleting an instance with transports. This case doesn't appear in current sources but could have happened in ICC and HoR.
9b88a78 Scripts/Blood Furnace: Fix crash in Broggok scriptFix a NULL dereference exception in Broggok npc id 17380 script, happening when spawning it outside of an instance.
Fixes #11344
01a43e6 Core/QuestDef: Well I clicked revert but Git didn't play along.
fe95371 Core/Scripting: Replace casted with cast as casted is not a word.
fa29ddc Db/Misc: Fix more dup aura messages.
06edb4d DB/Misc: Fix some more dup aura errors.
baf04e4 Db/Misc: Fix a few more dup aura errors.
18f523f DB/Misc: Fix a couple errors I introduced.
890b47c Build fix
8bcde41 Core/Quests: Added stuff missing in previous commit
293915d Core/Quests: Fixed icon shown above questgivers with daily quests that have already been completed once by a characterCloses #11331
b8e6261 Scripting/Multi: Some cleanup.
20a2b69 Core/Chat: Fixed GM messages in chat channels after refactoring
54dbf87 Scripting: Some cleanup. Please keep broken English comments to yourself.
00b123b DB/Gameobjects: Added a few missing gameobject templates.
dbce8d9 Scripting/Hinterlands: Convert to TC style.
9d2d4ba Scripting/Hellfire: Moved some gossip to db and fix some magic numbers.
eacc165 Scripting/Ghostlands: Moved some gossip to db and fixed some magic numbers.
5e8f829 Core/SAI: Fixed a crash in call for help/flee for assist actions when they had an emote attached
8f4011c Scripting/Zones: Some cleanup.
fd6167c Scripts: - cleanup obsidian sanctum script - prevent yelling texts if non player died in some scripts
6858a23 Scripting/Borean Tundra: Fix some magic numbers.
47ac6d9 DB/Creature: Fix InhabitType for Val'kyr Battle-maiden. Closes #11347
1038fd8 DB/SAI: Fix a couple errors.
a2c3736 DB/Condition: Add Conditions for Captured Sunhawk Agent gossip text
7ef49db Scripting/Bloodmyst Isle: Moved Captured Sunhawk Agent gossip to db.
464632b Scripting/Blasted Lands: Shouldn't have removed ScriptedGossip.h
59ac243 Scripting/Blasted Lands: Fixed up gossip and teleport spell for quest 3628. Can someone please test this. I can't do group testing locally. Also snuck in a fix for zone_axshara.cpp
ab3eced Scripting/Misc: Some cleanup.
59eca90 Scripting/Blades Edge: Moved gossip to db for Overseer Nuaar and Sai'kkal the Elder.
a316b86 Core/Spells: Prevent adding sockets to items that have 3 sockets in item_template or already had a socket added to them
107af52 Core/Chat: Refactored building chat packets* Moved everything into one specialized method instead of being scattered all over the place
* Allow localizing creature names in chat messages (when using $N)
* Send SMSG_GM_MESSAGECHAT for gm messages
6402fa0 Scripting/Storm Peaks: A little work on Quest 13010 Krolmir, Hammer of Storms
8dd3c76 DB/SAI: Fix a few linking errors.
d741335 DB/Creature_text: Updated more text from sniff.
8aef174 DB/Creature text: Added some missing text from sniff.
dde3588 DB/Misc: Cleanup some more dup aura errors and fix an SAI.
5055a8f Scripting/Bloodmaul Brute: CombatAI moved to cpp for quest 10512.
bc9961e DB/Misc: Fix Typo
fe2d21b DB/Creature: Remove double spawn of Talonpriest Skizzik
b2c0a3d DB/quest_template: [FIX] Wrong Previous quest for 12836 Expression of Gratitude from DRJ Closes #11334
f29c50a DB/Misc: Moved npc Axle gossip to db. No npc's left with AIName & Scriptname.
34ce605 Scripting/DB: Fixed some npcs so they wouldn't have AIName & scriptname.
ff1773d DB/SAI: Converted a few SAI to use CMC and converted all using Caster Template.
d190228 Merge branch 'master' of github.com:TrinityCore/TrinityCore
b0ffbb2 Core/Auth: Fix expiring account bansFix a database race condition in authserver that would delay the account ban expiry by 1 login because the query that would have removed the ban was executed asynchronously.
27aeecf Scripting/Utgarde Pinnacle: Fix visual during Svala's transformation
42a365a DB/SAI: Fix a typo for all comments of smart_scripts using SMART_ACTION_INC_EVENT_PHASE (9ac96fd702d8ed23491d13eda2238312120cf52f). It now properly prints with how much the phase was incremented, instead of always saying it incremented by zero.
f31baac SQL: LQS elif emaneR
9ac96fd DB/SAI: Convert 28.236 smart_scripts (almost all, like 20 left behind) to proper commenting. Used this tool: https://github.com/Discover-/SAI-Comment-Converter
eb57c4f DB/Conditions: Fix a condition in earlier commit
b2724cf DB/Misc: Fix bad data from sniff parser
06d42af DB/Misc: Update Wintergrasp Battle-Mages
0b7a9a4 DB/Misc: Three more creature moved to SAI only.
d89a3b2 DB/Gossip: Moved Highlord Demitrian gossip to db. npc had SmartAI and cpp script.
cc79f27 DB/SAI: Fix a few more dup aura errors
57332e1 DB/SAI: Scripted all ogres in Blades Edge Mountains. Sorry I had to remove the awesome cpp script.
527219e DB/Misc: Fix a couple capitalization errors
7b5d5ab DB/Misc: Two missing paths and two missing Combat AI.
61c5857 Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
c5788de Core/SAI: Fix another memory leak, thanks to @Xter
39331ea Core/Logging: Use logger cache for speed up logger filter search
e44e932 Core/SAI: Fix two memoryleaks in my previous commits. Thanks to @Xter for the notice.
ec62bc6 Core/Dungeon Finder: Improve join log message to try to detect cases when one of the selected dungeons is 0 * Added specialization to all loggers related to lfg (allows to enable "lfg.join" in debug mode and keep all the rest in error)
18cc075 DB/Misc: Fixups for Toshley's Station, Blades Edge.
cb38252 DB/SAI: Some SAI updates to remove dup aura errors and some additions.
676baa8 Scripting/Dragonblight: Commander Eligor Dawnbringer now scripted. Purely cosmetic but it was a fun thing to script :)
e5f7bee Core/SAI: Using SMART_ACTION_FORCE_DESPAWN now despawns the given target_type instead of always the creature itself.
a0f7fee Core/SAI: Fix compile Core/SAI: Don't limit SMART_ACTION_SET_INGAME_PHASE_MASK to unit targets only. Thanks to @Shauren for the notice.
154ee46 Core/SAI: Using the action_type SMART_ACTION_SET_REACT_STATE now sets the react state of the target_type. Won't break any scripts as all current cases of this action_type have target_type 1 (SMART_TARGET_SELF).
1f4d585 Core/SAI: In all npc flag related action_types we now check if the target is a creature instead of an unit (creature/player).
b5e3332 DB/SAI: Fix two wrong action_types that would make the creature cast the Death Touch spell on no target (SMART_TARGET_NONE) instead of move to given target_x/y/z/o co-ordinates.The person who wrote this script accidently used action_type 11 (SMART_ACTION_CAST) instead of 69 (SMART_ACTION_MOVE_TO_POS), and since the action_param1 field of SMART_ACTION_MOVE_TO_POS is the motion id (point id given back to SMART_EVENT_MOVEMENTINFORM), it was set to 5. Ironically, the first parameter of SMART_ACTION_CAST is the spell id and it was spell id 5 is Death Touch.
However this script would do nothing because I changed it so that SMART_TARGET_NONE no longer functioned as SMART_TARGET_ACTION_INVOKER in this commit: 9653576cb4cc9449898d6af691c045d68e9361c5. Before this commit, though, it WOULD cast Death Touch. Fun fun fun.
20a2266 Core/SAI: Using SMART_ACTION_SET_FOLLOW with target_type 0 (SMART_TARGET_NONE) will now stop the following completely. Fixes 6 scripts in a clean TDB already using this functionality even though it wasn't implemented.
54b7162 Core/SAI: Make SMART_ACTION_SET_INGAME_PHASE_MASK set the phasemask of the target_type instead of always the source calling the action type.
1339d38 DB/SAI: Fix some duplicate aura errors and clean up the SAI.
b8f9442 Core/Player: Fix logic for questgiver cast spell
b3c810a Core/Misc: Fix warningPartially revert f0a742a8c471ba948d5d86c1ab5e3a74329a9a92 to fix a warning about unhandled switch case (the same case that Coverity reported as dead code) .
b890860 Core/AH: Fix memory leakFix memory leak in Auction House when creating an auction with stackable items and a stack of the same amount in the inventory. Leak added in 15a2acfb528728b824291cb49cdd9196e6f0d57d .
f1a82a5 Core/Waypoints: Stop creatures from skipping at waypoint nodes and add smoothing to pathing.
e90a7f8 Core/AI: Fix CreatureAI left uninitializedFix CreatureAI left uninitialized for 1 server tick for Creatures with DeathState:DEAD . This is a workaround required after c9cf2f059f8f33c3fcb58ad472871515e59df7c3 changes .
Valgrind log:
Conditional jump or move depends on uninitialised value(s)
at : npc_draenei_survivor::npc_draenei_survivorAI::MoveInLineOfSight(Unit*) (zone_azuremyst_isle.cpp:104)
by : CreatureAI::MoveInLineOfSight_Safe(Unit*) (CreatureAI.cpp:123)
by : CreatureUnitRelocationWorker(Creature*, Unit*) (GridNotifiers.cpp:134)
by : Trinity::AIRelocationNotifier::Visit(GridRefManager<Creature>&) (GridNotifiers.cpp:252)
Uninitialised value was created by a heap allocation
at : operator new(unsigned long) (vg_replace_malloc.c:319)
by : npc_draenei_survivor::GetAI(Creature*) const (zone_azuremyst_isle.cpp:66)
by : ScriptMgr::GetCreatureAI(Creature*) (ScriptMgr.cpp:792)
by : FactorySelector::selectAI(Creature*) (CreatureAISelector.cpp:41)
by : Creature::AIM_Initialize(CreatureAI*) (Creature.cpp:716)
by : Creature::AddToWorld() (Creature.cpp:190)
9dd30ac DB/Creature: Misc template updates
dd4a774 Core/Transports: Fix memory leak on shutdownFix world transports not being deleted on shutdown.
a2e7191 Core/Unit: prevent COMMAND_ATTACK being added for Trained Rock Falcon. Also added spells for Trained Rock Falcon to db.
f0a742a Core/Misc: Remove unused codeRemove unused debugging code added in MaNGOS r5067.
Remove dead code from a switch found by Coverity.
89ee8cb Core/Unit: Add switch to prevent COMMAND_ATTACK being added to action bar for supplied creature entries.
dcfbe53 Core/Player: Fix questgiver spell cast.
d5f6c2e Merge branch 'master' of github.com:TrinityCore/TrinityCore
f5c2dca Scripts: fix crash in spell_jokkum_scriptcastCloses #11313
e17af3f Core/Quests: Fix an issue where auto-completed quests would not be automatically completed if the quest was added through either the SmartAI action_type SMART_ACTION_ADD_QUEST, the spell effect SPELL_EFFECT_QUEST_START or the opcode CMSG_QUEST_CONFIRM_ACCEPT. Also fixes auto-complete quests in the SAI and opcode case not calling the AI hook.
ec8e94c Core/AI: Fix an issue where the OnQuestAccept hooks were not called for auto-completed quests.Fixes #11304
ca6b9df Core/Misc: Fix some static analysis issuesFix some static analysis issues about uninitialized values.
1c0903e Core/Misc: Fix some static analysis issuesFix some static analysis issues about uninitialized values. Most of them are false positives, always initialized before being accessed, while some of them are real issues spotted by valgrind too.
dd546f0 Core/Player: Add another exception to questgiver spell casting.
e28cc46 Core/Movement: Fix invalid memory accessFix the stack implementation used in MotionMaster and added few sanity checks to ensure no underflows will be made.
Valgrind log:
Invalid read of size 8
at : MotionMaster::top() const (MotionMaster.h:115)
by : MotionMaster::pop() (MotionMaster.h:91)
by : MotionMaster::~MotionMaster() (MotionMaster.cpp:74)
by : Unit::~Unit() (Unit.cpp:296)
by : Player::~Player() (Player.cpp:880)
by : WorldSession::HandleCharCreateCallback(Trinity::AutoPtr<PreparedResultSet, ACE_Thread_Mutex>, CharacterCreateInfo*) (CharacterHandler.cpp:665)
by : WorldSession::HandleCharCreateCallback(Trinity::AutoPtr<PreparedResultSet, ACE_Thread_Mutex>, CharacterCreateInfo*) (CharacterHandler.cpp:516)
9d9d1fb DB/SAI: Fix an error in Bladespire Mystic SAI
4ca6341 Core/SmartAI: SMART_ACTION_UPDATE_TEMPLATE will no longer ignore the target type and force the source creature (creature only) to be updated; from now on it updates the given targets to the given entry (actionparam1)
c045d4c Core/SmartAI: Reset Actions will not be processed until creature reaches home.
2f3cc24 Renamed method
9f74143 Core/AI: Some code cleanup
9d95351 Core/SmartAI: Fixed issue where ranged caster would switch to combat ready state between cast.
a8484d2 Core/Players: On CanRewardQuest, use the same item dest vector for all potential rewards
3cee0b7 Merge pull request #11309 from Lartza/masterDB/SAI: Fix typo
d9dac7b Fix typo
54fd53f Core/Movement: Fixed possible invalid memory access
385e2db DB/SAI: Fix one linking error and updated a few to use CMC "Combat Movement Control"
fb26e18 Core: Fix warnings
e7e708e DB/Misc: fixed comment in one SAI script.
a20c89f DB/Misc: Some Combat AI, Remove spawns, and aura fixes.
551e51b DB/Waypoints: Some Outlands waypoints. Mostly Blade's Edge.
a40e814 Core/SmartScripts: speedup loading/validating sai scripts from dbBefore:
>> Loaded 6953 SmartAI scripts in 3543 ms
After:
>> Loaded SmartAIMgr Helpers in 4 ms
>> Loaded 6953 SmartAI scripts in 95 ms
488841d Merge pull request #11306 from trickerer/fixaggroDon't allow units to enter combat upon death
fc7e335 Scripting/Obsidian Sanctum: Updated scripts to use Events.
91ebea4 Don't allow units to enter combat upon death
eddf1b5 Scripts: replace some SetOrientation() calls with spline packets and some random changes
bb45db6 Merge pull request #11275 from Carbenium/UtgardePinnacleScripts/UtgardePinnacle: Convert Svala Sorrowgrave to event system
000bfbb Convert Svala Sorrowgrave to event system
74facef Scripting/Storm Peaks: Renamed npc_brann_bronzebeard script because name has already been used.
6af40a2 DB/Misc: Mostly cosmetic for Storm Peaks with a few SAI updates. "It's like eye liner for your TC server"
ceaa6c3 Core/Enums: Few inns/zones use the zone itself for the resting state instead of an areatrigger.
bdcbcc5 DB/Waypoints: Fix error in previous sql.
1b7f41a DB/Waypoints: All pathing for Stormforged War Golem.
822755c Core/Misc: Fix some static analysis issuesFix some static analysis issues about uninitialized values.
b6f4ab4 DB/Waypoints: Add missing waypoints for Stormforged Taskmaster and 3 missing spawns
a3ff7ea Scripting/Storm Peaks: Tested all my sql but not the title :P
755283a Scripting/Storm Peaks: Quest 13285 "Forging the Keystone" now scripted. Closes #6921
f33023b DB/Misc: Darkspeaker R'khem now has chains. Closes #7316
dd4aee2 Scripting/Howling Fjord: Fix Quest 11310 Warning: Some Assembly Required Quest is doable and completeable with the following Issues: Aura not being removed from player after Abomination explodes. Camera angle should not changes after Abomination explodes. Can't check if Abomination leaves Halgrind. GetAreaId returns players area id.
f418f4c Core/Misc: Fix some static analysis issuesFix some static analysis issues about uninitialized values in scripts.
Add spell id validation in Unit::SpellNonMeleeDamageLog() .
b76d141 Core: Fix warning
0e37faf Scripting/Razorfen Downs: That emote shouldn't have slipped in there.
ae597c3 Scripting/Razorfen Downs: Discovered some missing text for boss Glutton.
5c15e88 Core/Unit: Add switch to prevent COMMAND_ATTACK being added to action bar for supplied creature entries.
98d2dbb Core/Spells: Fixed rare issues where spell modifiers would not be correctly restored.Happens in case of a spell having more than one modifier granted by an aura.
0447806 DB/SAI: Grimscale Murloc shouldn't fear Closes #11259
a05b7b4 DB/SAI: Aokromes likes to inform me of one typo at a time :)
1fa8c6e DB/Misc: Fix typo
877ad17 DB/SAI: Fix my stupid mistake
997dcf0 DB/SAI: Remove bad unneeded Springpaw Stalker & Elder Springpaw SAI
2ed05e4 Core: Fix non pch build
89de7e7 Scripting/Razorfen Downs: Additions and fixes for instance. Moved bosses Glutton, Mordresh Fire Eye, Tuten Kash to cpp. Cleaned up code for boss Amnennar The Coldbringer. Fixed up gong event for gong to have sound and proper spawning. Scripted quest 3525 "Extinguishing the Idol" so you can now fight Plagmaw the Rotting.
fa2616f Add mailbox command
2b8fb0d DB/SAI: Fix for QUEST 12512 "Leave no one behind" by Pitcrawler Closes #6583
067f0f9 DB/SAI: Add SAI for Val'kyr Guardian & Val'kyr Protector Closes #3280
e667c96 Scripting/Grizzly Hills: Add missing include "SpellScript.h"
af5d3da Core/Vehicle: Add an extra check for required energy before setting power.
621ba87 Grizzly Hills/Scripting: Fix Quest 12244 "Shredder Repair" and 12270 "Shred the Alliance" Closes #1942 #3754
dc1d1a6 Scripts/HoR: Some fixups.
c546dcb DB/SAI: Spawn Baron Aquanis when Fathom Stone is used Closes #3118
6e69db2 DB/SAI: Little fix for Quest Re-Cursive to make Mechagnomes despawn after spell hit. Closes# 2024
a04000e DB/SAI: Fix SAI script for Denalan. Closes #6758
dd16bfb Scripts/Oculus: fix drake spellsCloses #6681
Closes #6680
Closes #6673
c2984e3 Core/RBAC: Fix typo
a3c8deb DB/SAI: Fix SAI for Terrorspark Closes #9999
8669633 Core/Commands: Fix NULL dereference crash in .npc set linkFix NULL dereference crash in .npc set link happening when passing a not-existent Creature guid as parameter, es. ".npc set link -1" .
Issue spotted by static analysis, added in c05ed659cbc561b6e7c0016cc7b1548886d5337a
fb1daeb Core/SpellMgr: Remove unneeded check for max targets
5da508c Scripting/Blade's Edge: Quest 10594 "Gauging the Resonant Frequency" Closes #6214
c084b3d Core/SmartAI: Remove unneeded code added in error
4f61574 DB/SAI: Replace a couple bad scripts...not mine :)
e60fe4c Core/SmartAI: Fixed waypoint pathing not resuming after evade.
81c73c2 Scripting/Sholazar Basin: Fix warning
b407e72 Core/SmartScript: Allow flag to be added to spell to determine combat movement. Greatly simplifies SAI combat scripting.
48d8af0 Core/SmartAI: Fix SMART_ACTION_ALLOW_COMBAT_MOVEMENT
7806b7c Core/Chat: Fix ChatFlood.MessageCount not being handled correctlyFix Anti-flood chat system to always allow 1 more message than the count specified in the ChatFlood.MessageCount config parameter.
5bbded1 Core/Misc: Fix some static analysis issuesFix some static analysis issues about missing NULL checks.
Pass safe Creature pointer instead of summoning a Creature, passing the GUID and retrieve the same Creature from GUID.
0a9e58c DB/SAI: Remove flee from Ymirjar Flesh Hunter & Ymirjar Necromancer
8920994 Scipts/HallsOfReflection: Fix reset during mob waves.closes #10995
2a9bf96 DB/SAI: SAI error fix.
d852f86 DB/SAI: Fixed a few typo errors from EAI to SAI conversion.
a868ee1 DB/SAI: Fix an SAI error
3485656 Core/Player: GetRewSpellCast & GetRewSpell should not be cast by questgiver if effect type SPELL_EFFECT_LEARN_SPELL
d76e094 DB/Misc - Some missing gossip options and conditions.
422fd5f Scripting/Sholazar Basin: Fix spell_shango_tracks script.
6a6b310 Scripting/Sholazar Basin: Move spells for quest Dreadsaber Mastery: Stalking the Prey (12550) to cpp.
04cc51a Core/Misc: Fix some static analysis issuesFix some static analysis issues, mostly false positive about fields not initialized in the constructor. It's good practice anyway to always initialize them.
3db9d5e DB/SAI: Fix SAI for Felweaver Scornn
5a3b6ed Update 2013_12_01_00_auth_rbac_permissions.sql
78b5d5d Update 2013_12_01_02_world_command.sql
d5be9b9 DB/SAI: Remove some Smartscripts for npcs already scripted in cpp
1bb4cf3 Core/Misc: Removed more unused eventAI stuff
b375106 Scripts: prevent some runtime errors
9015fee DB/SAI: Move cpp script for npc_arete to SAI.
59e4be6 Core/RBAC: Added missing changes in 6e13263c7a0ae4c8eecdf4fd9560339e2d3d9787
6e13263 Core/AI: Good bye, Good bye my beloved EventAI system :(
274a789 DB/SAI: The last EAI script is now converted to SAI.
85f868a DB/SAI: Fix errors in last commit.
69ae2fa DB/SAI: EAI to SAI conversions.
62799c3 DB/SAI: More EAI to SAI updates.
3452cde DB/SAI: More EAI to SAI
07c98d6 DB/SAI: more EAI to SAI updates.
84c0fec DB/SAI: More EAI to SAI conversions.
ff20596 Core/World: Remove unused codeRemove unused code added in f20b25d1c90f608deab28c9957b3b376ab2a0d50
24db2a5 Core/RBAC: Fix rare NULL dereferenceFix a rare NULL dereference happening if 'rbac_default_permissions' table has secId "255" as first row.
6aaa7d9 Merge branch 'master' of github.com:TrinityCore/TrinityCore
3b471f4 Core/Transports: Log an error if a Transport has no GameObject templateLog an error if a Transport has no GameObject template from `gameobject_template` table instead of dereferencing NULL .
b27f2f7 Merge pull request #11272 from gerripeach/pull_request6Core/BG: Isle of Conquest - fix worldstates
4416c16 Core/Scripts: Fix possible NULL dereferencesFix possible NULL dereferences probably caused by a typo.
0bac181 DB/SAI: EAI to SAI to kill flee in a few npcs.
7631280 DB/SAI: fix a couple SAI errors found by Aokromes.
861afd7 DB/SAI: More EAI to SAI conversions
343f841 DB/SAI: Fix error from EAI.
c620c30 DB/SAI: More EAI to SAI conversions
38bc2a4 Scripting/hinterlands: Fixed a script error involving creature_text
aef2d39 Core/BG: Isle of Conquest - fix worldstates-sometimes not all worldstates were shown correctly
7b172ff Db/SAI: Fix some errors found by Aokromes.
6a7067f Scripts: fix some issues found by static code analysis (also fix 2 startup errors)
788c869 Core/Transports: Remove unused fieldRemove unused Transport::_moveTimer field, static analysis complains about it being uninitialized.
89c5496 Scripting/Dragon Blight: A little cleanup to last commit.
90334fe Scripting/Torturer LeCraft: Move SAI script for Torturer LeCraft to cpp to make it work properly.
62b3cb5 DB/SAI: More EAI to SAI updates. 199 left :)
c071f42 DB/SAI: More EAI to SAI updates.
dacbb6d DB/SAI: More EAI to SAI updates.
0ad6524 DB/SAI: More EAI to SAI updates.
84dfe3c DB/Spawns: add npcs on turtle "Green Island" and "Walker of Waves"
a01c25d DB/SAI: Fix error in previous commit.
ff1d9ee DB/SAI: Fix db startup error
b3470c8 DB/SAI: More EAI to SAI updates.
72383bd DB/SAI: More EAI to SAI updates.
b66e0e8 DB/SAI: Fix last commit.
1f73fe8 DB/SAI: More EAI to SAI conversions
c4eaba5 DB/areatrigger_tavern: Update sql in last commit to make it reinsertable.
bf2d17d DB/areatrigger_tavern: Add missing trigger for Grom'arsh Crash-Site. By Aokromes
1196b93 Core: fix build
e353bc4 Scripts/UtgardePinnacle: cleanup InstanceScript
00d5c59 Scripts/Arcatraz: cleanup InstanceScript to make it work with BossAI
b069ade DB/Loot: Fix pilgrims bounty loot for cooking book
b100769 Core/Guilds: Fixed gold in bank not being updated clientside after withdrawing/depositing into a bank that has no tabs purchasedCloses #5787
172d319 Core/Guilds: Fixed an issue with withdrawing money from guild bank as guild master if the guild was created using a gm commandCloses #11262
3b8d38d Scripts/Oculus: fix boss_varos::InitializeAI()
7cd2154 Core: Fix build
99456a9 DB/SAI: The Amphitheatre of Anguish SAI editionBy @dr-j fixes #11198
3e1f734 Merge pull request #11260 from dr-j/patch-1Removing unneeded scripts from zone_zuldrak.cpp (Core scripts for Amphit...
9a0bb93 Scripts: fix warning and cleanup npc_apprentice_mirveda
96daa55 Removing unneeded scripts from zone_zuldrak.cpp (Core scripts for Amphitheatre of anguish chainremoving cpp scripts scripts, please check this as dont know much about c but have just removed everything relating to amphitheatre npcs, or lines 168 - 1143 and 1869,1870,1871,1872,1873,1876 or the complete scripts for all involved npcs and the individual lines from void AddSC_zuldrak
2c307aa Scripts/Oculus: cleanup a bit
d4d4eb3 Misc/Misc: A mix useless random changes
f3ade33 Scripting/Storm Peaks: Add spell script for spell_jokkum_scriptcast. Quest 13010 Krolmir, Hammer of Storms is not yet fully scripted but is now completeable.
dcfbe1d Instance/Halls of Reflection/Lich King event: Typo fix on 86e0c7dThx MitchesD
0874870 DB/Misc: Quest 13010 Krolmir, Hammer of Storms in progress.
efdfde3 Core/QuestPOI: Replace Unk2 with FloorId
15ae105 DB/SAI: Fix Quest 13145 "The Vile Hold" Closes #7799
6ba4d70 Core/Player: Allow questgiver, if npc, to cast quest RewSpellCast & RewSpell rather than player.
d7c0fe9 Scriting/Eversong Woods: Minor fix.
efb7b17 Scripting/Eversong_Woods: Add quest end scripting for quest 8487. Also fixes for quest 8488 but not completely fixed.
ed77d68 Merge pull request #11250 from xjose93/HoRInstance/Halls of Reflection/Lich King event: Implement loot chest in heroic mode and rename chest variables.
86e0c7d Instance/Halls of Reflection/Lich King event: Implement loot chest in heroic mode and rename chest variables.
82d4ed5 Core/Movement: fix player fall under ground on teleport
0a2a552 Core/Transports: addition to f0c4d0ac05eee967ebe9322e0f362b7f5d1088a4 Core/Players: fix logic in Player::SendInitWorldStates()
b5181d3 Scripts/PoS: fix Tyrannus Overlord Brand thx @zwerg
d2065b0 Core/Transports: Fix triggered assertion in TransportsRelocate only Players in world when updating transport's and its passengers' positions.
Thanks vlad852 .
Closes #11209 .
2cad987 Core/Misc: Fix a compile warning.Properly fix #11229 since eacf961e7299afc0627e146d204d94baa1a09d80 changes didn't affect the original issue.
eacf961 Core/Misc: Fix a compile warning.Closes #11229
2b59ef8 Merge branch 'master' of github.com:TrinityCore/TrinityCore
f0c4d0a Core/Transports: Fix few transport issues on relog.Properly save transport related data to database when saving a Player .
On Player login update the current position as relative to transport, in case the transport moved.
4272c37 Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
ca2520e DB/SAI: Repush some SAI because phasing was wrong from convertor.
1bec946 Rename 2013_10_01_00_misc.sql to 2013_10_01_00_world_misc.sql
055af93 DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
096cb6b Core/Auth: Fix Auth failing sometimesFix a database race condition between authserver saving session key to database asynchronously and worldserver reading it; session key is now saved synchronously.
f2c0ef6 DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
0d0527c DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
eb4e479 DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
b7c1bed DB?SAI: Fix a few warnings where killmonster was used by EAI instead of proper spell for quest credit.
54735d6 Db/SAI: Fix errors in commit.
7d33e6b DB/SAI: Fix error in last commit
3b96495 DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
5aa6e2e Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
8411942 DB/SAI: Fix error in commit.
9fd7066 SQL: Fix import error
1ac9ea3 DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
243bbc3 DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
5380f6f DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
3ea8eb6 DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
e70b15e DB/SAI: Fix warning in last commit.
706a6f5 DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
b90bf9e DB/SAI: Fix to remove an SAI error.
01afc7b DB SAI/EAI: Fix some errors introduced from the EAI to SAI conversions.
c68d53c DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
a95aca6 DB/SAI: Fix comments in last commit again. Damn you Discover.
521cf9a DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
9d1df5c DB/SAI: Fix Comments in last commit.
1706eec DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
cbc9870 SQL: Fix import errors
df6e258 DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
ffae6af DB/SAI: More EventAI to SmartAI conversions using this tool: https://github.com/TrinityCore/EventAI-to-SmartAI
8178b4e DB/SAI: Some EAI to SAI conversions.
bf8b4c8 DB/SAI: Some EAI to SAI conversions.
792c1e5 DB/creature_ai_text: Fix some errors.
98c8f8b DB/EAI: Some updates from acid to add to EAI before final convertion.
dd20290 Scripts/ZulAman: fix exploit that player can fly until logout
0790138 Core. fix build and some codestyle changes
f01fe07 Merge pull request #11175 from MitchesD/sunwellScripts/SunwellPlateau: reworked InstanceScript and applied codestyle
5b7b03f Scripts/SunwellPlateau: reworked InstanceScript and applied codestyle
df5a012 Rename 2013_11_10_07_world_conditions,sql to 2013_11_10_07_world_conditions.sql
c03f066 Core/Build: Fix build when WITH_COREDEBUG CMake flag is selected
cd48662 Core/Logging: Minor changes - Select stderr when writing ERROR and FATAL messages - Simplify function defines - Fix `logs` table structure with latest logging changes
79a2d6b Core/Spells: Fixed Revive Pet to revive the pet near the ownerCloses #11196
65cd07a Core: Improve error messages for linked_respawn table (and minor cosmetic changes here and there)
395eb83 DB/Conditions: Add condition for Shoot Arcane Explosion Arrow
f4a4e1c DB/misc: Some fix ups for Arcatraz
c53f12b DB/creature_addon: Fix some issues with weapons not showing for npc's in Slave Pens.
0edeba5 DB/Waypoints: Update a couple paths in Slave Pens to proper sniffed values.
df99a41 DB/SAI: SAI for Prince Valanar
1137356 Scripts/The Slave Pens: Fix up Mennu the Betrayer and add Rokmar the Cracker & Quagmirran.
e0138ab Fixed build
1966a78 Core/Movement: Backported spline stop fix from 4.3.4 branch - use Stop spline type for stopping movement instead of starting movement that ends in creature's current position
8332cee Scripting/The Slave Pens: Moved boss_mennu_the_betrayer from EAI to CPP.
c2db6d4 Scripting/The Arcatraz: Add text scripting for deaths
2d28d0c Core/ScriptedAI: Fix Headers.
e5b259f Scripting/Arcatraz: Move Zereketh the Unbound, Dalliah the Doomsayer, & Wrath-Scryer Soccothrates to cpp scripting and some cleanup.
114cae2 DB/Misc: Convert Lord Thorval from EAI and creature_ai_texts to SAI and creature_text.
94e2b93 Core/Logging: Remove LOG_FILTER_XXX defines with it's value (remember logger names are case-sensitive)
16a51e3 Update LoggingHOWTO with latest changes
1b04bec Core/Logs: Create default set of loggers and Appender if the config is wrong. - Logger root (Error) - Logger server (Info) - Appender ConsoleLogger names are case-sensitive, Appender names are not.
98a7a22 DB/Misc: Remove some unneeded creature_ai_texts and EAI.
8370f70 DB/Creature_text: Creature text for Mennu the Betrayer Creature needs scripting moved from EAI to cpp.
494ea73 DB/creature_text: Creature text for Dalliah the Doomsayer & Wrath-Scryer Soccothrates Need someone to script these two bosses in cpp to remove them from EAI.
78786d3 DB/Creature_text: Creature text for Wrath-Scryer Soccothrates
88c46a6 Core/CreatureGroups: Calculation change requested by Shauren.
8aa9745 Core/Logging: Extend logging system to allow inheritance of loggers - Changed default loggers and appenders - '.' determines the relation between loggers ("type.subtype" inherits "type" logger setting if logger "type.subtype" is not defined) - When core logs a message it search for the correct logger (root is the default one) ie: a message logged with "type.subtype" * Core will try to find a logger with name "type.subtype", if its not found then will search for "type", again if its not found it will return the default one "root"
d26bb85 DB: Fix start up warnings
be19ac9 Core/SmartAI: Better wording for telling "There is a spell for summoning this"
d00cb48 RBAC: Move initial log output in AccountMgr::LoadRBAC to debug
7a2a9a8 DB/Creature_formations: Update a few formations to not crossover at pathing endpoints.
b4a0533 Core/CreatureGroups: Add fields to creature_formations and code to prevent creature crossover in formations. Wiki update and db values too follow.
a4b62d8 DB/Misc: Typo fix for Defiling Uther's Tombby dr-j, closes #11180
7e904b1 Core/Threads: Include Helgrind suppressions fileInclude a Helgrind suppressions file under source control. Each suppressed race is either a false positive, a read race followed by a lock acquire anyway, a bool race. Suppressions related to the same issue in the same function are grouped with a counter in brackets [ ] .
Fix tabs added in bcee801e4bdbf7d53f15cd0499e9d3aaedd3c3e2 .
a34883b DB/Misc: Defiling Uther's Tombby dr-j, closes #2410
c4d9e58 DB/Misc: Wooly Justice additionBy @untaught
b857567 DB/Misc: Get Stefan Vadu to reset quests for Drakuru's task when Sabotage, So Far So Bad, Hazardous Materials and Infilltrating Voltarus are takenby dr-j, closes #11170
f771ff1 DB/Misc: Get Thorim to clear quests You Can't Miss Him and Battling the Elements on Quest accept of forging an allianceby dr-j, closes #11169
f8a5b63 DB/Misc: An Improper BurialBy dr-j, closes #11173
e6c3a16 DB/Creatures: Corrected the npc flags for difficulty 1 of some NPCs in IoC & added their respective "click spells".
58e9aff DB/Misc: Fix some startup errors
40d8f60 Rename 2013_11_04_00_world_creature_template.sql to sql/updates/world/2013_11_04_00_world_creature_template.sql
2b812e7 Rename 2013_11_03_23_world_misc.sql to 2013_11_03_24_world_misc.sql
07dd469 Rename 2013_11_02_00_world_sai.sql to 2013_11_03_00_world_sai.sql
a0aff55 DB/Misc: Zeth'Gor Must Burn!by untaught, closes #11167
78c6123 DB/Creatures: Corrected wrong speed values for Eye Stalk & Malmortis.
bcee801 Core/Network: Fix race condition in WorldSession timeoutHelgrind log:
Lock at 0x2BD582E0 was first observed
at : pthread_mutex_init (hg_intercepts.c:443)
by : ACE_OS::mutex_init(pthread_mutex_t*, int, char const*, pthread_mutexattr_t*, int, int) (in /usr/lib/libACE-6.0.3.so)
by : ACE_Thread_Mutex::ACE_Thread_Mutex(char const*, pthread_mutexattr_t*) (in /usr/lib/libACE-6.0.3.so)
by : WorldSocket::WorldSocket() (WorldSocket.cpp:106)
by : ACE_Acceptor<WorldSocket, ACE_SOCK_Acceptor>::make_svc_handler(WorldSocket*&) (Acceptor.cpp:261)
by : ACE_Acceptor<WorldSocket, ACE_SOCK_Acceptor>::handle_input(int) (Acceptor.cpp:396)
by : ACE_Dev_Poll_Reactor::dispatch_io_event(ACE_Dev_Poll_Reactor::Token_Guard&) (in /usr/lib/libACE-6.0.3.so)
by : ACE_Dev_Poll_Reactor::handle_events(ACE_Time_Value*) (in /usr/lib/libACE-6.0.3.so)
by : ACE_Reactor::run_reactor_event_loop(ACE_Time_Value&, int (*)(ACE_Reactor*)) (in /usr/lib/libACE-6.0.3.so)
by : ReactorRunnable::svc() (WorldSocketMgr.cpp:170)
by : ACE_Task_Base::svc_run(void*) (in /usr/lib/libACE-6.0.3.so)
by : ACE_Thread_Adapter::invoke_i() (in /usr/lib/libACE-6.0.3.so)
Possible data race during write of size 8 at 0x2BD6F6F8 by thread #12
Locks held: 1, at address 0x2BD582E0
at : WorldSession::ResetTimeOutTime() (WorldSession.h:372)
by : WorldSocket::ProcessIncoming(WorldPacket*) (WorldSocket.cpp:709)
by : WorldSocket::handle_input_payload() (WorldSocket.cpp:517)
by : WorldSocket::handle_input_missing_data() (WorldSocket.cpp:610)
by : WorldSocket::handle_input(int) (WorldSocket.cpp:282)
by : ACE_Dev_Poll_Reactor::dispatch_io_event(ACE_Dev_Poll_Reactor::Token_Guard&) (in /usr/lib/libACE-6.0.3.so)
by : ACE_Dev_Poll_Reactor::handle_events(ACE_Time_Value*) (in /usr/lib/libACE-6.0.3.so)
by : ACE_Reactor::run_reactor_event_loop(ACE_Time_Value&, int (*)(ACE_Reactor*)) (in /usr/lib/libACE-6.0.3.so)
by : ReactorRunnable::svc() (WorldSocketMgr.cpp:170)
by : ACE_Task_Base::svc_run(void*) (in /usr/lib/libACE-6.0.3.so)
by : ACE_Thread_Adapter::invoke_i() (in /usr/lib/libACE-6.0.3.so)
by : ACE_Thread_Adapter::invoke() (in /usr/lib/libACE-6.0.3.so)
This conflicts with a previous write of size 8 by thread #7
Locks held: none
at : WorldSession::UpdateTimeOutTime(unsigned int) (WorldSession.h:368)
by : WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:256)
by : World::UpdateSessions(unsigned int) (World.cpp:2646)
by : World::Update(unsigned int) (World.cpp:2003)
by : WorldRunnable::run() (WorldRunnable.cpp:60)
by : ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186)
by : ACE_OS_Thread_Adapter::invoke() (in /usr/lib/libACE-6.0.3.so)
by : mythread_wrapper (hg_intercepts.c:233)
bc6920a DB/Misc: Missing Scoutby dr-j, closes #10380
7082dc4 DB/Misc: Wooly Justiceoriginal work by Trista, updated by ZxBiohazardZx, final work by FireEmerald, closes #6587
a207729 DB/Spawn: Lordaeron Citizenby Hobbilis, closes #7914
6613001 DB/Misc: Argent Squire / Argent Gruntling itemsby BlackangelWow, updates #4710
4ccbfe8 DB/Misc: Update to Vordrassil's Heart Credit
ba9b8da DB/Misc: Astor Hadrenby dr-j, closes #10512
0089751 DB/Misc: The Broken Frontby dr-j, closes #7585
6a19060 DB/Misc: Blazerunner's Script from EAI to SAIby dr-j, closes #10547
5f60614 DB/Misc: Burn Skorn ,Burn / Towers of Certain Doomby dr-j, closes #10907
56cce65 DB/Misc: Lupus Pupusby dr-j, closes #10436
ce55c8b DB/Misc: Words for Delivery description/completion textby Crysicle, minor fix by xjose93, closes #10609
7c7ed52 DB/Misc: A hero's Burden + Oracles / Frenzyheart Rep Swappingby dr-j, minor update by untaught, closes #8710 closes #6534
27fe7d1 Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
1d2a070 Merge pull request #11165 from untaught/masterFix quest ... Or Maybe We Don't (12138) and remove the core script
b98cc11 Core/Misc: Fix compile after 316da388d586eee5625d9b0a01d21b3befb2cc69
45e0af0 Fix quest ... Or Maybe We Don't (12138) and remove the core script
741eed4 DB/Misc: March of the Giantsby Justiciar, closes #10246
7b28dba Merge pull request #11164 from untaught/masterFix quest Redeeming the Dead (9685) and remove the core script
316da38 Fix quest Redeeming the Dead (9685) and remove the core script
c1056b5 Merge pull request #11163 from untaught/master[Area Trigger Scripts]Support for Teleport for Quest: Breaking Through and Last Rites
b28c27c [Area Trigger Scripts] Add Support for Teleport for Quest: Breaking Through (11898)
940e671 DB/Misc: Kaganishuby untaught, closes #10704
dc8cf9f DB/Misc: Fix some startup errorsNote: if those mobs starts moving now needs to be properly fixed, no hacked with speed 0.
172007b DB/Misc: Fix some startup errors
e766f75 DB/SAI: Winterskorn creaturesby trista, closes #5906
b569d05 DB/Misc: Thistleshrub Rootshaperby untaught, updates #10944
7cba781 DB/SAI: Little Morsels cannot feed mobsby dr-j, closes #10892
e6e16f3 DB/Misc: Fix Bros. Before Ho Ho Ho'sby nelegalno, closes #4332
ab396c4 DB/Quest: Fix quest ender for To Fordragon Hold!by dr-j, closes #5121
9065b16 DB/Misc: Make Caladis Brightspear visible when having proper questby Foldor, updates #11015
2760d19 DB/Disables: Tempering The Blade queldalar LoSby dr-j, closes #8920
d84bdcc DB/Misc: Lunar Festival Invitation - Teleport Moongladeby zaphod77, updates #4945
2dd80b8 DB/Misc: Heart of the Phoenix Cooldown must ignore LoSBy mweinelt, updates #10198
8726c4d DB/Gameobject: Battle plans of the KvaldirBy Justiciar, closes #10291
1d31b5f DB/SAI: Book of the AncientsBy dr-j, closes #10146
51dd1eb DB/Misc: Argent tournament quests without progressBy Crysicle, closes #7988
6843734 DB/SAI: There's Something Going On In Those CavesBy dr-j, closes #10786
73533f6 DB/SAI: Boiling PointBy untaught, closes #10761
6eac86a DB/Quest: A Dark InfluenceBy wintergreen77, fixes #6777
0cd02ca DB/Misc: Kyle the friendlyBy dr-j, closes #10564
2125c57 DB/Misc: Required classes for all versions of The Purification of Quel'DelarBy dr-j, closes #10594
6f9a548 DB/SAI: Still At ItBy dr-j, closes #8008
13df07e DB/Creature: Scalesworn Elite inhabittypeBy untaught, closes #10831
d42fe0c DB/SAI: Fix more credit fixesBy Pitcrawler, closes #10022
27a4e48 DB/Conditions: Skill requirements to ride flying carpets and flying machinesBy dr-j, closes #10572
d9a1609 DB/Gameobject: Ulduar Flame Leviatan secondary force fieldBy PanDaemonAeon, closes #4793
1efb60c DB/Misc: Remove spells with effects SPELL_EFFECT_SUMMONBy xjose93, closes #7653 closes #10212
10d20fd DB/Creature: IoC template updatesBy milotic, closes #8591
3c0228f DB/Gameobject: Dip in the MoonwellBy untaught, closes #7523
3368854 DB/SAI: Fix more credit fixesBy dr-j, closes #10872
8ed82d0 DB/SAI: Surveying the RuinsBy Polkic, closes #11162
6d794ab Core/Database: Add additional assertAdd additional assert to assure that helgrind reports related to SQLQueryHolderTask::Execute() and WorldSession::ProcessQueryCallbacks() are false positives.
The only chance for WorldSession::ProcessQueryCallbacks() to access the SQL queries before they are completed is if m_result.ready() is true before the end of SQLQueryHolderTask::Execute() .
Helgrind false positive log:
Possible data race during read of size 8 at 0x2BD641E0 by thread #7
Locks held: none
at : SQLQueryHolder::GetPreparedResult(unsigned long) (QueryHolder.cpp:107)
by : Player::LoadFromDB(unsigned int, SQLQueryHolder*) (Player.cpp:16917)
by : WorldSession::HandlePlayerLogin(LoginQueryHolder*) (CharacterHandler.cpp:807)
by : WorldSession::ProcessQueryCallbacks() (WorldSession.cpp:1112)
by : WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:401)
by : World::UpdateSessions(unsigned int) (World.cpp:2646)
by : World::Update(unsigned int) (World.cpp:2003)
by : WorldRunnable::run() (WorldRunnable.cpp:60)
by : ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186)
by : ACE_OS_Thread_Adapter::invoke() (in /usr/lib/libACE-6.0.3.so)
by : mythread_wrapper (hg_intercepts.c:233)
by : start_thread (pthread_create.c:311)
This conflicts with a previous write of size 8 by thread #4
Locks held: none
at : SQLQueryHolder::SetPreparedResult(unsigned long, PreparedResultSet*) (QueryHolder.cpp:140)
by : SQLQueryHolderTask::Execute() (QueryHolder.cpp:196)
by : SQLOperation::call() (SQLOperation.h:65)
by : DatabaseWorker::svc() (DatabaseWorker.cpp:45)
by : ACE_Task_Base::svc_run(void*) (in /usr/lib/libACE-6.0.3.so)
by : ACE_Thread_Adapter::invoke_i() (in /usr/lib/libACE-6.0.3.so)
by : ACE_Thread_Adapter::invoke() (in /usr/lib/libACE-6.0.3.so)
by : mythread_wrapper (hg_intercepts.c:233)
Address 0x2BD641E0 is 16 bytes inside a block of size 792 alloc'd
at : operator new(unsigned long) (vg_replace_malloc.c:319)
by : __gnu_cxx::new_allocator<std::pair<SQLElementData, SQLResultSetUnion> >::allocate(unsigned long, void const*) (new_allocator.h:104)
by : std::_Vector_base<std::pair<SQLElementData, SQLResultSetUnion>, std::allocator<std::pair<SQLElementData, SQLResultSetUnion> > >::_M_allocate(unsigned long) (in /home/jackpoz/trinity/bin/worldserver)
by : std::vector<std::pair<SQLElementData, SQLResultSetUnion>, std::allocator<std::pair<SQLElementData, SQLResultSetUnion> > >::_M_fill_insert(__gnu_cxx::__normal_iterator<std::pair<SQLElementData, SQLResultSetUnion>*, std::vector<std::pair<SQLElementData, SQLResultSetUnion>, std::allocator<std::pair<SQLElementData, SQLResultSetUnion> > > >, unsigned long, std::pair<SQLElementData, SQLResultSetUnion> const&) (vector.tcc:483)
by : std::vector<std::pair<SQLElementData, SQLResultSetUnion>, std::allocator<std::pair<SQLElementData, SQLResultSetUnion> > >::insert(__gnu_cxx::__normal_iterator<std::pair<SQLElementData, SQLResultSetUnion>*, std::vector<std::pair<SQLElementData, SQLResultSetUnion>, std::allocator<std::pair<SQLElementData, SQLResultSetUnion> > > >, unsigned long, std::pair<SQLElementData, SQLResultSetUnion> const&) (stl_vector.h:1024)
by : std::vector<std::pair<SQLElementData, SQLResultSetUnion>, std::allocator<std::pair<SQLElementData, SQLResultSetUnion> > >::resize(unsigned long, std::pair<SQLElementData, SQLResultSetUnion>) (stl_vector.h:707)
by : SQLQueryHolder::SetSize(unsigned long) (QueryHolder.cpp:167)
by : LoginQueryHolder::Initialize() (CharacterHandler.cpp:66)
by : WorldSession::HandlePlayerLoginOpcode(WorldPacket&) (CharacterHandler.cpp:788)
by : WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:363)
by : World::UpdateSessions(unsigned int) (World.cpp:2646)
by : World::Update(unsigned int) (World.cpp:2003)
ca34b70 Core/Transports: Fixed a few mistakes in GO passenger teleports (currently unused), thanks joschiwald for spotting them
62c6ae7 Tools: Skip extracting already existing DBC filesThanks to MacWarrior, closes #11061
0ee3093 Fixed typo in 39175ac68071a22233cb6828bfd8f2cd099861d7
39175ac Core/Transports* Fixed fall damage on transports while teleporting
* Fixed packets not being received by owner if sent by a controlled minion
* Fixed an issue when a teleporting transport would attempt to reload its creature passengers on old map
Closes #11140
8d15c4c DB/Misc: Correct some game event dataBy Foldor, closes #10960
15efc1e DB/Loot: Voidwalker Minions are not meant to drop lootBy dr-j and Exodius closes #11012
a61872a DB/Misc: NeltharakuBy untaught, closes #11031
5b404ec DB/SAI: Slaves of the StormforgedBy untaught, closes #10509
8576360 DB/SAI: Sprouted FrondBy untaught, closes #11123
4355d55 DB/Misc: Quest item "Drain Schematics" dropBy trickerer, fixes #10394
c041090 DB/Misc: Fixes 2 innkeepers of Hallow's End eventBy dr-j and untaught, closes #11108
f95769e DB/Misc: Make invisible some visible TriggersBy untaught, closes #10648
3d5a317 DB/SAI: Dragonmaw Sky StalkerBy @MitchesD fixes #11148
f002b05 Core/Vehicles: Add missing NULL check in cf72f7cc5cf13607dd7353b8d940d56679b6956bAdd an additional NULL check for me->GetVehicleKit() , otherwise the crash fixed in cf72f7cc5cf13607dd7353b8d940d56679b6956b becomes a NULL dereference crash.
f81316a Merge pull request #11147 from LeGuybrush/masterCore/Code: Unify [more] codestyle for brackets: )\n{\n} to ) { }.
0a30814 Core/Code: Unify [more] codestyle for brackets: )\n{\n} to ) { }.
5cfd180 Merge pull request #11138 from Ascathor/masterCore/Code: Unify codestyle for brackets: {} to { }.
7a7ad4a Core/Code: Adding copyright to all the mesh_extractor files.
2607738 Core/Code: Unify codestyle for brackets: {} to { }.Also added missing copyright to some files.
cf72f7c Core/Vehicles: Fixed a crash caused by accessing freed memoryValgrind log:
==1357== Invalid read of size 8
==1357== at 0x108339C: std::_Rb_tree<signed char, std::pair<signed char const, VehicleSeat>, std::_Select1st<std::pair<signed char const, VehicleSeat> >, std::less<signed char>, std::allocator<std::pair<signed char const, VehicleSeat> > >::begin() (stl_tree.h:685)
==1357== by 0x1082B23: std::map<signed char, VehicleSeat, std::less<signed char>, std::allocator<std::pair<signed char const, VehicleSeat> > >::begin() (stl_map.h:321)
==1357== by 0x1567152: VehicleAI::CheckConditions(unsigned int) (CombatAI.cpp:330)
==1357== by 0x1566EE5: VehicleAI::UpdateAI(unsigned int) (CombatAI.cpp:285)
==1357== by 0x11A8FB3: Creature::Update(unsigned int) (Creature.cpp:543)
==1357== by 0x11BC1A2: TempSummon::Update(unsigned int) (TemporarySummon.cpp:47)
==1357== by 0x12E8194: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45)
==1357== by 0x12F31BD: void VisitorHelper<Trinity::ObjectUpdater, Creature>(Trinity::ObjectUpdater&, ContainerMapList<Creature>&) (TypeContainerVisitor.h:64)
==1357== by 0x12F2CCB: void VisitorHelper<Trinity::ObjectUpdater, Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > >(Trinity::ObjectUpdater&, ContainerMapList<TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > >&) (TypeContainerVisitor.h:70)
==1357== by 0x12F251F: void VisitorHelper<Trinity::ObjectUpdater, GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > >(Trinity::ObjectUpdater&, ContainerMapList<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >&) (TypeContainerVisitor.h:71)
==1357== by 0x12F1BA5: void VisitorHelper<Trinity::ObjectUpdater, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >(Trinity::ObjectUpdater&, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >&) (TypeContainerVisitor.h:94)
==1357== by 0x12F0DDD: TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >::Visit(TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >&) (TypeContainerVisitor.h:105)
==1357== by 0x12EF5A0: void Grid<Player, TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > >, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >::Visit<Trinity::ObjectUpdater>(TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >&) (Grid.h:91)
==1357== by 0x12ED766: void NGrid<8u, Player, TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > >, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >::VisitGrid<Trinity::ObjectUpdater, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >(unsigned int, unsigned int, TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >&) (NGrid.h:157)
==1357== by 0x12EA2D3: void Map::Visit<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >(Cell const&, TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >&) (Map.h:701)
==1357== by 0x12DCD84: Map::VisitNearbyCellsOf(WorldObject*, TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >&, TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > > > >&) (Map.cpp:604)
==1357== by 0x12DD045: Map::Update(unsigned int) (Map.cpp:646)
==1357== by 0x1520E03: MapUpdateRequest::call() (MapUpdater.cpp:54)
==1357== by 0x1596958: DelayExecutor::svc() (DelayExecutor.cpp:52)
==1357== by 0x5184E56: ACE_Task_Base::svc_run(void*) (in /usr/lib/libACE-6.0.3.so)
==1357== Address 0x2a849600 is 32 bytes inside a block of size 168 free'd
==1357== at 0x4C2BADC: operator delete(void*) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==1357== by 0x107F309: Vehicle::~Vehicle() (Vehicle.cpp:66)
==1357== by 0x10BE0D2: Unit::RemoveVehicleKit() (Unit.cpp:15949)
==1357== by 0x10B52CA: Unit::RemoveFromWorld() (Unit.cpp:13440)
==1357== by 0x11A7D73: Creature::RemoveFromWorld() (Creature.cpp:204)
==1357== by 0x11BCBAA: TempSummon::RemoveFromWorld() (TemporarySummon.cpp:279)
==1357== by 0x11BCD5E: Minion::RemoveFromWorld() (TemporarySummon.cpp:308)
==1357== by 0x10B5514: Unit::CleanupBeforeRemoveFromMap(bool) (Unit.cpp:13481)
==1357== by 0x10B5605: Unit::CleanupsBeforeDelete(bool) (Unit.cpp:13503)
==1357== by 0x12E3B67: Map::AddObjectToRemoveList(WorldObject*) (Map.cpp:2401)
==1357== by 0x10FCAAC: WorldObject::AddObjectToRemoveList() (Object.cpp:2138)
==1357== by 0x11BCABA: TempSummon::UnSummon(unsigned int) (TemporarySummon.cpp:256)
==1357== by 0x11BCAFA: ForcedUnsummonDelayEvent::Execute(unsigned long, unsigned int) (TemporarySummon.cpp:261)
==1357== by 0x159B665: EventProcessor::Update(unsigned int) (EventProcessor.cpp:47)
==1357== by 0x10858E2: Unit::Update(unsigned int) (Unit.cpp:318)
==1357== by 0x11A8E6C: Creature::Update(unsigned int) (Creature.cpp:519)
==1357== by 0x11BC1A2: TempSummon::Update(unsigned int) (TemporarySummon.cpp:47)
==1357== by 0x12E8194: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45)
==1357== by 0x12F31BD: void VisitorHelper<Trinity::ObjectUpdater, Creature>(Trinity::ObjectUpdater&, ContainerMapList<Creature>&) (TypeContainerVisitor.h:64)
==1357== by 0x12F2CCB: void VisitorHelper<Trinity::ObjectUpdater, Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > >(Trinity::ObjectUpdater&, ContainerMapList<TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > >&) (TypeContainerVisitor
2957007 Merge pull request #11137 from Ascathor/masterCore/Command: Fix ban info order for .pinfo
e5553cf Core/Command: Fix ban info order for .pinfo
fa33c42 DB/Cond: Prevent multiple spawns in vicinityBy @dr-j fixes #11128
f0794d7 Core/Transports: Correct path generation for a few transports
b81bf7d Core/Spells: Implemented additional conditions for spells that start cooldown after an event instead of after cast
daf5a4b Core/Chat Commands: Allow to add overlapping teles .Allow to add overlapping teles like "abc" even if "abcde" already exists. This wasn't possible and a "Teleport already exists" error was thrown instead.
a14bbf7 Merge pull request #11120 from AliveShiro/battlefield_cosmeticGame/Battlefield: Cosemtic changes
cc89ac0 Game/Battlefield: - Remove double definition of one NPC - Use definition instead a "magic number"
5e62edd Db/Update: Rockjaw Backbreaker script spamBy @untaught fixes #11112
f93ac80 Core/Transports: Fixed double deleting IoC transports
b926039 DB/SAI: Cleansing the ScarBy @untaught fixes #11117
8949636 DB/SAI: Swift DisciplineBy @untaught fixes #11118
626f1f0 DB/Errors: Db error clean upBy @untaught fixes #11116
950ac94 DB/SAI: Fix scripts using SMART_TARGET_NONE that were 'broken' by 9653576cb4cc9449898d6af691c045d68e9361c5. 'Broken' is quoted because scripts using SMART_TARGET_NONE are most of the time broken by default anyway.
f6f102c DB/SAI: Add Gymer text and faction friendly to horde also.
63cfb71 DB/SAI: This just in: Fire still hot!By @untaught fixes #10752
cdcee93 Core/IoC: Fix uninitialized timerFix uninitialized Docks timer in Isle Of Conquest .
Valgrind log:
Conditional jump or move depends on uninitialised value(s)
at : BattlegroundIC::HandleCapturedNodes(ICNodePoint*, bool) (BattlegroundIC.cpp:665)
by : BattlegroundIC::PostUpdateImpl(unsigned int) (BattlegroundIC.cpp:228)
by : Battleground::Update(unsigned int) (Battleground.cpp:300)
by : BattlegroundMgr::Update(unsigned int) (BattlegroundMgr.cpp:93)
by : World::Update(unsigned int) (World.cpp:2062)
635e146 Rename SQL file (thx Aokromes)
e8e148b Rename sql file and apply some code style. *sigh*
5c0cf98 Core/Spell: Shaman Bloodlust/Heroism ignore LOScloses: #6307
9802c7b Scripts/Misc: Coding Style unification? (by Aokromes)
0f92d51 Merge pull request #11092 from gerripeach/pull_requestCore: add missing comment
d745e32 Core: add missing comment
06f5011 Core/Auras: Added serverside checking for UNIT_FLAG_PACIFIED when attempting to start melee attackCloses #8623
3e12fe8 Core/Transports: Fixed players taking fall damage when teleporting from transportsCloses #11076
0cc32e2 Core/SAI: Rename SMART_EVENT_TARGET_CASTING to SMART_EVENT_VICTIM_CASTING as that's what it actually does. It was often confused to use the target_type field instead of the victim.
fc947e2 Core/Quest: Remove assertionRemove assertion about Quest ExclusiveGroup since they are triggered even when adding valid quests to npcs. Fixes #8336 .
How to reproduce steps:
- .gm off
- add quest 11335 in creature_queststarter
- .reload creature_queststarter
- get in range of that creature
- .gm on
- assertion triggered
989cc35 DB/SAI: Misc Fixes from ITBy @dr-j and @untaught
Fixes #11081 fixes #11080 fixes #11082
4123468 Merge pull request #11050 from Ascathor/masterCore/Command: Improve .group list to feature several notes and features ...
1a61579 Core/Misc: Get rid of some useless code
2853e57 Merge pull request #11077 from Elron103/pullrequests2DB/Gossip: Update some data for trainer NPCs from sniffs
4684256 DB/Gossip: Update some data for trainer NPCs from sniffs
b6db622 Core/Transports: Fixed crashes happening when passenger is removed from transport during teleportCloses #11067
f8b1b26 Core/Spells: Fixed diminishing returns on creatures with CREATURE_FLAG_EXTRA_ALL_DIMINISHCloses #11073
dd9ea28 Merge pull request #11072 from gerripeach/diminishing_returns2Core/Spell: Earthbind totem should not have DR (Diminishing Returns)
cb89a42 Core/Spell: Earthbind totem should not have DR (Diminishing Returns)closes: #7037
c1712c0 DB/Misc: Ormorok the Tree Shaper Spell ReflectCloses #10789
443d4a6 Merge pull request #11071 from gerripeach/group_crashCore/Group: Fix crash in "Group::GetMembersCount"
93dbf20 Core/Group: Fix crash in "Group::GetMembersCount"closes: #9350
6534df8 Merge pull request #11070 from gerripeach/petsCore/Pet: Allow all pets to swim
7223adb Core/Pet: Allow all pets to swimcloses: #9331
faa23e1 Merge pull request #11069 from Elron103/pullrequests2DB/Conditions: Fix conditions for class trainer npcs, so gossip menus will show up correctly for every class
23fa9ec DB/Conditions: Fix conditions for class trainer npcs, so gossip menus will show up correctly for every class
b845e6a Merge pull request #10989 from Elron103/pullrequests2Core/Tickets: Fix crash in TicketMgr::ResetTickets()
8ff52bf DB/Gameobjects: Added few missing gameobjects templates from 5.4.0 sniffs.
5915a22 Misc: Removed some whitespace
59caeb8 DB/Gossip: Added some missing gossips (Source: 5.4.0 sniffs)
5259539 Core/Transports: Fixed crashes when instance with transports unloadsCloses #11056
e21eef5 Core/Transports: Added missing include
38b682d Core/Maps: Added gameobject case for AddObjectToSwitchList and fixed logic in RemoveAllObjectsInRemoveList
77013aa Core: Fix warnings
47741f4 Core/Object: Added more information for MovePosition log
94161a8 Core/Creature: Added log/change back to default speed for speed walk / run = 0 (Speed is never zero)
ddada2d Scripted/ScarletMonastery: Fix crash for headless horseman
b1bef5b Updated all values of `gender` column in `creature_model_info`.
4aee866 Core/WorldSession: Mitigate DoS attacksMitigate DoS attacks like one explained in #10555 by processing a limited number of packets at each WorldSession::Update() call, allowing other WorldSessions to be processed.
100 packets in a single update sound like a reasonable amount.
193f4ed Core/Command: Improve .group list to feature several notes and features to improve handling.
a0b3863 SQL: Update auth base
565dd42 Build fix
59fd2520f@Core/Creatures: Removed remains of creature_transport table
c91a25f Because Github commiting sucks.
e6440ab Corrected the graveyards for Onyxia's Lair instance.
5744317 DB/SAI: Primordial Drake Egg/HatchlingFixes #11051 by @dr-j and @untaught
0f4fdb9 Fixed sql files for ce55647c415b710c6b440d96c2f26ebbc06c1d6e
e0cb49a Build fix
7f0f87d Build fix
81ec99c Build fix
ce55647 Core/Transports* Rewritten path generation, now uses splines - timers are a lot more accurate now
* Implemented stopping transports
* Implemented spawning transports in instances
* Implemented spawning gameobjects as transport passengers
* Transport passengers are now stored in creature/gameobject table using gameobject_template.data6 from transport's template as map id
53cc37b CMake: Fix typoRunning cmake threw a warning because of this.
3633f62 Merge pull request #11045 from Baeumchen/patch-1Just, because this typo was annoying...
b1c706a Just, because this typo was annoying...
186e085 Fix non-pch build.
53167ea Fix build.
54272e4 Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
82eda32 Core/Misc: Ugh.. Fix recent commit that broke the OnHeal hook :disappointed_relieved:
0bdeb12 Scripts/Ahnkahet: Prince Taldaram rewritten to BossAICloses #10993
ce17fb9 Db/Disable: Sibling Rivalry creditBy @untaught fixes #11020
6f98e41 Scripts/TheBlackMorass: Fix first 7 rifts spawn timingsPartially revert 7e76ab97f895da1320106fad28e31d6b34c15443 to properly spawn first 7 rifts. Also allow only 1 EVENT_NEXT_PORTAL event at time.
db848f2 Core/Misc: Fix build after 731b3670febaf72d89776a05164f7663f45821ee (again..)
9f50cae DB/SAI: Updates for I've got a flying machine
f0b376a Merge pull request #11028 from Lillecarl/blackbabiesMake damage and healing references, so that damage can be altered by scr...
731b367 Make damage and healing references, so that damage can be altered by scripts!Correct typo (thanks AwkwardDev)
ca02411 Core/SAI: When the castflags are set to both SMARTCAST_AURA_NOT_PRESENT and SMARTCAST_INTERRUPT_PREVIOUS, we only interrupt the spell if there is actually a spell cast.
6d08d06 Create 2013_10_11_00_world_sai.sql
114bafe DB/Update: Chat floodBy @bele fixes #11025
6d562b1 Fix typo (thx to vlad852)
4588294 Fix some db errors ... (Yippie-Ya-Yeah)
8a94744 DB/Update: Quest credit fix-up
95cad03 Scripts/HoR: fixed infinite spawn, added some missing spell target conditions and fixed codestyleCloses #10754
6cef507 Scripts/HallsOfReflection: Revert 3ffbd27cddbd96d9736e7b22a286cef8f4ab2174Revert 3ffbd27cddbd96d9736e7b22a286cef8f4ab2174 and PR #10985 , this change doesn't fix any issue and instead breaks the logic of the instance event.
c8f525c DB/SAI: The Great Hunter's ChallengeBy @Polkic fixes #11003
24136b0 DB/Quest: Once More Unto The Breach, Hero progressionBy @dr-j fixes #10940
f2ba8ed DB/SAI: The Final CodeBy @dr-j fixes #3640
1d3e3fa Build fix
9d19e4d Core/Commands: Restored old functionality of getSelectedPlayer in chat commandsAlso fixed build
21a64d8 Merge pull request #10976 from avengerweb/masterCore/Spells: Spells with SPELL_ATTR3_IGNORE_HIT_RESULT can never miss!
b658c17 Core/Spells: Fixed summoning players after recent changes
7f42a68 DB/SAI: Blighted last ritesBy @dr-j fixes #9172
ba1a4cd Merge branch 'authserver_fix_dos' of github.com:jackpoz/TrinityCore
0365752 Core/Auth: Mitigate DoS attacks to authserverMitigate DoS attacks to authserver like "Wow Auth Flooder.exe" by allowing a finite number of AUTH_LOGON_CHALLEGE packets in a row from same socket, 3 sounds like a reasonable limit.
d897b55 Core/Build: Handle USE_SCRIPTPCH cmake flag when SCRIPTS flag is set to FALSEDon't ignore USE_SCRIPTPCH cmake flag if SCRIPTS is set to FALSE; in this case "script" project has only source files related to scripted spells and command scripts and it must be built with precompiled headers if USE_SCRIPTPCH flag is set. This partially reverts 780ed1b01c77ac142e1da5851ff7deb832413b11 .
f8fb6d6 DB/Misc: Ormus the Penitent vendorBy @Foldor fixes #10885
4d654a8 Core/Misc: Fix compile after recent pull request...
36e6407 Merge pull request #10981 from Lillecarl/hookzImplement OnDamage and OnHeal hooks
a368fae Core/Players: Fixed issues with incorrect targets being selected for spells
2b7f29f Core/Tickets: Fix crash in TicketMgr::ResetTickets()
dd4404e Merge pull request #10985 from Baeumchen/patch-1Update wrong Escape value
3ffbd27 Update wrong Escape stateFound by w5860363 : http://www.trinitycore.org/f/topic/9112-halls-of-reflectioncpp-question%EF%BC%9F/
993513c Core/Vehicles: Fixed a crash happening when a minion vehicle despawns with passenger on itRef #9738
8fb1f7c Tools/MeshExtractor: Implemented 7ca6f56a065a666fc605d2fa402a2eea14bc40c0 in MeshExtractor and fixed a memory leak.
a8611de Tools/MeshExtractor: Fixed a few mistakes in MPQManager::GetFileFrom and Utils::SaveToDisk
770f69d Core/Vehicles: Fixed calling Vehicle::Uninstall on freed memoryValgrind log:
==7723== Invalid read of size 8
==7723== at 0x10753CE: Vehicle::GetBase() const (Vehicle.h:51)
==7723== by 0x1072449: Vehicle::Uninstall() (Vehicle.cpp:159)
==7723== by 0x10B1E3C: Unit::RemoveVehicleKit() (Unit.cpp:15946)
==7723== by 0x10A8F32: Unit::RemoveFromWorld() (Unit.cpp:13441)
==7723== by 0x11A4703: Creature::RemoveFromWorld() (Creature.cpp:203)
==7723== by 0x11B9AB7: TempSummon::RemoveFromWorld() (TemporarySummon.cpp:279)
==7723== by 0x11B9C6C: Minion::RemoveFromWorld() (TemporarySummon.cpp:308)
==7723== by 0x10A917C: Unit::CleanupBeforeRemoveFromMap(bool) (Unit.cpp:13482)
==7723== by 0x10A926C: Unit::CleanupsBeforeDelete(bool) (Unit.cpp:13504)
==7723== by 0x12DBB89: Map::AddObjectToRemoveList(WorldObject*) (Map.cpp:2108)
==7723== by 0x10F4556: WorldObject::AddObjectToRemoveList() (Object.cpp:2140)
==7723== by 0x11B99C5: TempSummon::UnSummon(unsigned int) (TemporarySummon.cpp:256)
==7723== Address 0x3bd20530 is 64 bytes inside a block of size 168 free'd
==7723== at 0x4C2B59C: operator delete(void*) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==7723== by 0x1071FD3: Vehicle::~Vehicle() (Vehicle.cpp:66)
==7723== by 0x10B1E71: Unit::RemoveVehicleKit() (Unit.cpp:15947)
==7723== by 0x10A8F32: Unit::RemoveFromWorld() (Unit.cpp:13441)
==7723== by 0x11A4703: Creature::RemoveFromWorld() (Creature.cpp:203)
==7723== by 0x11B9AB7: TempSummon::RemoveFromWorld() (TemporarySummon.cpp:279)
==7723== by 0x11B9C6C: Minion::RemoveFromWorld() (TemporarySummon.cpp:308)
==7723== by 0x10A917C: Unit::CleanupBeforeRemoveFromMap(bool) (Unit.cpp:13482)
==7723== by 0x10A926C: Unit::CleanupsBeforeDelete(bool) (Unit.cpp:13504)
==7723== by 0x12DBB89: Map::AddObjectToRemoveList(WorldObject*) (Map.cpp:2108)
==7723== by 0x10F4556: WorldObject::AddObjectToRemoveList() (Object.cpp:2140)
==7723== by 0x11B99C5: TempSummon::UnSummon(unsigned int) (TemporarySummon.cpp:256)
8aa92ea Are we there, yeti?By @dr-j fixes #10972
1588e27 Tools/MeshExtractor: Fixed the generated mesh for continents. Fixed a few more issues.
8737984 Implement script hooks: OnDamge, OnHeal
586df8d Merge pull request #10978 from NightQuest/string_concatenationC++11 string literal concatenation
c803cc1 Merge branch 'master' of github.com:TrinityCore/TrinityCore into string_concatenation
1fae858 Whitespace between string literals and user-defined literals is now mandatory for concatenation in C++11
11d9a44 Core/SAI: Properly implement the second parameter of SMART_ACTION_CALL_TIMED_ACTIONLIST to reflect the wiki (which also makes more sense)
c5c3b7a Tools/MeshExtractor: Implemented the code to generate mesh files for continent maps. Fixed a few more things ToDo: Test the generated navmesh.
3ed0a11 Tools/MeshExtractor: Do not delete the polygons before we are done using them.
1e23710 Tools/MeshExtractor: Forgot to push some changes.
520ff5a Tools/MeshExtractor: Some more cleanup.
271a57b Tools/MeshExtractor: Fixed mmap extracting for instance maps and fixed a number of issues. ToDo: Cleanup the code a bit. WILL NOT CURRENTLY WORK WITH TrinityCore, if you want to test it, use the --extract 32 flag of MeshExtractor.
1010e14 DB/Update: Return To...RP event updateBy @Foldor fixes #10886
0c0ff98 Core/RBAC: Fix errors in RBAC sql related to ea2fe0217d
2320f6d Core/Spells: Spells with SPELL_ATTR3_IGNORE_HIT_RESULT can`t never miss!
5c95431 DB/SAI: Correction on waypoints for quest npc.Closes #10937
6e95846 DB/Loot: correct petdrops from the fishingbags and cleanup the misused referenceCloses #10975
7a234c8 DB/Loot: Fix Satchel of Helpful GoodsCloses #10552
Closes #10292
80ce30a Core/SAI: Add 'playerOnly' parameters to SMART_TARGET_CLOSEST_ENEMY and SMART_TARGET_CLOSEST_FRIENDLY. Wiki is updated accordingly.
15e7f7a Tools/MeshExtractor: Implemented mmap mesh generation for instances (They do not have ADT files, they're just a big WMO). Cleaned up some things and fixed some errors. ToDo: * Test this a bit more. * Cleanup the codebase for this, remove duplicated code.
9876108 Tools/MeshExtractor: Removed some redundant code
02a543b Tools/MeshExtractor: Some more cleanup and memory management improvements.
371dd07 Tools/MeshExtractor: Fixed Doodads and WMOs in the terrain. Cleaned up a little.
2791837 Tools/MeshExtractor: Fixed(??????) Doodads in the terrain. Semi-fixed WMOs in the terrain, they are wrongly rotated. P.D: HALP P.P.D: Entered "I don't know what i'm doing" mode.
79ad89a DB/SAI: Destroying the AltersBy @untaught fixes #10841
dbd994b DB/SAI: Hampering their EscapeBy @untaught fixes #10780
9bd7cc8 DB/Update: Plan BBy @untaught fixes #10787
ff8bc02 DB/Update: Gibblewilt fear spamBy @Vincent-Michael fixes #10627
9842cbf DB/SAI: Finding the SourceBy @dr-j fixes #10943
728b255 DB/SAI: Neltharion's Flame (12267)By @dr-j fixes #10965
c67d527 DB/SAI: Leading the Ancestors HomeBy @dr-j fixes #10783
ad29676 Fix compile under linux and update auth db with latest changes
ea2fe02 Core/RBAC: Simplify RBAC implementation - Drop groups (roles than can have inherited roles) and roles (set of permissions) - Permissions can now have inherited permissions (those act as roles)RBAC DB structure is now limited to four tables
- rbac_permissions: Contains permissions and roles
- rbac_linked_permissions: Contains the relation between permissions and
linked permissions (those permissions that have linked permissions are
called roles)
- rbac_default_permissions: Contains the list of permissions to be granted
to each security level [Added to maintain compatibility in an easy way]
- rbac_account_permissions: Contains the list of permissions granted or
denied for a particular account.
NOTE: IF YOU ARE USING CUSTOM PERMISSIONS, ROLES OR GROUPS CHECK THE SQL
BEFORE APPLYING...
a1fa7bf Tools/VMAP Extractor: Fix memory issuesFix not-NULL terminated char buffer and uninitialized memory written to vmaps due to WMOLiquidHeader struct padding bytes left uninitialized. The padding bytes should be ignored anyway by VMAP Assembler so no re-extraction is required.
Valgrind log:
Syscall param write(buf) points to uninitialised byte(s)
at 0x585FB50: __write_nocancel (syscall-template.S:81)
by 0x57EE2F2: _IO_file_write@@GLIBC_2.2.5 (fileops.c:1270)
by 0x57EE1D1: new_do_write (fileops.c:546)
by 0x57EF904: _IO_do_write@@GLIBC_2.2.5 (fileops.c:519)
by 0x57EEB70: _IO_file_xsputn@@GLIBC_2.2.5 (fileops.c:1341)
by 0x57E3EC4: fwrite (iofwrite.c:43)
by 0x41161B: WMOGroup::ConvertToVMAPGroupWmo(_IO_FILE*, WMORoot*, bool) (wmo.cpp:386)
by 0x407FA9: ExtractSingleWmo(std::string&) (vmapexport.cpp:215)
by 0x407B16: ExtractWmo() (vmapexport.cpp:138)
by 0x409D50: main (vmapexport.cpp:497)
Address 0x40398e2 is not stack'd, malloc'd or (recently) free'd
Uninitialised value was created by a heap allocation
at 0x4C2C7A7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x410ADA: WMOGroup::open() (wmo.cpp:224)
by 0x407F54: ExtractSingleWmo(std::string&) (vmapexport.cpp:208)
by 0x407B16: ExtractWmo() (vmapexport.cpp:138)
by 0x409D50: main (vmapexport.cpp:497)
a68c29e Tools/MeshExtractor: Fixed a lot of stuff, finally made the Doodads render, the WMO's have been disabled for now. ToDo: * Fix the doodads positions. * Review and re-implement some code.P.D: Help me please.
7ca6f56 Tools/MapExtractor: Fix string-related memory issuesFix not-NULL terminated char buffers and char[] to string conversion.
Valgrind logs:
Invalid read of size 1
at 0x4C2D7D4: __GI_strlen (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x5318BAF: std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.17)
by 0x409471: ReadBuild(int) (System.cpp:189)
by 0x40CEC6: main (System.cpp:1108)
Address 0x5f851ee is 0 bytes after a block of size 94 alloc'd
at 0x4C2C037: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x40F63A: MPQFile::MPQFile(char const*) (mpq_libmpq.cpp:65)
by 0x409408: ReadBuild(int) (System.cpp:182)
by 0x40CEC6: main (System.cpp:1108)
Invalid read of size 1
at 0x57FFCAC: strtok (strtok.S:165)
by 0x40D279: MPQArchive::GetFileListTo(std::vector<std::string, std::allocator<std::string> >&) (mpq_libmpq04.h:45)
by 0x40C5CF: ExtractDBCFiles(int, bool) (System.cpp:1001)
by 0x40CEF5: main (System.cpp:1110)
Address 0x5f91e27 is 0 bytes after a block of size 44,391 alloc'd
at 0x4C2C037: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0x40D1A5: MPQArchive::GetFileListTo(std::vector<std::string, std::allocator<std::string> >&) (mpq_libmpq04.h:30)
by 0x40C5CF: ExtractDBCFiles(int, bool) (System.cpp:1001)
by 0x40CEF5: main (System.cpp:1110)
ac5b6f3 Core/Scripts: Fix uninitialized values in The Black MorassValgrind log:
Conditional jump or move depends on uninitialised value(s)
at 0x1798C2C: npc_medivh_bm::npc_medivh_bmAI::UpdateAI(unsigned int) (the_black_morass.cpp:192)
by 0x11AEFC0: Creature::Update(unsigned int) (Creature.cpp:542)
by 0x12E96F8: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45)
Conditional jump or move depends on uninitialised value(s)
at 0x1798C7E: npc_medivh_bm::npc_medivh_bmAI::UpdateAI(unsigned int) (the_black_morass.cpp:200)
by 0x11AEFC0: Creature::Update(unsigned int) (Creature.cpp:542)
by 0x12E96F8: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45)
Conditional jump or move depends on uninitialised value(s)
at 0x1798CB0: npc_medivh_bm::npc_medivh_bmAI::UpdateAI(unsigned int) (the_black_morass.cpp:205)
by 0x11AEFC0: Creature::Update(unsigned int) (Creature.cpp:542)
by 0x12E96F8: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45)
Conditional jump or move depends on uninitialised value(s)
at 0x1798CE2: npc_medivh_bm::npc_medivh_bmAI::UpdateAI(unsigned int) (the_black_morass.cpp:210)
by 0x11AEFC0: Creature::Update(unsigned int) (Creature.cpp:542)
by 0x12E96F8: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45)
2b97ffa Merge pull request #10966 from Chaplain/MeshTools/MeshExtractor: Cleanup using static analyzing tool
6711ba0 DB/Update: Pet spells
18bf68a DB/Update: Spawndist for creature with random movement
42ae39b Tools/MeshExtractor: Cleanup using static analyzing tool *printf format fixed *method arguments changed to const where needed *removed not needed strlen() from cycles *other minor changes
cde2e4d Merge pull request #10963 from Tomatodev/masterTools/MeshExtractor: Fixed an infinite loop when reading the liquid information
58348d0 Subv's changes to mesh extractor V2Signed-off-by: Tomatoes <diredarknil@gmail.com>
85d6b7b Tools/MeshExtractor: Added some debug messages.
b7b870b Tools/MeshExtractor: Removed the fool-proof code.
64f1324 Fix silly " that snuck in.
33fcd36 Buildsystem/CMake: Add support for building meshextractor-project from CMake GUI
da60e51 Tools/MeshExtractor: Fixed it's build, still in pre-alpha
895a23d Core/RBAC: Add default groups to accounts based on their security level. - Removed config option RBAC.DefaultGroupsUse the table rbac_security_level_groups to configure the groups to be added to the account at load time.
Note: Those groups are only used at run time, never saved to DB
cfaea76 Core/RBAC: Move RBAC code to namespace rbac
89085f7 DB/Core: The Storm King's Vengeance
2cca398 Core/Movement: Port Ascent r1637 http://sourceforge.net/p/ascentemubackup/code/1637/ to TrinityCorePort some movement packet fixes, taking into account client/server connection lag.
Credits to original author, check http://sourceforge.net/p/ascentemubackup/code/1637/ for more details.
MOVEMENT_PACKET_TIME_DELAY default value is currently set to 0, feel free to set it to different values and report feedback.
06c3813 DB/SAI: Wanton WarlordFixes #5126 by @dr-j
6ea5dfd DB/Update: Quest credit fix-upVehicles will not accept quest credit in the form of a spell cast, credit needs to be a monster kill.
a0c637f Core/Scripts: added some OVERRIDEs
1887fa2 Merge pull request #10933 from MitchesD/SteamVaultScripts/SteamVault: reworked InstanceScript
a5c248b Core/SAI: Get rid of unused parameter 'storageId' (third) in SMART_ACTION_SUMMON_CREATURE. This means the 4th parameter (actionInvoker 0/1) must move back one parameter. On a clean TDB there is not a single case of this parameter being used.Updated wiki accordingly.
c256a03 Merge branch 'master' of github.com:TrinityCore/TrinityCore
ec3832c Core/AI: Fix uninitialized values and array overflows in SAIProper initialize POD struct members to 0 in SMART_ACTION_CREATE_TIMED_EVENT action type.
Fix array overflows and access uninitialized values in SMART_ACTION_CALL_RANDOM_TIMED_ACTIONLIST, SMART_ACTION_RANDOM_PHASE and SMART_ACTION_RANDOM_EMOTE .
Valgrind log for SMART_ACTION_RANDOM_PHASE case:
Conditional jump or move depends on uninitialised value(s)
at : SmartScript::UpdateTimer(SmartScriptHolder&, unsigned int) (SmartScript.cpp:3086)
by : SmartScript::OnUpdate(unsigned int) (SmartScript.cpp:3176)
by : SmartAI::UpdateAI(unsigned int) (SmartAI.cpp:335)
by : Creature::Update(unsigned int) (Creature.cpp:542)
by : TempSummon::Update(unsigned int) (TemporarySummon.cpp:47)
Uninitialised value was created by a stack allocation
at : SmartScript::ProcessAction(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:143)
d6a6f44 DB/SAI: Non-repeatable flags change & credit circumventionBy dr-j fixes #10929 fixes #6444
20d0701 Core/Logs: Random changes
ae221b0 Scripts/SteamVault: reworked InstanceScript
a0db072 Merge branch 'master' of https://github.com/TrinityCore/TrinityCore
9653576 Core/SAI: Using SMART_TARGET_NONE no longer works the same way as SMART_TARGET_ACTION_INVOKER but rather return NULL instead.Fixes #10908
4498ac0 DB/SAI: Zeth'Gor Must Burn!Fixes #10904 by @untaught
3aa9446 Merge pull request #10875 from zorix/PR2Core/Script:
8b2c40e Core/Script: ICC: Convert possible non valid pointer to guidClose #9954
56b3e52 DB/SAI: Eyes of GrillokBy @dr-j fixes #10909
9579d0a Scripts/ScarletEnclave: Fix uninitialized values in Highlord Darion MograineReset() has if checks on values that are initialized after them so it's required to initialize these fields in the constructor.
Valgrind log:
Conditional jump or move depends on uninitialised value(s)
by 0x11CF472: HashMapHolder<Creature>::Find(unsigned long) (ObjectAccessor.h:67)
by 0x11CE36F: Creature* ObjectAccessor::GetObjectInWorld<Creature>(unsigned long, Creature*) (ObjectAccessor.h:114)
by 0x1257C13: Creature* ObjectAccessor::GetObjectInMap<Creature>(unsigned long, Map*, Creature*) (ObjectAccessor.h:135)
by 0x12E64F1: Map::GetCreature(unsigned long) (Map.cpp:2767)
by 0x10AF4DE: Unit::GetCreature(WorldObject&, unsigned long) (Unit.cpp:13021)
by 0x16F8F81: npc_highlord_darion_mograine::npc_highlord_darion_mograineAI::Reset() (chapter5.cpp:386)
by 0x16F8D36: npc_highlord_darion_mograine::npc_highlord_darion_mograineAI::npc_highlord_darion_mograineAI(Creature*) (chapter5.cpp:314)
by 0x16F8CD6: npc_highlord_darion_mograine::GetAI(Creature*) const (chapter5.cpp:307)
by 0x132AF6C: ScriptMgr::GetCreatureAI(Creature*) (ScriptMgr.cpp:796)
by 0x1441D45: FactorySelector::selectAI(Creature*) (CreatureAISelector.cpp:41)
af63c87 Core/Guild: Fix withdraw money from bank overflowing int32 limitClamp amount of money withdrawn from bank to MAX_MONEY_AMOUNT to avoid int32 overflow which would remove money from Player instead of adding it.
9c336cc Core/DB: Make a26a24a consistent with Trinity code styleChange DatabaseWorkerPool<T>::DirectExecute() to handle PreparedStatement disposal in the same way of DatabaseWorkerPool<T>::Query() , thanks Joschiwald for patch.
a26a24a Core/AccountMgr: Fix memory leak on account creationFix .account create command not deleting a MySql PreparedStatement .
Valgrind log:
254 (40 direct, 214 indirect) bytes in 1 blocks are definitely lost in loss record 6 of 8
at 0x4C24DFA: operator new(unsigned long) (vg_replace_malloc.c:261)
by 0x998EC2: DatabaseWorkerPool<LoginDatabaseConnection>::GetPreparedStatement(unsigned int) (DatabaseWorkerPool.h:437)
by 0x99599B: AccountMgr::CreateAccount(std::string, std::string, std::string) (AccountMgr.cpp:49)
by 0xF3ABAC: account_commandscript::HandleAccountCreateCommand(ChatHandler*, char const*)
69b0a00 Core/SAI: Make SMART_ACTION_RANDOM_MOVE also work with SMART_TARGET_NONE and non-creature targets (if a non-creature target_type is specified and no creature target was found, the action is fired at the source)Ref. #7431
6f9851e Core/PathGenerator: Fix conditional jump on uninitialized valueFix conditional jump on uninitialized value in PathGenerator::GetNavTerrain() by checking the result of getLiquidStatus() before accessing the LiquidData, uninitialized in case there's no water at all.
Valgrind log:
Conditional jump or move depends on uninitialised value(s)
at : PathGenerator::GetNavTerrain(float, float, float) (PathGenerator.cpp:553)
by : PathGenerator::UpdateFilter() (PathGenerator.cpp:542)
by : PathGenerator::CreateFilter() (PathGenerator.cpp:530)
by : PathGenerator::PathGenerator(Unit const*) (PathGenerator.cpp:46)
by : Spell::Spell(Unit*, SpellInfo const*, TriggerCastFlags, unsigned long, bool) (Spell.cpp:493)
by : Unit::CastSpell(SpellCastTargets const&, SpellInfo const*, CustomSpellValues const*, TriggerCastFlags, Item*, AuraEffect const*, unsigned long) (Unit.cpp:846)
by : Unit::CastSpell(Unit*, SpellInfo const*, TriggerCastFlags, Item*, AuraEffect const*, unsigned long) (Unit.cpp:882)
by : Unit::CastSpell(Unit*, unsigned int, TriggerCastFlags, Item*, AuraEffect const*, unsigned long) (Unit.cpp:870)
by : Unit::CastSpell(Unit*, unsigned int, bool, Item*, AuraEffect const*, unsigned long) (Unit.cpp:858)
by : Player::SendInitialPacketsAfterAddToMap() (Player.cpp:22580)
by : WorldSession::HandleMoveWorldportAckOpcode() (MovementHandler.cpp:121)
by : WorldSession::HandleMoveWorldportAckOpcode(WorldPacket&) (MovementHandler.cpp:37)
1ae6538 Merge pull request #10827 from jackpoz/restore_warningsShared/Build: Restore disabled warnings on Visual Studio
4ddad6e DB/SAI: The Battle of Valhalas Quest ChainFixes #8377
Consists of:
1) Battle at Valhalas: Fallen Heroes (13214)
2) Battle at Valhalas: Khit'rix the Dark Master (13215)
3) Battle at Valhalas: The Return of Sigrid Iceborn (13216)
4) Battle at Valhalas: Carnage! (13217)
5) Battle at Valhalas: Thane Deathblow (13218)
6) Battle at Valhalas: Final Challenge (13219)
2b9b2a7 DB/GameObject: Added gameobject "Dark Iron Mole Machine (Minion Summoner Trap)"
001f62d DB/Errors: Leftoever fixesWork done by @untaught fixes #10747
1ede593 Just because....
7be7eb2 DB/Errors: Misc db error fixesDb errors fixed by @untaught PrevQuest fixes by @dr-j and @Crysicle
Fixes #10370 Fixes #5064 Partially takes care of #10747 - more to come.
eab10cc Core/Achievement: Fix warning
8af46f1 Core: Fix non pch build
05e72b4 Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_KILL_CREATURE_TYPE
c9c12b9 Merge pull request #10864 from zorix/aurasCore/Auras: Fix removing auras when player reset talents or changing/leaving shapeshift
Close #10763
Close #10809
cac1968 Core/Auras: Fix removing auras when player reset talents or changing/leaving shapeshiftClose #10763
Close #10809
aa6736c DB/SAI: Missing addition
173a247 DB/SAI: Misc FixesAuthors @untaught @dr-j @MitchesD
Fixes #10847 Fixes #10844 Fixes #10830 Fixes #10829 Fixes #10830
d80d36b DB/Error: Delete empty guid addon
0c7e275 DB/SAI: The Murketh and Shaadraz Gateways.
1427302 DB/SAI: So Far, So Bad
ef09e8b DB/SAI: Fate of the Titans
0a6db17 Shared/Build: Restore disabled warnings on Visual StudioRestore 2 disabled warnings, 1 already disabled in CMake with the WITH_WARNINGS flag set to False and the other disabled by default as stated in VS documentation http://msdn.microsoft.com/en-us/library/aa984150.aspx
0177d1c Merge pull request #10822 from jackpoz/collisions_nullterm_stringTools/VMAP: Fix not null terminated string
478ec28 Merge pull request #10823 from jackpoz/icewall_overflowScripts/HoR: Fix possible array overflow
99f5a6c Core/BGs: Fix a TC_LOG_ERROR call
6477f8c Scripts/HoR: Fix possible array overflowFix possible array overflow reported by coverity, issue id 1062436 .
a513497 Tools/VMAP: Fix not null terminated stringFix not null terminated string in vmap assembler tool, fix coverity issue id 1010351 .
b72fd4c Merge pull request #10819 from Ascathor/masterCore/Misc: Fixed some more issues found by static code analysis tools.
4782cc4 Core/Misc: Fixed some more issues found by static code analysis tools.
aaff97d Merge pull request #10821 from jackpoz/blood_tap_overflowCore/Spell: Fix Blood Tap array overflow
d0b42ee Core/Spell: Fix Blood Tap array overflowFix Blood Tap spellid 45529 accessing the 7th element of a size 6 array.
Coverity issue id 1023095.
9c7de29 DB/GO: Spell Focus for Trial of the LakeCloses #10807
042df13 DB/Update: Warm Up - credit updateFixes #10804
f0cd684 Merge pull request #10800 from jackpoz/log_race_conditionCore/Logs: Fix race condition in Log
2e15f78 Merge pull request #10801 from jackpoz/account_password_crashfixCore/Commands: Fix NULL dereference crash in .account password
6581d7d Core/Commands: Fix NULL dereference crash in .account passwordFix NULL dereference crash in .account password added in bd8d0cfbce9a38e0f2fc8b6903434c3553faf143
Fixes #10791
1b3575b Core/Logs: Fix race condition in LogFix race condition in Log by using atomic operators.
Helgrind log:
Possible data race during read of size 8 at 0x7379D98 by thread #1
Locks held: none
at 0x15AE9C7: AppenderFile::_write(LogMessage const&) (AppenderFile.cpp:59)
by 0x15ADFF8: Appender::write(LogMessage&) (Appender.cpp:106)
by 0x159F14E: Logger::write(LogMessage&) (Logger.cpp:83)
by 0x15A215B: Log::write(LogMessage*) (Log.cpp:290)
by 0x15A200F: Log::vlog(LogFilterType, LogLevel, char const*, __va_list_tag*) (Log.cpp:272)
by 0x15A2682: Log::outInfo(LogFilterType, char const*, ...) (Log.cpp:364)
by 0xF7DA28: Master::Run() (Master.cpp:296)
by 0xF835E8: main (Main.cpp:142)
This conflicts with a previous write of size 8 by thread #10
Locks held: none
at 0x15AE9D7: AppenderFile::_write(LogMessage const&) (AppenderFile.cpp:59)
by 0x15ADFF8: Appender::write(LogMessage&) (Appender.cpp:106)
by 0x159F14E: Logger::write(LogMessage&) (Logger.cpp:83)
by 0x15A215B: Log::write(LogMessage*) (Log.cpp:290)
by 0x15A200F: Log::vlog(LogFilterType, LogLevel, char const*, __va_list_tag*) (Log.cpp:272)
by 0x15A2682: Log::outInfo(LogFilterType, char const*, ...) (Log.cpp:364)
by 0xF7EC1F: FreezeDetectorRunnable::run() (Master.cpp:98)
by 0x15A5B3E: ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186)
Address 0x7379D98 is 88 bytes inside a block of size 96 alloc'd
at 0x4C2C857: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
by 0x15A0FE3: Log::CreateAppenderFromConfig(char const*) (Log.cpp:150)
by 0x15A1AED: Log::ReadAppendersFromConfig() (Log.cpp:244)
by 0x15A31B4: Log::LoadFromConfig() (Log.cpp:469)
by 0x15A053B: Log::Log() (Log.cpp:35)
by 0xF75CD1: ACE_Singleton<Log, ACE_Thread_Mutex>::ACE_Singleton() (Singleton.inl:13)
by 0xF754A4: ACE_Singleton<Log, ACE_Thread_Mutex>::instance() (Singleton.cpp:91)
by 0xF8351A: main (Main.cpp:135)
cb4bf1f Scripts/Ruby Sanctum: (Possibly) fixed Twilight Mending.I don't have the computer to even compile a core, please report back. My logics shouldn't be wrong here from what I can read on the wiki.
Ref #10016.
bd8d0cf Fix build
4df862d Merge pull request #10792 from Ascathor/masterCore/Command: Fixing .account password to no longer crash
8c596b9 Core/Command: Fixing .account password to no longer crashAnd add some comments to it.
783e28e Core/Groups: Allow to configure the way in which instance reset message is sent, to the whole party (not blizzlike) or not.Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
ca4d53a DB/SAI: War is HellFixes #3915, By Vincent_Michael
38f5c91 Core: Fix non PCH build
0e21292 DB/SAI: Strengthen the Ancients additionFixes #10778
e4ed64a Merge pull request #10782 from Ascathor/masterCore/Commands: Fixing some problems with .account email
3861ba5 Core/Commands: Fixing some problems with .account email
72d1508 Merge pull request #10776 from xjose93/ArenaTeamLogsCore/ArenaTeam: Add teamnames to logs.
deb2fb7 Merge pull request #10781 from jackpoz/create_pet_creaturetemplateScripts/Commands: Retrieve Creature template in HandlePetCreateCommand f...
9ca34c2 Merge pull request #10779 from jackpoz/murmur_unused_fieldScripts/Murmur: Remove unused field
38391cd Merge pull request #10737 from jackpoz/clock_fixCore/Timer: Better handle system clock changes
baa159d Merge pull request #10736 from jackpoz/localtime_race_conditionCore/Thread: Fix race condition converting time values to local time
dfc8a09 Scripts/Commands: Retrieve Creature template in HandlePetCreateCommand from Creature itselfCreatureTemplate can be retrieved directly from the Creature itself instead of using ObjectMgr::GetCreatureTemplate(id) .
625e47e Scripts/Murmur: Remove unused fieldRemove unused class field.
77f90c1 Scripts/Halion: refixed Twilight Cutter Scripts/Garfrost: fixed forge jump
3420c70 Scripts/PitOfSaron: some changesCloses #10740
97db577 DB/Cond: Error fix-up
189a4b0 Core/ArenaTeam: Add teamnames to logs.
6d3ebe9 SQL: Update sql/base/auth_database.sql
9379813 DB/Update: Few updatesFixes #10758
653ff9b Core/RBAC: Update RBACPermissions enum with 4.3.4 branch
a5bcab1 DB/Creature: Removed hack in 356ba1e0ce29c12815d927e3c87193f3f877071f
d617969 Core/RBAC: Fix typos in recent SQL filesI hope this is final one....
4d6adbb Core/RBAC: Fix typos in recent SQL files
f65be0d Core/RBAC: Fix typos in recent SQL files
6ec94e41@Core/RBAC: Fix typos in recent SQL files
c70eda3 Core/RBAC: Fix typos in recent SQL files
0ed8302 Core/RBAC: Fix typos in recent SQL files
953575a Core/RBAC: Remove obsolete generic command permissionsNote: If you have any custom command, CHECK THE SQLS BEFORE APPLYING
78363e1 Core/RBAC: Move titles and wp commands to RBAC (using individual permissions)
b102418 Core/RBAC: Move ticket commands to RBAC (using individual permissions)
68ab10c Core/RBAC: Move tele commands to RBAC (using individual permissions)
abbc6b2 Core/RBAC: Move server commands to RBAC (using individual permissions)
7183a35 Core/RBAC: Move reset commands to RBAC (using individual permissions)
1f95f0b Core/RBAC: Move reload command to RBAC (using individual permissions)
4f632ee Core/RBAC: Move quest commands to RBAC (using individual permissions)
efa194a Core/RBAC: Move npc commands to RBAC (using individual permissions)
04b3135 Core/RBAC: Move modify commands to RBAC (using individual permissions)
4d36ce7 Core/RBAC: Move mmap commands to RBAC (using individual permissions)
1038446 Core/RBAC: Move misc commands to RBAC (using individual permissions)
ec1e88d Core/RBAC: Move send commands to RBAC (using individual permissions)
62a4d53 Because I hate tabs
356ba1e DB/SAI: The Zephyrium Capacitorium(part 1), The Singing Ridge(part 2), Razaan's Landing, Ruuan WealdFixes #6322 Fixes #6323 Fixes #6324
83cb44d Core/RBAC: Move pet commands to RBAC (using individual permissions) - Pet commands moved from cs_misc.cpp to own file
1eee424 Core/RBAC: Move group commands to RBAC (using individual permissions) - group commands moved from cs_misc.cpp to own file - renamed groupsummon to "group summon"
f2121b1 DB/Cond: Conditions for Hodir's Horn
ddca805 DB/SAI: Blowing Hodir's Horn (12977)Fixes #10749
be5cf42 Core/SmartAI: Fixed creatures using SAI not attacking its charmer after it breaksCloses #7601
79307bc DB/Update: Needs null spawndist
688a35e DB/SAI: Trapping the Light Fantastic (10674) & Gather the Orbs (10859)Fixes #7202
Adds support for the Alliance quest also, and makes the orbs go in tandem with the horde version script.
fcf9552 Core/SmartScripts: Fixed heap corruption in SMART_ACTION_EQUIPCloses #10739
7eddda9 DB/Sai: Teron Gorefiend, I am...Added horde version for the script also.
00f3e42 DB/Updates: AI fixupsBy @Aokromes, fixes #10733 #10728
67f7c1f Core/Timer: Better handle system clock changesChange IntervalTimer::Reset() behavior to handle system clock changes forward and backward.
This fixes IntervalTimer:.Passed() returning true till it catches up to the new time, triggering the event up to "std::numeric_limits<time_t>::max() / _interval" times.
Fixes https://github.com/TrinityCore/TrinityCore/issues/5816
e8675dd Scripts/Blood Furnace: Fix possible compile errors on old VS versions
9578b5f Core/Thread: Fix race condition converting time values to local timeReplace thread-unsafe localtime() http://www.cplusplus.com/reference/ctime/localtime/ with thread-safe portable ACE_OS::localtime_r() .
Helgrind log:
Possible data race during read of size 4 at 0x6F183C0 by thread #1
Locks held: none
at 0x14E72E3: World::InitDailyQuestResetTime() (World.cpp:2772)
by 0x14E3A01: World::SetInitialWorldSettings() (World.cpp:1790)
by 0x101122A: Master::Run() (Master.cpp:164)
by 0x101740C: main (Main.cpp:142)
This conflicts with a previous write of size 4 by thread #2
Locks held: none
at 0x6C2D3BA: __tzfile_compute (tzfile.c:797)
by 0x6C2D036: __tz_convert (tzset.c:627)
by 0x164146C: LogMessage::getTimeStr(long) (Appender.cpp:23)
by 0x1641550: LogMessage::getTimeStr() (Appender.cpp:31)
by 0x1641722: Appender::write(LogMessage&) (Appender.cpp:80)
by 0x1633FCE: Logger::write(LogMessage&) (Logger.cpp:83)
by 0x16433D8: LogOperation::call() (LogOperation.cpp:29)
by 0x16428A4: LogWorker::svc() (LogWorker.cpp:45)
80516db Core/Battlegrounds: Allow random BG winner/loser rewards to be configurableSigned-off-by: Machiavelli <machiavelli.trinity@gmail.com>
287dc30 Merge pull request #10724 from jackpoz/guild_disband_leakCore/Guild: Fix memory leak on Guild disband
c3c5327 Merge pull request #10716 from Discover-/SAI_Owner_Or_SummonerCore/SAI: Make SMART_TARGET_OWNER_OR_SUMMONER also work for creatures su...
f661200 Scripts/Spells: drop obsolete code
fab0f46 Core/Condition: Added CONDITION_SOURCE_TYPE_PHASE_DEFINITION define for only 4.3.4 branch
8c70f8c Merge pull request #10730 from jackpoz/scoreboard_fixCore/Battleground: Fix scoreboard
3816fb4 Core/Battleground: Fix scoreboardFix scoreboard broken in 07d793b94b60941ea08fd6170d8165994452c49c . A local variable in a loop stored data of the iterator before incrementing it.
bc1a079 Core/SAI: Fix typo (i blame germans laziness)
e5af3e2 -.-
49e2ad7 Fixed build
9429251 Scripts/YoggSaron: fixed rewarding loot
adef15c Core/Spells: add an other condition to SpellInfo::NeedsToBeTriggeredByCaster to correct spells with are wrongly triggered by target instead of caster - convert archavons rock shards to spellscript (now it works properly) - add a spellscript for one spell that can't be corrected by this (and delete the sai hack, now i uses the correct spell)
46ffea8 Merge pull request #10729 from xjose93/DebugSendOpcodeFreezeCore/Commands: Fix .debug send opcode freeze if file dont exists.
35ef163 Core/Commands: Fix .debug send opcode freeze if file dont exists.
577c945 Update DBCStructure.h
fe8252b Scripts/Commands: Check if creature entry is valid before attempting to spawn (fixes unneccessary error in logs)
2fc6385 Core/Vehicles: Add vehicle_seat_flag_unk18 (0x20000) to seat.IsUsableByOverrideExact definition still needs to be researched
0ca481c Core/Achievements: Converted save queries to prepared statements
b9347dc DB/Misc: Fix few startup errors
a65c0ac Merge pull request #10722 from jackpoz/guild_startup_crashfixCore/Guild: Fix Guild validation crash on start up
9ce70fb Core/Guild: Fix memory leak on Guild disbandFix memory leak when disbanding a Guild, removed from GuildMgr but never deleted. Due to the different ways of how Guild::Disband() and Guild::DeleteMember() are called, each call to these methods has a different way to delete the Guild if empty/invalid.
Valgrind log:
2,127 (240 direct, 1,887 indirect) bytes in 1 blocks are definitely lost in loss record 54 of 81
at operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by guild_commandscript::HandleGuildCreateCommand(ChatHandler*, char const*) (cs_guild.cpp:91)
by ChatHandler::ExecuteCommandInTable(ChatCommand*, char const*, std::string const&) (Chat.cpp:339)
by ChatHandler::ExecuteCommandInTable(ChatCommand*, char const*, std::string const&) (Chat.cpp:320)
by ChatHandler::ParseCommands(char const*) (Chat.cpp:466)
by WorldSession::HandleMessagechatOpcode(WorldPacket&) (ChatHandler.cpp:217)
by WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:317)
by World::UpdateSessions(unsigned int) (World.cpp:2632)
by World::Update(unsigned int) (World.cpp:1989)
by WorldRunnable::run() (WorldRunnable.cpp:60)
by ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186)
by ACE_OS_Thread_Adapter::invoke() (in /usr/lib/libACE-6.0.3.so)
b056bc9 Core/Guild: Fix Guild validation crash on start upPartially revert 58ec4e531914121144b6f852e3abf27cbb2f6fc4 and increment GuildStore iterator before validating Guilds. This is required because Guild::Validate() removes the Guild from GuildStore if invalid.
Closes #8363
458f5b9 Core/SAI: Added SMART_ACTION_SUMMON_CREA / SMART_ACTION_SUMMON_GO log for has already summon spell
7ef1f07 Core/Battlegrounds/IoC: fix fortress teleport pads (and replace a hack with an other hack)Closes #5846
Closes #7993
Ref #8984
d5d0802 Merge pull request #10718 from jackpoz/console_fixCore/Command Line: Fix memory leak
5eff0b6 Core/Command Line: Fix memory leakFix memory leak in command line handler on platforms other than Windows. The result of readline() is supposed to be freed with free() as described at http://cnswww.cns.cwru.edu/php/chet/readline/readline.html#SEC24 .
Valgrind log:
11 bytes in 2 blocks are definitely lost in loss record 6 of 61
at 0x4C28BED: malloc (vg_replace_malloc.c:263)
by 0x4E5F6E8: xmalloc (in /lib/x86_64-linux-gnu/libreadline.so.6.2)
by 0x4E4571A: readline_internal_teardown (in /lib/x86_64-linux-gnu/libreadline.so.6.2)
by 0x4E46541: readline (in /lib/x86_64-linux-gnu/libreadline.so.6.2)
by 0x1005284: CliRunnable::run() (CliRunnable.cpp:161)
by 0x163A3DA: ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186)
by 0x518C555: ACE_OS_Thread_Adapter::invoke() (OS_Thread_Adapter.cpp:103)
by 0x61D7B4F: start_thread (pthread_create.c:304)
by 0x6C66A7C: clone (clone.S:112)
0e80c9e DB/Spawns: Spawns & AI for Corpulent Horrors
926edaf Tabs to spaces...
825cda9 DB/SAI: A Cleansing Song AI
e2c18bb DB/SAI: Putting Olakin Back Together Again (13220)
9761aff Core/SAI: Make SMART_TARGET_OWNER_OR_SUMMONER also work for creatures summoned by spells
a37f18a Core/Build: Fixed build
88df2ca Core/Build: Updated the header files to fix the build.
07d793b Core/Misc: Fixed some more issues found by static code analysis tools.
3ec941b Merge pull request #10697 from Chaplain/authserverAuth/Misc: Code cleanup.
2cfcf9d Scripts/HallsOfReflection: Fixed a typo detected by static analysis tool.
b3d5784 Merge pull request #10713 from jackpoz/movement_fixCore/Movement: Fix uninitialized MovementInfo fields
0450b74 Core/Movement: Fix uninitialized MovementInfo fieldsFix uninitialized fallTime and splineElevation fields of MovementInfo.
Valgrind log:
Conditional jump or move depends on uninitialised value(s)
at 0x5FBEB50: deflate (in /lib/x86_64-linux-gnu/libz.so.1.2.7)
by 0x1269883: UpdateData::Compress(void*, unsigned int*, void*, int) (UpdateData.cpp:85)
by 0x1269BB6: UpdateData::BuildPacket(WorldPacket*) (UpdateData.cpp:133)
by 0x130E9B3: Trinity::VisibleNotifier::SendToSelf() (GridNotifiers.cpp:68)
by 0x117A89D: Player::UpdateVisibilityForPlayer() (Player.cpp:22344)
by 0x117B334: Player::SendInitialPacketsAfterAddToMap() (Player.cpp:22567)
by 0x15A48BC: WorldSession::HandlePlayerLogin(LoginQueryHolder*) (CharacterHandler.cpp:937)
by 0x141D04B: WorldSession::ProcessQueryCallbacks() (WorldSession.cpp:1106)
by 0x141994D: WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:391)
by 0x14E289C: World::UpdateSessions(unsigned int) (World.cpp:2629)
by 0x14E0613: World::Update(unsigned int) (World.cpp:1986)
by 0x100B37F: WorldRunnable::run() (WorldRunnable.cpp:60)
Uninitialised value was created by a heap allocation
at 0x4C286E7: operator new(unsigned long) (vg_replace_malloc.c:287)
by 0x159E64F: void LoadHelper<Creature>(std::set<unsigned int, std::less<unsigned int>, std::allocator<unsigned int> > const&, CoordPair<512u>&, GridRefManager<Creature>&, unsigned int&, Map*) (ObjectGridLoader.cpp:94)
by 0x159DECF: ObjectGridLoader::Visit(GridRefManager<Creature>&) (ObjectGridLoader.cpp:150)
by 0x159F092: void VisitorHelper<ObjectGridLoader, Creature>(ObjectGridLoader&, ContainerMapList<Creature>&) (TypeContainerVisitor.h:64)
by 0x159EFF5: void VisitorHelper<ObjectGridLoader, Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > >(ObjectGridLoader&, ContainerMapList<TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > >&) (TypeContainerVisitor.h:70)
085602a DB/SAI: Guided by Honor 11289Fixes #2263
Requires spell to give quest credit, hence the issue of being unable to turn it in.
24f8b2b Core/Misc: Fixed some more issues found by code analysis tools.
5b95301 Core/Misc: Solved some issues found by static code analysis.
26373ee DB/SAI: Disclosure (12710)Fixes #7192
The credit timing is very strange, it is given right at the start of the script, but that's how it is from Blizzard, so we'll stick to that.
As for the areatriggers, I know I could've just simplified it and made it into an areatrigger_teleport. But the sniffs state that it is the trigger that just makes the bunnies cast the teleport spell, so we'll keep that one complicated.
This is the penultimate quest of the chain, the final quest is a WIP. Any additional info would be very helpful.
Regards, Kirk.
29b1c58 DB/Update: Spells update for Bloadted Abomination
0b598d3 DB/Creature: Delete 2 mobs spawned on the void
78c53bb Quest/SAI: Fix quest credit for quest "Monitoring the Rift: Cleftcliff Anomaly"
6581ece DB/SAI: Mystery of the Infinite (12470)Fixes #10510
5e03230 Scripts/HallsOfStone: Sjonnir, some improvements - rewritten to BossAI - added spawn ordered by percent, according to official dataCloses #10702
Signed-off-by: joschiwald <joschiwald@online.de>
aa8bfee Auth/Misc: Code cleanup. *Random performance optimizations
3722fcb Scripts/HoL/HoS: changed some bosses to optional, doors are always open
ab85a95 Core/SAI: Added SMART_ACTION_CALL_KILLEDMONSTER log for has already spell kill credit
9b92bc9 Core: Fix compile with PCH enabled and warningsFew corrections to worldserver.conf
579f969 Scripts/HallsOfStone: reworked InstanceScript
79f4463 Fix SQL typo after RBAC commits
0004d2e Fix SQL typos after RBAC commits
28f9317 Core/RBAC: Move cast and characters commands to RBAC (using individual permissions)
f3487aa Compile Fix (and edit of last 2 sqls to add the missing permissions)
f68471f Core/RBAC: Move message commands to RBAC (using individual permissions)
2d50838 Core/Commands: Move lookup commands to RBAC (using individual permissions)
eb73684 Core/RBAC: Move list commands to RBAC (using individual permissions)
4219f45 Core/RBAC: Move lfg commands to RBAC (using individual permissions)
c0dfdea Core/RBAC: Move learn commands to RBAC (using individual permissions)
2625e78 Core/RBAC: Move instance commands to RBAC (using individual permissions)
08ef6bd Core/RBAC: Move honor commands to RBAC (using individual permissions)
11233db Core/RBAC: Move guild commands to RBAC (using individual permissions)
015eee0 Core/RBAC: Move gobject commands to RBAC (using individual permissions)
29c57c3 Core/RBAC: Move go commands to RBAC (using individual permissions)
1bccf67 Core/RBAC: Move gm commands to RBAC (using individual permissions)
fced8a8 Core/RBAC: Move event commands to RBAC (using individual permissions)
225691e Core/RBAC: Move disable commands to RBAC (using individual permissions)
cf9d01a Normalize sql file names from 722a6c1
3e45640 Core/RBAC: Move deserter commands to RBAC (using individual permissions)
f53c61c Core/RBAC: Move debug commands to RBAC (using individual permissions)
33d9da5 Core/RBAC: Move cheat commands to RBAC (using individual permissions)
59667ee Core/Spells: move debug log into debug mode
69a0800 Merge pull request #10696 from jackpoz/socket_race_conditionCore/Socket: Fix race condition in WorldSocket
68b447b Merge pull request #10563 from Ascathor/masterCore/Account: Make account password change security variable and various changes
37bdc7a DB/SAI: Fix quest credit for quest "Laying Waste to the Unwanted"
f388ceb Merge pull request #10687 from jackpoz/farsight_fixCore/Spell: Fix farsight log error "Player requests non-existing seer"
1417f62 Core/Spell: Fix farsight log error "Player requests non-existing seer"Partially revert 167ca565d044915f01ead4b189754ab1c44cc981 which wrongly used TYPEMASK_UNIT to denote Creatures and Players, so when a Player sent farsight opcode with another Player as target HandleFarSightOpcode() couldn't find the right Unit filtering by typemask TYPEMASK_SEER.
e8a566b Core/Objects: Removed obsolete code
99c94f3 DB/Misc: Fix startup errors & typo
a43e97f SQL: Fix fail in 7facda2002e80401ce71ab7562042293eba62ad6
7facda2 DB/Loot: make sure to update & delete the right templates, updated file!
f23b5fb Core/Socket: Fix race condition in WorldSocketReactorRunnable::svc() checks the status of WorldSockets while WorldRunnable::run() updates them, causing a race condition.
Helgrind log:
Possible data race during write of size 8 at 0x49961810 by thread #9
Locks held: 1, at address 0x4367A620
at 0x51781F7: ACE_Message_Block::copy(char const*, unsigned long) (Message_Block.inl:372)
by 0x15D048F: WorldSocket::SendPacket(WorldPacket const&) (WorldSocket.cpp:180)
by 0x141C45E: WorldSession::SendPacket(WorldPacket const*) (WorldSession.cpp:223)
by 0x15C49C4: WorldSession::SendAuthResponse(unsigned char, bool, unsigned int) (AuthHandler.cpp:37)
by 0x14DA71C: World::AddSession_(WorldSession*) (World.cpp:278)
by 0x14E601E: World::UpdateSessions(unsigned int) (World.cpp:2617)
by 0x14E3E67: World::Update(unsigned int) (World.cpp:1986)
by 0x100EAFA: WorldRunnable::run() (WorldRunnable.cpp:60)
by 0x163A626: ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186)
by 0x518F555: ACE_OS_Thread_Adapter::invoke() (OS_Thread_Adapter.cpp:103)
by 0x4C2B5AD: mythread_wrapper (hg_intercepts.c:219)
by 0x61DAB4F: start_thread (pthread_create.c:304)
This conflicts with a previous read of size 8 by thread #14
Locks held: none
at 0x1008414: ACE_Message_Block::length() const (Message_Block.inl:131)
by 0x15D1207: WorldSocket::Update() (WorldSocket.cpp:448)
by 0x1427CA3: ReactorRunnable::svc() (WorldSocketMgr.cpp:177)
by 0x51CBB16: ACE_Task_Base::svc_run(void*) (Task.cpp:271)
by 0x51CD3BC: ACE_Thread_Adapter::invoke_i() (Thread_Adapter.cpp:161)
by 0x51CD4D4: ACE_Thread_Adapter::invoke() (Thread_Adapter.cpp:96)
by 0x4C2B5AD: mythread_wrapper (hg_intercepts.c:219)
by 0x61DAB4F: start_thread (pthread_create.c:304)
Address 0x49961810 is 16 bytes inside a block of size 80 alloc'd
at 0x4C286BB: operator new(unsigned long, std::nothrow_t const&) (vg_replace_malloc.c:316)
by 0x15D0818: WorldSocket::open(void*) (WorldSocket.cpp:237)
by 0x1429560: ACE_Acceptor<WorldSocket, ACE_SOCK_Acceptor>::activate_svc_handler(WorldSocket*) (Acceptor.cpp:347)
by 0x142916D: ACE_Acceptor<WorldSocket, ACE_SOCK_Acceptor>::handle_input(int) (Acceptor.cpp:429)
by 0x515F48D: ACE_Dev_Poll_Reactor::dispatch_io_event(ACE_Dev_Poll_Reactor::Token_Guard&) (Dev_Poll_Reactor.inl:86)
by 0x5161653: ACE_Dev_Poll_Reactor::handle_events(ACE_Time_Value*) (Dev_Poll_Reactor.cpp:1015)
by 0x51ACCFC: ACE_Reactor::run_reactor_event_loop(ACE_Time_Value&, int (*)(ACE_Reactor*)) (Reactor.cpp:267)
by 0x1427C57: ReactorRunnable::svc() (WorldSocketMgr.cpp:170)
by 0x51CBB16: ACE_Task_Base::svc_run(void*) (Task.cpp:271)
by 0x51CD3BC: ACE_Thread_Adapter::invoke_i() (Thread_Adapter.cpp:161)
by 0x51CD4D4: ACE_Thread_Adapter::invoke() (Thread_Adapter.cpp:96)
by 0x4C2B5AD: mythread_wrapper (hg_intercepts.c:219)
ed38441 DB/Loot: Rework skinning_loot_template definitions, removing the horrible definitions ripped from wowhead and replacing them with a proper defined set of lootCloses #10610
722a6c1 Core/Account: Make account password change security variable and various changesSettings within worldserver.conf:
Three settings for secruity level:
0 - None - No change to current system
1 - Email - Always requires the email entered on registration for confirming.
2 - RBAC - Groups applied with the RBAC role always require the email entered on registration for confirming.
RBAC default to every group. Changed some logs to make it more clear what is going on at all.
Emails may now no longer exceed 64 chars. Current email is used as regmail.
On account creation, two emails are saved. Registration email and normal email. Normal email is relevant afterwards. Registration email can be changed by console ONLY.
Includes new commands and changes to existing ones:
.account fulfills several new functions:
* Still prints GM Level.
* If account has permission, it displays the current email. This is not defaulted to any group.
* Security level is displayed. Also displays if user has RBAC perm if RBAC security mode is selected
.account email allows user to change email with sufficient confirmation
.account set sec email allows higher sec with higher sec than account to change the normal email. Registrationemail remains untouched here.
.account set sec regmail allows console to change registration email.
.pinfo now displays the registration and normal mail.
Also fixes .learn all crafts.
Closes #10558
79d1b7f Scripts/Misc: Removed unused fields and fixed a warning about uninitialized value
591b90f DB/SAI: Fix quest credit for quest "Torching Sunfury Hold"
8897f80 DB/SAI: Fix quest credit for quest "Building a Perimeter" Note: Quest need event script
ff8eab2 DB/SAI: Fix quest credit for quest "Burn in Effigy" Note: Quest need event script
cd11366 Merge pull request #10694 from jackpoz/loopcounter_race_conditionCore/Thread: Fix race condition in FreezeDetectorRunnable
5826860 Merge pull request #10685 from Discover-/SmartAI-Target-CastingCore/SmartAI: Add a spellid to SMART_EVENT_TARGET_CASTING. If left on 0,...
c4bd91c Merge pull request #10690 from Discover-/SmartAI-Set-Home-PosCore/SAI: Allow using SMART_ACTION_SET_HOME_POS with multiple target typ...
b324646 Merge pull request #10689 from Discover-/SmartAI-Killed-Monster-CreditCore/SAI: Also use loot recipient for SMART_ACTION_CALL_KILLEDMONSTER wh...
a762df0 Core/SAI: Fix processing linked events when return is used in ProcessActionThanks Discover-
Closes #10688
271a101 Dep/G3D: Fix encoding of G3D-v8.0_hotfix8.diff
e1e1067 Core/Thread: Fix race condition in FreezeDetectorRunnableFix race condition by replacing a static volatile uint32 with proper atomic thread-safe ACE_Atomic_Op<ACE_Thread_Mutex, uint32>, incremented in WorldRunnable::run() at each world loop and read in FreezeDetectorRunnable::run().
Helgrind log:
Possible data race during read of size 4 at 0x2400D54 by thread #12
Locks held: none
at 0x100FEA6: FreezeDetectorRunnable::run() (Master.cpp:106)
by 0x1637892: ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186)
by 0x518F555: ACE_OS_Thread_Adapter::invoke() (OS_Thread_Adapter.cpp:103)
by 0x4C2B5AD: mythread_wrapper (hg_intercepts.c:219)
by 0x61DAB4F: start_thread (pthread_create.c:304)
by 0x6C69A7C: clone (clone.S:112)
This conflicts with a previous write of size 4 by thread #9
Locks held: none
at 0x100C23E: WorldRunnable::run() (WorldRunnable.cpp:55)
by 0x1637892: ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186)
by 0x518F555: ACE_OS_Thread_Adapter::invoke() (OS_Thread_Adapter.cpp:103)
by 0x4C2B5AD: mythread_wrapper (hg_intercepts.c:219)
by 0x61DAB4F: start_thread (pthread_create.c:304)
by 0x6C69A7C: clone (clone.S:112)
6f9099c Merge pull request #10693 from Chaplain/g3d-typosDep/G3D: Fix a typo in Vector3int32 += operator
6b60877 Core/NetworkIO: Fixed memory leak
a0f4177 Dep/G3D: Fix a typo in Vector3int32 += operator
cdc7165 DB/TrinityString: Fix an issue with non-ascii characters encodingThanks Warpten for the fix (always import files with mysql --default-char-set=utf8 < file)
Thanks eragon for reporting the issue and testing the fix
8dfb977 Dep/G3D: Update Readme.txt
8ba8190 Core/SAI: Allow using SMART_ACTION_SET_HOME_POS with multiple target types
7d7fc7b Core/SAI: Also use loot recipient for SMART_ACTION_CALL_KILLEDMONSTER when target is SMART_TARGET_SELF (used in four cases in a clean TDB which will be fixed by this)
e526e14 Core/Scripts: fix build
5c5b78c Scripts/Ulduar: fix mark of the faceless and add missing door handling
016dac9 Core/SmartAI: Add a spellid to SMART_EVENT_TARGET_CASTING. If left on 0, it checks for all spells (like it did without these changes)
27bc3b1 Core/Creatures: Added error log for SPELL_AURA_CONTROL_VEHICLE auras in creature_addon / creature_template_addon
1bbd726 Merge branch 'master' of github.com:TrinityCore/TrinityCore
0394238 Dep/G3D: Fix a typo in Matrix4 == operator
eab035e Revert e6761ea2aa7897eda7dafa0b11f17c26eb60e334
16fcac1 Core/RBAC: Move bf commands to RBAC (using individual permissions)
e6761ea Core/NetworkIO: Fix memory leakPacket headers not being correctly deallocated.
22b7124 DB/Creature: Fix cords for quest "Death Comes From On High"
e753a47 DB/Sai: Fix quest credit for quest "Blessing of Incineratus"
842b807 DB/Creature: Add missing sql in 8fd1f461929d78054b72f00483ad057d0e80a238
8fd1f46 Scripted: Fix warning
b1721a6 Core/Spells: Fix quest credit for quest "Death Comes From On High"
ae36dde Core/Scripts: add creature_text to pet mojo Scripts/Karazhan/Moroes: cleanup a bit (should fixes mem leak)
a2ee732 DB/SAI: The Lost Mistwhisper Treasure (12575)
2d93059 SQL: Fix a typo in e375c6075b214b85599
1501e95 SQL: Fix typo in 44a317b71fd02cc6ee9ad48bc7d5328ae468db71
44a317b DB/Reputation: Move quest_repeatable_rate after quest_monthly_rate
3f6296b Merge branch 'master' of github.com:TrinityCore/TrinityCore
7ecf4fd Core/Quests: Split Flags and SpecialFlags
4f10e6b SQL: Fixed file name
16eefd1 Scripts/Icecrown Citaldel: Fixed spells cast by Professor Putricide during heroic Festergut and Rotface encountersCloses #7641
Closes #8243
157eb82 DB/SAI: Deeprun Rat Roundup (6661)
4b5c4ab Core/CharacterHandler: Some more rules for CMSG_CHAR_ENUM allowanceThanks to @TakenBacon for heads up
be7d82b Core/Maps: Fix Spline triggered assertFix an assert triggered by float to int32 cast overflowing to -1, now it replaces -1 with max int32 value.
Fix another assert triggered by Vector3 magnitude float overflow to max/infinity in StaticMapTree::isInLineOfSight(), in this case return false.
Both asserts can be reproduced by casting Mind Control to a NPC, tele to z: 1.0e+38 using client hack tools, move to allow the server to register the new position and stop Mind Control.
Closes #8970
Closes #10578
Closes #10355
Closes #10673
dd7802c SQL: Rename wrong named SQL file.
081ee8f SQL: Fix typo
e3f27a3 Core/Creatures: Fix base stats calculations for some cases.i.e. health_mod of 0.001 resulting in hp of 0 instead of 1
87e105c Core: Fix warning
7776016 Core/Quests: Remove CastedCreatureOrGO method- Remove EAI's ACTION_T_CAST_EVENT and ACTION_T_CAST_EVENT_ALL
- Remove SAI's SMART_ACTION_CALL_CASTEDCREATUREORGO
- Split QUEST_TRINITY_FLAGS_KILL_OR_CAST into QUEST_TRINITY_FLAGS_KILL and QUEST_TRINITY_FLAGS_CAST
- Assign QUEST_TRINITY_FLAGS_CAST to all the quests that were using RequiredSpellCastX
- (unrelated) Fix a warning in Player.cpp
- Replace CastedCreatureOrGO usage in scripts by KilledMonsterCredit
TODO: Convert the two EAI scripts commented out in the .sql to proper SAI
Closes #10667
aa5bc37 Core: Yet more warning fixes
1903d4c Core/Server: Fix a spammy warning in WorldSession and move code to .cpp
9bea4fc Core/RBAC: Move ban commands to RBAC (using individual permissions)
2b69f83 Core/RBAC: Move Achievements and Arena commands to RBAC (using individual permissions)
109188a Core/RBAC: Move account commands to RBAC (using individual permissions)
17e8248 Correct RBAC command names in DB
e0d334b Corrections to ea26928 sql files
d805a2d SQLS: Rename wrong named sql file
ea26928 Core/RBAC: Move RBAC commands to RBAC using individual permissions - Use this commit as a sample on how to move commands to RBAC
3232b69 Core/RBAC: Move commands security to RBAC (using generic RBAC Permissions) - Warning: This will break commands for any custom security level
e375c60 DB/Loot: Titanium VeinBy @dr-j fixes #10671
ec837b1 Merge pull request #10666 from xjose93/SmartScripts-StartEvent Implement SMART_ACTION_GAME_EVENT_STOP (111) and SMART_ACTION_GAME_EVENT_START (112).
c3afc00 Implement SMART_ACTION_GAME_EVENT_STOP (111) and SMART_ACTION_GAME_EVENT_START (112).
213998e Core/NetworkIO: Allow CMSG_CHAR_ENUM after char creation and char deletionPerhaps these calls could be better placed but it's a matter of trial
and error to see what is most effective.
9346695 Core: Few fixes for previous commit.
59b4c34 Core/NetworkIO: Generic packet spam solutionCurrently regulates the usage of CMSG_CHAR_ENUM only, but can be easily
extended to detect inappropriate network behaviour by using
AntiDOS.AllowOpcode in WorldSession's handlers.
3b71172 Core/Quests: Fix a typo in a previous commitCloses #10664
179a45d DB/Errors: Db error fixFixes #10663
62d1ee6 Core/Quests: Drop world.quest_template.RequiredSpellCastXThese were non-wdb fields that didn't have much use.
Most quests that were using these fields (not many) should still work,
however, if you find any quest that worked before and is now broken
please report it in the issue tracker and it will be promptly fixed.
6c8ae75 DB/Sai: Suppression (7583)Fixes #7377
6469656 DB/Loot: Fix Sealed Chest lootFix by @untaught, closes #10652
e23b643 Core/Quests: Escape from Silverbrook 12308
c84f545 Core/SmartAI: Add passive check for WP movement
56886a8 DB/Update: Bladespire Kegger & Getting the Bladespire TankedFixes #2371
0910f42 DB/SAI: Matthias LehnerFix up for gossip. He should also show gossip only on quest, and for both alliance and horde.
7617198 Scripts/Spells: fix codestyle in 48783b86067f8c2691ec5e5e94e5bbd788b9deb2
48783b8 Core/Quests: Fuel for the Fire (12690)
a917461 DB/Misc: Fix startup errors
4fc292c DB/Conditions: fix startup error
5eeed14 DB/Quests: Fix "I'm Not Dead Yet!"Closes #9807
75406b2 DB/Quests: Prepping the Speech description/progress/completion textCloses #10607
61fbe1c DB/Spawns: Kor'kron Reaver & Skybreaker Marine are currently missing from Dalaran's Krasus landingCloses #10615
577e320 DB/Schema: Fix typo in reputation_reward_rate.quest_repeatable_rate name
f5f0e64 Scripts/UtgardeKeep/Ingvar: remove hacks and fix warning
83e5168 DB/Reputation: Reward 3x reputation for Sporegar on repeteable questsCloses #5789
2bd4a47 Core/Quests: Add repeatable quest rate to world.reputation_reward_rate
3e2e210 Core/Build: Force minimum ACE (5.8.3) and OpenSSL (1.0.0) version detection Core/Build: Do not ignore command line cmake options: ACE_INCLUDE_DIR, ACE_LIBRARY and OPENSSL_INCLUDE_DIR
7135abf Merge branch 'master' of github.com:TrinityCore/TrinityCore
78786c7 Core&Scripts: Fix clang compiler warnings
1f34284 Scripts/UtgardeKeep: reworked InstanceScript and cleanup some boss script
e5dc701 Server/Collision: Fix build on clang
cc14e18 Core/Misc: Fix compiler warnings
19accfc DB: Missing declaration
a5ed6f6 DB/SAI: Sabotage 12676 (part 1)Fixes #6460
56c168e DB/SAI: Zero Tolerance & Hazardous MaterialsUse the Hand of Drakuru to kill Darmuk, player should stand from a distance.
a638f3d DB/Loot: Bosses in Shattered Halls HeroicFixes #10638 by @dr-j
b8d6974 DB/Comments: Unclear comments
2d15acd DB/SAI: It Rolls Downhill 12673Fixes #5718
You need to have mmaps enabled if you want the delivering of the geist to look blizzlike, otherwise it will ignore the path.
69a616e Core/EventAI: Shut up compiler warnings
2aa944c Scripts/Auchindoun: add missing InstanceScripts and cleanup some boss scripts
cfd1027 Build fix
4f44cdf Core/Scripts: Fixed uninitialized variable and memory leaks
664ed81 Merge pull request #10636 from jackpoz/mindvision_fixCore/Aura: Fix SPELL_AURA_BIND_SIGHT invalid read
2050a36 SAI & Scripts: Fix unitialized values found by Valgrind==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x19B3031: boss_skarvald_the_constructor::boss_skarvald_the_constructorAI::UpdateAI(unsigned int) (boss_skarvald_dalronn.cpp:217)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x19B3948: boss_dalronn_the_controller::boss_dalronn_the_controllerAI::UpdateAI(unsigned int) (boss_skarvald_dalronn.cpp:388)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x15E2FCC: SmartScript::ProcessAction(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:144)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064== by 0x191D242: npc_shadron::npc_shadronAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1122)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x19AE913: boss_ymiron::boss_ymironAI::UpdateAI(unsigned int) (boss_ymiron.cpp:215)
==3064== Use of uninitialised value of size 8
...
==3064== by 0x18A9F4A: boss_illidan_stormrage::boss_illidan_stormrageAI::Reset() (boss_illidan.cpp:1805)
==3064== Conditional jump or move depends on uninitialised value(s)
...
==3064== by 0x18A9F4A: boss_illidan_stormrage::boss_illidan_stormrageAI::Reset() (boss_illidan.cpp:1805)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064== by 0x191CE88: npc_tenebron::npc_tenebronAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1027)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x191CB98: dummy_dragonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:961)
==3064== by 0x191D5B8: npc_vesperon::npc_vesperonAI::UpdateAI(unsigned int) (boss_sartharion.cpp:1220)
==3064== Conditional jump or move depends on uninitialised value(s)
...
==3064== by 0x1868F59: boss_lady_vashj::boss_lady_vashjAI::Reset() (boss_lady_vashj.cpp:206)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x191C14C: dummy_dragonAI::MovementInform(unsigned int, unsigned int) (boss_sartharion.cpp:802)
==3064== Conditional jump or move depends on uninitialised value(s)
==3064== at 0x1046986: Position::NormalizeOrientation(float) (Object.h:388)
...
==3064== by 0x17D9463: boss_malchezaar::boss_malchezaarAI::SummonInfernal(unsigned int) (boss_prince_malchezaar.cpp:373)
2a47b60 Core/Aura: Fix SPELL_AURA_BIND_SIGHT invalid readMind Vision has Aura Effect SPELL_AURA_BIND_SIGHT which adds the target to a special Map container i_objectsToSwitch, used to switch grid containers for target Creatures of this Aura Effect.
When the target is a Creature, when the Creature is removed from world it's added to i_objectsToSwitch and then to i_objectsToRemove, iterated in this order in Map::RemoveAllObjectsInRemoveList() so the reference in i_objectsToSwitch is valid.
When the target is a Player, when the Player logs out it's added to i_objectsToSwitch but then Map::RemovePlayerFromMap() deletes the Player, leaving an invalid reference in i_objectsToSwitch.
Since the whole point of i_objectsToSwitch is to store Creatures and since the stored references are used only if the condition "GetTypeId() == TYPEID_UNIT" is verified, it's safe to add only objects of TYPEID_UNIT type to the container.
Valgrind log:
Invalid read of size 4
at 0xC52332: Object::GetTypeId() const (Object.h:140)
by 0xF540D3: Map::RemoveAllObjectsInRemoveList() (Map.cpp:2136)
by 0xF53CD2: Map::DelayedUpdate(unsigned int) (Map.cpp:2087)
by 0xF639B1: MapManager::Update(unsigned int) (MapManager.cpp:292)
by 0x107CB40: World::Update(unsigned int) (World.cpp:2025)
by 0xBEB263: WorldRunnable::run() (WorldRunnable.cpp:60)
by 0x1213792: ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186)
by 0x515EA35: ACE_OS_Thread_Adapter::invoke() (in /usr/lib/libACE-6.0.3.so)
by 0x5F19F8D: start_thread (pthread_create.c:311)
by 0x6A46E1C: clone (clone.S:113)
Address 0x401eacac is 12 bytes inside a block of size 11,736 free'd
at 0x4C2B59C: operator delete(void*) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0xD80239: Player::~Player() (Player.cpp:915)
by 0xF4D5A2: void Map::DeleteFromWorld<Player>(Player*) (Map.cpp:319)
by 0xF4EBBB: Map::RemovePlayerFromMap(Player*, bool) (Map.cpp:687)
by 0xFCC18D: WorldSession::LogoutPlayer(bool) (WorldSession.cpp:531)
by 0xF1EDD5: WorldSession::HandleLogoutRequestOpcode(WorldPacket&) (MiscHandler.cpp:403)
by 0xFCAE37: WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:312)
by 0x107EBC6: World::UpdateSessions(unsigned int) (World.cpp:2615)
by 0x107C94B: World::Update(unsigned int) (World.cpp:1978)
by 0xBEB263: WorldRunnable::run() (WorldRunnable.cpp:60)
by 0x1213792: ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186)
by 0x515EA35: ACE_OS_Thread_Adapter::invoke() (in /usr/lib/libACE-6.0.3.so)
02258e9 DB/Errors: Error fixFixes #10634
9327832 Merge pull request #10633 from jackpoz/createguild_fixCore/Guild: Fix uninitialized value on guild creation
287eb26 Core/Guild: Fix uninitialized value on guild creationFix GuildMember flags left uninitialized when creating a new guild.
Valgrind log:
Conditional jump or move depends on uninitialised value(s)
at 0xEE49CE: Guild::Member::WritePacket(WorldPacket&) const (Guild.cpp:714)
by 0xEE721E: Guild::HandleRoster(WorldSession*) (Guild.cpp:1314)
by 0xEE9EBA: Guild::SendLoginInfo(WorldSession*) (Guild.cpp:1920)
by 0xEEB689: Guild::AddMember(unsigned long, unsigned char) (Guild.cpp:2230)
by 0xEE6A09: Guild::Create(Player*, std::string const&) (Guild.cpp:1199)
by 0x12A71F9: guild_commandscript::HandleGuildCreateCommand(ChatHandler*, char const*) (cs_guild.cpp:92)
by 0xC47DBE: ChatHandler::ExecuteCommandInTable(ChatCommand*, char const*, std::string const&) (Chat.cpp:362)
by 0xC47C23: ChatHandler::ExecuteCommandInTable(ChatCommand*, char const*, std::string const&) (Chat.cpp:343)
by 0xC488C4: ChatHandler::ParseCommands(char const*) (Chat.cpp:489)
by 0x1188EE3: WorldSession::HandleMessagechatOpcode(WorldPacket&) (ChatHandler.cpp:217)
by 0xFCAE37: WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:312)
by 0x107EBC6: World::UpdateSessions(unsigned int) (World.cpp:2615)
8eaf763 Core&Tools: Fix multiple issues found by a static code coverage tool
a4fcbd1 DB/SAI: Ribbly Screwspigot (4136)Fixes #6911
608f9e7 DB/SAI: Out of Body Experience (12327)Fixes #3084
39ccd4a Merge pull request #10624 from jackpoz/instancesavemgrCore/Instances: Fix mutex released after being deleted
a3bdf90 Core/Instances: Fix mutex released after being deletedModify how InstanceSave is deleted so the local mutex can be released before deleting the class itself.
Valgrind log:
Invalid read of size 4
at 0x662662B: __pthread_mutex_unlock_usercnt (pthread_mutex_unlock.c:52)
by 0x55D3C55: ACE_OS::mutex_unlock(pthread_mutex_t*) (OS_NS_Thread.cpp:2335)
by 0xB20057: Player::CleanupsBeforeDelete(bool) (OS_NS_Thread.inl:3519)
by 0xD0E2FA: WorldSession::LogoutPlayer(bool) (WorldSession.cpp:527)
by 0xC66D34: WorldSession::HandleLogoutRequestOpcode(WorldPacket&) (MiscHandler.cpp:403)
by 0xD0EA82: WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:312)
by 0xD9AD66: World::UpdateSessions(unsigned int) (World.cpp:2615)
by 0xD9BEC4: World::Update(unsigned int) (World.cpp:1978)
by 0xA035E5: WorldRunnable::run() (WorldRunnable.cpp:60)
by 0xEC8D39: ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:183)
by 0x55D7555: ACE_OS_Thread_Adapter::invoke() (OS_Thread_Adapter.cpp:103)
by 0x6622B4F: start_thread (pthread_create.c:304)
Address 0x1884bb08 is 56 bytes inside a block of size 104 free'd
at 0x4C279DC: operator delete(void*) (vg_replace_malloc.c:457)
by 0xC9D533: InstanceSaveManager::RemoveInstanceSave(unsigned int) (InstanceSaveMgr.cpp:159)
by 0xC9E826: InstanceSave::UnloadIfEmpty() (InstanceSaveMgr.cpp:238)
by 0xB2003E: Player::CleanupsBeforeDelete(bool) (InstanceSaveMgr.h:84)
by 0xD0E2FA: WorldSession::LogoutPlayer(bool) (WorldSession.cpp:527)
by 0xC66D34: WorldSession::HandleLogoutRequestOpcode(WorldPacket&) (MiscHandler.cpp:403)
by 0xD0EA82: WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:312)
by 0xD9AD66: World::UpdateSessions(unsigned int) (World.cpp:2615)
by 0xD9BEC4: World::Update(unsigned int) (World.cpp:1978)
by 0xA035E5: WorldRunnable::run() (WorldRunnable.cpp:60)
by 0xEC8D39: ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:183)
by 0x55D7555: ACE_OS_Thread_Adapter::invoke() (OS_Thread_Adapter.cpp:103)
eeb2102 DB/Sai: Make cauldrons reward buffs
3e2f037 Core&Tools: Fix warnings and non-pch build
ee3d3ab Core/Player: Fix uninitialized Player field.m_MonthlyQuestChanged was initialized only when loading a Player from DB and left uninitialized when creating a new Player.
Valgrind log:
Conditional jump or move depends on uninitialised value(s)
at 0x1148E2A: Player::_SaveMonthlyQuestStatus(Trinity::AutoPtr<Transaction, ACE_Thread_Mutex>&) (Player.cpp:19694)
by 0x1146510: Player::SaveToDB(bool) (Player.cpp:19191)
by 0x14F5D5C: WorldSession::HandleCharCreateCallback(Trinity::AutoPtr<PreparedResultSet, ACE_Thread_Mutex>, CharacterCreateInfo*) (CharacterHandler.cpp:660)
Closes #10620
Signed-off-by: Nay <dnpd.dd@gmail.com>
ba22bae Core/Auth: Implement time-based token for user login as described in RFC 6238.New column in account table is a base32 of token key bytes,
coincidentally it is the same format Google's Authenticator Android app uses.
If you want that to work, set system time on server correctly and use ntpd.
Closes #10527
Signed-off-by: Nay <dnpd.dd@gmail.com>
e96aa44 Core/Threading: Fix race condition in ThreadIncrement the reference count of m_task in Thread::start() before spawning the actual Thread that will execute the task, otherwise the thread might finish, decRef the task and delete it.
Valgrind log of the issue:
Invalid read of size 8
at 0x1314CAD: ACE_Atomic_Op_GCC<long>::operator++() (Atomic_Op_GCC_T.inl:34)
by 0x15933FB: ACE_Based::Runnable::incReference() (Threading.h:36)
by 0x1592D2D: ACE_Based::Thread::start() (Threading.cpp:136)
by 0x1592C37: ACE_Based::Thread::Thread(ACE_Based::Runnable*) (Threading.cpp:111)
by 0xF6C463: Master::Run() (Master.cpp:195)
by 0xF725D0: main (Main.cpp:142)
Address 0x26137278 is 8 bytes inside a block of size 24 free'd
at 0x4C2B59C: operator delete(void*) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
by 0xF67FDB: RARunnable::~RARunnable() (RARunnable.cpp:55)
by 0x1593441: ACE_Based::Runnable::decReference() (Threading.h:40)
by 0x1592E92: ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186)
by 0x515EA35: ACE_OS_Thread_Adapter::invoke() (in /usr/lib/libACE-6.0.3.so)
by 0x5F19F8D: start_thread (pthread_create.c:311)
by 0x6A46E1C: clone (clone.S:113)
Closes #10619
174efdf DB/Creature: Fix startup errors
12973de Core&Tools: Fix multiple issues found by a static code coverage tool
61016dc DB/SAI: Cannot Reproduce (13320,13355) & Retest Now (13321,13322,13356,13357)
573c919 Merge pull request #10617 from jackpoz/updatemask_fixFix uninitialized UpdateMask field
5a06f3c DB/SAI: The Last of Her Kind credit updateBy @untaught, fixes #10254
2145973 Fix uninitialized UpdateMask fieldInitialized UpdateMask::_bits to NULL in all constructors.
UpdateMask(UpdateMask const& right) constructor sets the field count with SetCount() method before any field initialization. This means that SetCount() will call delete[] on the uninitialized _bits pointer field, leading to undefined behavior.
adaf5b3 DB/Conditions: Awakening Rod
58e6503 Core/Settings: Fix build in non cpp11 compilersstd::string back() was only introduced in C++11, a pity..
4d098b0 [DB/SAI] Sleeping Giants (11432 & 11433)
cc3055f Core/Settings: Fix a crash if worldserver.conf DataDir setting is empty
0d5181a Merge pull request #10559 from Discover-/Taxi-BenchmarkingCore/Misc: Implement CMSG_SET_TAXI_BENCHMARK_MODE to toggle PLAYER_FLAGS...
a0a377a Scripts: Fix two issues found by Valgrind==3400== Invalid write of size 8
==3400== at 0x1241C32: instance_ahnkahet::GetInstanceScript(InstanceMap*) const (instance_ahnkahet.cpp:54)
...
==3400== Conditional jump or move depends on uninitialised value(s)
==3400== at 0xB5DEAE: std::tr1::_Hashtable<unsigned long, std::pair<unsigned long const, Creature*>, std::allocator<std::pair<unsigned long const, Creature*> >, std::_Select1st<std::pair<unsigned long const, Creature*> >, std::equal_to<unsigned long>, std::tr1::hash<unsigned long>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, std::tr1::__detail::_Prime_rehash_policy, false, false, true>::_M_find_node(std::tr1::__detail::_Hash_node<std::pair<unsigned long const, Creature*>, false>*, unsigned long const&, unsigned long) const (hashtable.h:830)
==3400== by 0xBDA4CA: std::tr1::_Hashtable<unsigned long, std::pair<unsigned long const, Creature*>, std::allocator<std::pair<unsigned long const, Creature*> >, std::_Select1st<std::pair<unsigned long const, Creature*> >, std::equal_to<unsigned long>, std::tr1::hash<unsigned long>, std::tr1::__detail::_Mod_range_hashing, std::tr1::__detail::_Default_ranged_hash, std::tr1::__detail::_Prime_rehash_policy, false, false, true>::find(unsigned long const&) (hashtable.h:698)
==3400== by 0xBDA5BF: HashMapHolder<Creature>::Find(unsigned long) (ObjectAccessor.h:67)
==3400== by 0xCB5C03: Map::GetCreature(unsigned long) (ObjectAccessor.h:114)
==3400== by 0xB6E6EF: Unit::GetCreature(WorldObject&, unsigned long) (Unit.cpp:13023)
==3400== by 0x10F0790: boss_hydross_the_unstable::boss_hydross_the_unstableAI::Reset() (boss_hydross_the_unstable.cpp:164)
556c478 Tools: Fix compiler warnings
95bdde8 [DB/Errors] Really fix a few more errors.
da693bb Scripts/Halls of Reflection: Fixed accessing uninitialized memory
04707b1 [DB/Errors] Fix a few DB errors.
b5362c5 Script/Ahnkahet: Fix warning
97a9b76 [DB/SAI]: I've Got a Flying Machine! (11390)Fixes #6609
ce7ac33 [DB/SAI] Vile Like Fire!Fixes #6524
99081bc Merge branch 'master' of github.com:TrinityCore/TrinityCore
8e83374 Scripts/GruulsLair: reworked InstanceScriptKnown Issue: position desynch after creature respawn
dc86e87 Scripted/ShadeOfAkama: Some cleanups
a383885 Scripts/AhnKahet: reworked InstanceScript
1e89ae1 Core: Fix warnings and random changes
62c7e30 Scripts/BlackTemple: reworked InstanceScript
7a14e36 Scripts/AzjolNerub: reworked InstanceScript
296da5d Core/Commands: Improved debug moveflags to also send associated opcodes
7e3a52b Scripts/HallsOfLightning: reworked InstanceScript
d74b8f0 DB: Fixup for last file name
75cc4e7 Core/Auras* Fixed unsafe removal of charm auras, it is now safe to remove them inside AI hooks
* Fixes crash in SmartAI::EnterEvadeMode
Closes #8679
8ae8895 Delete 2013_08_19_02_world_sai.sqlRemoved file which broke the repo (tab in name)
6512851 [DB/MISC]: To Rule The Skies (23061) & Onyx Scales
44485a7 Scripts/Icecrown Citadel: Fixed Ice Tomb targeting tanks in phase 3 in Sindragosa encounterCloses #8778
e0f010b Scripts: Random script fixes and code optimizations
7679145 Core: Fix warning
dedeb5f Fix build with gcc. Thanks to McBitter for testing.
5ec0448 [DB/SAI] Rejek: First BloodFixes #6113
0513d9c Core: Fix warnings. Make callback symbols local.
ff3ff68 Update rename for openssl changes
19343dd Fix crashed caused by using openssl from multiple threads simultanously.Note that this doesn't make BigNumber class threadsafe - it never was that way.
2a33709 Fix BigNumber::AsByteArray function by returning Auto_Ptr.Remove mutex from BigNumber class - it didn't do what it was advertised to do - consider using the "locked" array outside of the function in which it was "locked".
8160633 Core: Fix a bug in BigNumber::SetBinary
10fb50a Core: Fix a bug in BigNumber::SetQword
6a55395 Core/Players: Do not add banned characters to _legitCharacters container
9eb01d6 Core: Fix warnings
7dbf68c Scripted/Misc: Remove some whitespace
2b19ba1 Misc: replace Unit::GetPlayer with ObjectAccessor::GetPlayer and some cosmetic changes
c32dbd1 Core/Spells: Fix hunter T7 4P Bonus Closes #8320
da1e466 Core/Misc: Implemented GetObjectScale function
865353e [DB/MISC] Spawn entry for TEMP Blackhoof Village Windmill
6a7ac8c Fix typo in commit 7c7f19228e7a562f225c717215fd34dfcaf5b35a
1ad954e Core/Scripts: Placeholders for instances Maraudon and Dire Maul.It is needed for Random Dungeon Finder credit.
7c7f192 Core/Scripts: Placeholders for instances The Slave Pens and The Underbog.It is needed for Random Dungeon Finder credit.
08133c7 [DB/MISC] Appropriate GO id
0333d22 Core/Scripts: Placeholder for instance Ragefire Chasm.It is needed for Random Dungeon Finder credit.
77f1d3a Core/Misc: Implement CMSG_SET_TAXI_BENCHMARK_MODE to toggle PLAYER_FLAGS_TAXI_BENCHMARK based on arguments. To enable/disable this, call '/script SetTaxiBenchmarkMode(1)' (1 = on, 0 = off). Basically debugs the taxi flight and outputs min, max and avg FPS during flight. Automatically toggled off when flight ends.
7b9f34a Core/Scripts: Placeholder for instance The Stockade.It is needed for Random Dungeon Finder credit.
Correct entry for last encounter in the instance.
c45e665 Core/Spells: move spell resistance calculation into separate function (and some cosmetic changes)Ref #7254
918427d [DB/SAI]: Unleash the Raptors (11147)Fixes #9728
724f843 Merge pull request #10553 from MitchesD/creature_addonDB/Creature: Add missing creature_addon
5a7fb5a DB/Creature: Add missing creature_addon
a4f7f43 DB Error fixes.
99a3df6 [DB/SAI]: Digging Through Bones (10922)Fixes #3231
90dcb2a Scripts/DrakTharonKeep: update Tharon'Ja - update Tharon Ja to BossAI - update one creature - cosmetic npcCloses #10524
c81c198 Core/Spells: Fix deathknight gladiator glove bonus Closes #512
4d260a5 Core/Spells: Fixed warrior T10 4p dps bonusCloses #493
a647d35 Core/Spells: Fixed Execute rolling for procs twice
c52f9aa Core/Spells: Refactored SpellInfo::CalcCastTime() to prevent accidental mod charge losses caused by its incorrect usage
d1bb6da Core/Spells: Fixed cast time mods using two charges on every cast
2ac6380 Core/Auras: Allow preventing whole aura proc default handler from script hooks, just how it is possible for separate effects
0e966c1 SQL: Add missing newline in 5890f95f7cd7a885b667fe9b5da2dceea22b9b81
43c218a [DB/SAI]: Lumber Hack (12050)
e0e2369 Revert "Lumber Hack (12050)"This reverts commit 40ec7f7979cd65fccc6fe74c056688da4c4d47ce.
40ec7f7 Lumber Hack (12050)Fixes #4560
a0ff023 Core/SmartAI: Implement SMART_TARGET_CLOSEST_FRIENDLY.Parameter is distance to search for.
Closes #10521
8c96168 Core/SmartAI: Implement SMART_EVENT_FRIENDLY_HEALTH_PCT. On current clean TDB, there are a total of 106 creatures using
SMART_EVENT_FRIENDLY_HEALTH (non-PCT) which has a flat first parameter, but
only 8 of these use the event correctly (and therefore only 8 of them
actually work).
Closes #10520
22d07db DB/commit: the mining is also useable for 434, thus removed the _335 tag
65e345d DB/Gameobject: Spawn or respawn missing or bad spawned gameobjects "Coldwind Tree" / "Poster Knife"
73f7c11 Core/Spells: implemented SPELL_ATTR0_CU_TRIGGERED_BY_CASTER to correct some triggered spells, which will wrongly triggered by target instead of casterCloses #1972
73be61b SQL: Fix import error
fa10737 DB/Loot: while at it also did the mining veins
5890f95 DB/Loot: Fix some horrible loot definitions for Herbalism, reworked ALL Herbs
e87402d Core/Spells: - corrected structure of SMSG_PET_CAST_FAILED (fixes highlighted action buttons) - simplified spell focus check
783021a Fix non-pch compile
dd171f6 Core/Vehicle: Fix spell focus check for vehicle caster
faa2ec9 Core/SAI: Additions to d0bde02b21241773c908c18adSigned-off-by: Nay <dnpd.dd@gmail.com>
147c7d5 Core/Spells: Fix Rogue T10 4P bonus Closes #4153
de27cfd DB/Spells: Fix Rune StrikeCloses #6514
c18b347 Core/Battleground: Small code optimization
ca78aff SQL: Fix import error
d394d38 DB/Misc: Fix startup error wit eai
5ebe717 Dependencies/bzip: Remove bzip2.c and bzip2recover.c, they are not requiredFixes "warning LNK4006: _main already defined in bzip2recover.obj; second definition ignored"
4c64e40 Core/Spells: Convert hunter "Improved Mend Pet" in spell script Closes #5597 Closes #9006 Closes #10346
eefdcee Core/Spells: Fix client crash on pressing ESC at Using Steam Tonk Controller / Steam Tonk Controller Closes #3010
795e932 Core/Spells: Fix hunter talent "Rapid Killing" Close #1166
2abaf62 Core/Player: Add debug log when SendCanTakeQuestResponse(INVALIDREASON_*) is usedIntent is to find broken quest chains
Requested by Aokromes
3d1c549 DB/EAI: Fix some typos in EAI scriptsWe are updating EAI scripts so the conversion to SAI is correctly done
d0bde02 Core/CreatureAI: Do not remove clone_caster auras on evade (in addition to control_vehicle auras)
54d2b73 Merge pull request #10513 from Discover-/SmartAI-Casted-CreatureOrGoCore/SmartAI: Drop support for SMART_ACTION_SEND_CASTCREATUREORGO. It is...
9e45731 Scripted/ToC5: Add missing stuff in c0bf535e5bc978257952c9bd4e258eed238d1828
80bd5b3 Core/SmartAI: Drop support for SMART_ACTION_SEND_CASTCREATUREORGO. It is unused in the current newest TDB, it never even worked like it should and the exact same purpose of this function is already fulfilled by SMART_ACTION_CALL_CASTEDCREATUREORGO (the correct way).
c0bf535 Core/Spells: Convert "Summon Memory" in spell script
c5ff184 Core/Scripts: Add missing stuff in 0161012c69bb27834328cb408684c482bd530d91
8b08fba Merge pull request #10501 from Discover-/SmartAI-Action-Set-PowerCore/SmartAI: Implement MART_ACTION_SET_POWER, SMART_ACTION_ADD_POWER and SMART_ACTION_REMOVE_POWER (param1 = powertype, para...
0161012 Scripts/ZulFarrak: Convert Witch Doctor Zum'rah from SAI to CppCloses #10508
bd4155b DB: Rename sql file for only 335
c2ae396 DB/Misc: Fix logic fail in f23069e324facd36325e02b92102a571556c4db2
f23069e DB/Misc: Fix startup error
181a3ca Merge pull request #10511 from MitchesD/MobsDB/SAI: Draktharon Keep mobs
e90d18a DB/SAI: Draktharon Keep mobs
482720d Core/BattlegroundAV: Fix team variable type, "if (team == ALLIANCE)" would always return falseRef 33f8c3ead4da07ff024a94b5e8cf0d05c2ebc23a#L4R1626
8acefbf Scripted: Use now override for instance scripts
488128b DB/EAI: Fix unit_field changes, outdated since initial 3.x versions
b33f80a Scripts/Pet: Fix non pch compile
75ca357 Core/SmartAI: Implement SMART_ACTION_SET_POWER, SMART_ACTION_ADD_POWER and SMART_ACTION_REMOVE_POWER (param1 = powertype, param2 = newPower). Required for upcoming EAI to SAI conversion (for ACTION_T_SET_UNIT_FIELD) (only SMART_ACTION_SET_POWER is required for the conversion but might as well do it right when on it).
a6d2faf Core: Fix build(cherry picked from commit 81daef8b2205fca4310720d3186bafca8d75a792)
8aff394 Scripted: Fix non pch build
8c7db6c DB/Spells: Rename LoS for spell Rod of PurificationRef #1972
0a7fa02 DB/SAI: Script NPC Arch Mage XintorCloses #1743
f62a7f7 DB/SAI: Fix quest "Where in the World is Hemet Nesingwary?"Script NPC Archmage Pentarus
Closes #921
13f68e1 DB/GO: Increase radius of Mystery of the Infinity gameobject spellfocusCloses #920
(Quest is still broken; being worked on)
dbb40dd Scripted/Pets: Move some player pets in pet_xxx.cpp
b7d88a3 Merge pull request #9817 from drskull/masterCore/Spell add another condition in AnyGroupedUnitInObjectRangeCheck
eba8c2d Merge pull request #10464 from Discover-/SmartAI-Set-ActiveCore/SmartAI: Allow SMART_ACTION_SET_ACTIVE to take a parameter for on/o...
edf77a4 Merge pull request #10493 from Discover-/SmartAI-Action-Sound-UpdateCore/SmartAI: Rename SMART_ACTION_SOUND's parameters and get rid of an e...
15696e2 DB/SAI: Scripts for Onslaught NPCsCloses #10500
Closes #4741
32c8555 DB/NPCs: Remove AIName from npcs that do not have EAI or SAI scriptsCloses #10483
92fdb7a DB/SAI: Fix quest Jormuttar is Soo Fat...Scripts/Spells: Script spell Bear Flank Master
Closes #10484
d39d9f8 DB/SAI: Fix quest "Tokens of the Descendants"Closes #10437
011c7d4 DB/SAI: Fix quest "Blood in the Water"Closes #10398
d520a4e DB/Cond: Fix taking of 8280 Securing the Supply Lines for horde playersCloses #10371
879725e DB/SAI: Fix infinite spawn in quest "You Are Rakh'Likh, Demon"Closes #10361
6c51dea DB/SAI: Fix quest The Conquest PitOriginal fix by @shlomi1515
Closes #10332
Ref #3913
bd21205 Core/SmartAI: Rename SMART_ACTION_SOUND's parameters and get rid of an error that shouldn't be there. The method it calls doesn't take CreatureTextRange (enum) in consideration, but a boolean called onlySelf.
27a433d DB: Fix a db startup error
85fd2bd DB/SAI: Fix a typo in a SAI script, fixes quest Bring Me The Egg!Closes #10415
9f05cf7 DB/NPCs: Because of some silly reason there are NPCs with AIName 0
2e898b1 DB/SAI: Script IthariusCloses #10401
1534ef2 DB/NPCs: Correct faction of Seeping OozeCloses #10375
ced20dc DB/SAI: Fix quest Magic Carpet RideInitial Magic Carpet Ride fix: 820ce262779c05a95649f
Closes #10328
3ebcab3 DB/SAI: Fix quest From Whence They CameCloses #6525
55e695b DB/SAI: Fix quests See You on the Other Side (12121) and Jin'arrak's End (12152)Closes #10480
Closes #4552
8fd248e DB/SAI: Fix quest Strengthen the Ancients (12092)Closes #10478
f65906d DB/SAI: Fix quest Fueling the Project (11715)Closes #10477
b375c4a DB/Misc: Add Dregbar Runebrand pathingCloses #10476
e613aad DB/SAI: Fix quest Killing Two Scourge With One SkeletonCloses #10475
8f50e30 Scripts/DrakTharonKeep: update TrollgoreCloses #10453
Signed-off-by: joschiwald <joschiwald@online.de>
fa9144f DB: Fix startup errors
090f348 Scripting/Sethekk Halls: Move Boss Anzu from EAI to CPP and some cleanup.
9d4c2c5 Core/SmartAI: Implement SMART_TARGET_CLOSEST_ENEMY (25)Required for upcoming EAI to SAI conversion.
Closes #10482
1e8fd64 Core: Fix non pch build
0667e89 Scripts/DrakTharonKeep: add some spellscripts, add yells to novos, and do some cosmetic changes
f4815fb Scripting/Mana Tombs: Move Yor scripting from EAI to CPP.
f5e4fd6 Scripting: Moved Lord Valthalak from EAI to CPP. Moved all Blackrock Instances to Blackrock Mountain Dir.
33f8c3e Core/Battleground: Get rid of dinamic casts BattlegroundXX outside Battleground scope by implementing generic functions (2/2) - CheckAchievementCriteriaMeet
b056656 Core/Battleground: Get rid of dinamic casts BattlegroundXX outside Battleground scope by implementing generic functions (1/2) - HandleQuestComplete, CanActivateGO and IsSpellAllowed
f245124 Core/Misc: Avoid heap allocation when performing some RBAC checks
d87b0ff Core/SmartAI: Allow SMART_ACTION_SET_ACTIVE to take a parameter for on/off (true/false). Required for upcoming EAI to SAI conversion (https://github.com/Discover-/EventAI-to-SmartAI)
d76d3de DB/Creature: Fix db startup error in c8bfb9cf4df450497263d94869880db6eb7f3c73 by Kirkhammett
c8bfb9c DB&Scripts/Icecrown: Fix quest The Last Line Of Defense and script Argent CannonsCloses #998
Closes #10460
3197d82 DB/SAI: Fix quest "Into the Wild Green Yonder"Closes #10456
8d575bf DB/Misc: Misc for Naz'Anak: The Forgotten DepthsProper phasing for zone 4522; a few missing spawns, some missing scripts etc... etc..
Closes #10447
Closes #10438
fee62f5 DB/Commands: Re-add help text for reload gameobject_questender
75e6c40 Core/Misc: Rename some no name enums
01396ac SQL: Rename sql in correct date
75b4b05 Scripts/HoR: Major changes:- Fixed Intro timers
- Fixed mobs aggro
- Fixed General's shield trow
- Added Jaina / Sylvannas / Lich King escape event
Closes #10303
Closes #2505
Closes #9865
ebaee13 Server/Player: Fix a logical mistake in ApplyEquipCooldownThanks Joschiwald
8dfaf27 Merge pull request #10245 from Mihapro/masterCore/SmartScripts
0253a76 Battlegrounds/IC: Fix achiev Back Door Jobgiggity
Closes #10043
Closes #3776
Closes #3194
8dccf61 Merge pull request #10445 from Discover-/Cooldown-ExploitCore/Items: Fix an exploit where players would be able to reset the cool...
1bf1f95 Merge pull request #10455 from Discover-/Battleground-Reinterpret-CastsCore/Misc: Implement reinterpret casts for all battleground classes and ...
233a154 Core/Misc: Update const casts of ToBattlegroundX to use reinterpret_cast as well.
7f744de Core/Misc: Implement reinterpret casts for all battleground classes and use them.
dc8385f DB/Items: Remove unlimited charges from Jillian's Tonic of StonebloodCloses #10444
a71fcee DB/Schema: Rename _questrelation tables to _queststarter and _involvedrelation to _questender, for creature and gameobject
2f33888 Scripts/Commands: Fix compile (v3)
2bd4049 Scripts/Commands: Fix compile (v2)
df6e665 Scripts/Commands: Fix compile
d24bb95 Core: Random changes
8af6e6c Merge branch 'master' of github.com:TrinityCore/TrinityCore
ccdba08 Core/Items: Correct randomProperlyId type when reading to/from DBRef #10446
f37d049 Core/Commands: Add .npc info more infos for unit_flags
38cddb4 Core/Commands: Add .npc info mechanicImmuneMask infos
71233c3 DB/Misc: Fix db startup errors
0070b64 DB/SAI: Fix Redridge Mystic spamBy Malcrom
1dcd027 Merge pull request #9761 from xjose93/ImproveLog11Core/Logs: Added functions GetMapAreaAndZoneString() and GetCoordsMapAreaAndZoneString()
4bb4937 Core/Items: Fix an exploit where players would be able to reset the cooldown of items to the equip cooldown (30 seconds) when unequipping, equipping and then relogging.
79dd722 DB/SAI: Free at last!Closes #10417
9a377f1 DB/SAI: Meridith the MermaidenCloses #10418
3d4b8a2 DB/SAI: Script Witch Doctor Zum'rahCloses #10404
96469e3 DB/Quests: Fix The Nightmare Manifests / Hope Within the Emerald Nightmare / The Boon of Remulos / The Keeper's Favor/Walking LegendCloses #10410
Closes #4902
Closes #10407
Closes #10406
5164caa DB/Misc: Fix area 4522 spawnscloses #1945
20a61b6 Core/Creatures: DoTs and self damage will no longer reset time since last damage taken for stopping creature from evading
5ae86ee Fixed compile
ac10589 Core/Misc: Fixed some issues found by Coverity Scan
ab6be8c Core/Battlegrounds: Fixed error with counting AB owned nodes (and warning fixes)
f042173 Core/Battleground: fix type mismatchRef #10320
bab04cc Core/Spells: Fix try for logic fail in 4ba3c2e51df0485449a4bd01f162faa719334be9
a7d876e Config: Change ProcessPriority default to 0 (Normal)On Linux, superuser (root) is required to set a process high priority and we shouldn't force that.
(It's already set to 0 (Normal) in worldserver\Master.cpp and authserver\Main.cpp)
0d0baf0 Scripts/DrakTharonKeep: fix copy paste failCloses #10402
7165fd7 Merge pull request #9862 from Ric101/condition_creature_typeCore/Conditions: Implement CONDITION_CREATURE_TYPE - 24
1b0c604 Revert "CMake/MSVC: Fix VS 2013 compile -- Zm500 hack is no longer required"This reverts commit ca7377369f603081259adea0ba49cb03e74e609f.
394b2c6 Scripts/OnyxiasLair: Fix a crash in boss_onyxiaCloses #10393
Note: this just fixes the crash, not the issues the script has (a.k.a rewrite this)
d26afd7 Core/Spells: Fixed crashes happening with spells that had their dbc targets overridenCloses #10395
a91e42f SQLs: Rename filesFrom now on, 3.3.5 (master branch)-only SQL files will be suffixed with _335 in the filename
1bb3c4a Misc: Fix warnings and buildCloses #10396
3b78023 Scripts/DrakTharonKeep: Update King Dred to use eventsCloses #10385
Signed-off-by: joschiwald <joschiwald@online.de>
d868f9d Scripts/DrakTharonKeep: reworked InstanceScript
4559e99 Docs: Prettify READMEThanks to Guybrush for the help
3330239 Servers: Fix typo
e3f7be1 Servers: Enable UseProcessors and ProcessPriority settings to be used on Linux
f71d894 Servers: Fix some code style issues in world and authserver
62918e9 DB/SAI: Fix quest The Fate Of The FallenCloses #9363
Thanks to @gaut for the initial script
Signed-off-by: Nay <dnpd.dd@gmail.com>
009317d SQLS/Old: Move some misplaced files
a5a696f DB/GOs: Spawns of Discarded Soul Crystal for "The Fate Of The Fallen"Closes #
Signed-off-by: Nay <dnpd.dd@gmail.com>
47c8c1e Core/Spells: Health Funnel now always damages the warlock, even if it does not heal the pet because it's already at full health. Previously it would display the 'Miss' effect on the owner of the pet.Fixes #9991
cf7e783 Scripts/Spells: Fixed typo in 7678800a9372f9234f0bf29459b46a8514dc59f2
7678800 Scripts/Spells: simplified "spell_dk_presence"
b4d2796 Core/Spells: moved Improved Paladin Auras and Aura Mastery into SpellScriptsCloses #205
Closes #5163
Closes #6809
Closes #7408
Closes #9587
34fc72c DB/Conditions: Fix gossip condition for Bat Handler Camille <Bat Handler>Closes #10240
f94eb92 Core/Spells: fix uninitialised value
e9750a4 Core/Spells: move Death Knights Presences into SpellScripts, fix possible issue after spec change, and fix some startup errorsCloses #10354
c4a1ad2 Merge pull request #10342 from joschiwald/spellinfo_correctionsCore/Spells: operate spell correction on SpellInfo store instead of dbc ...
8a87ab0 Merge pull request #10331 from joschiwald/spell_proc_ranksCore/Spells: allow to use ranked spells in `spell_proc_event` table (lik...
e6a146a Core/Spells: allow to use ranked spells in `spell_proc_event` table (like in `spell_proc` table)
fecc926 Merge pull request #10350 from Ascathor/masterCore/Commands: Added the rank id to .pinfo for guild data
5a9810e Core/Commands: Added the rank id to .pinfo for guild data
516e33f Merge pull request #10327 from joschiwald/spell_talent_ranksCore/Spells: load spell ranks for talents from dbc
9fb45ef Core/Spells: load spell ranks for talents from dbc
1039046 Core/Spells: add some logs for loading spell_script_names
a522be8 Merge pull request #10336 from joschiwald/spellscripts5Scripts/Spells: backport some SpellScripts from 4.3.4 branch
99c67c1 Scripts/Spells: backport some SpellScripts from 4.3.4 branch- Fix Earth Shield
- Fix Necrotic Touch
- Fix Reflective Shield
Closes #9145, #9163, #9665
00f3b01 Core/Spells: operate spell correction on SpellInfo store instead of dbc (picked from 77b85b2ea0aec6cd3e545e60e46ac60eebb11e47)
e11714e Scripts/Onyxia's Lair: Fixed movement during flight phase and set proper InhabitTypeCloses #10335
ce79e3a Core/Auras: Implemented Aura::GetScriptByName.
a3aa3f6 Scripts/VH: Refactor commit 999843d
999843d Scripts/VH: fix for violet hold's activation crystalsCloses #10129
5463f21 Merge pull request #10323 from joschiwald/spellranksCore/Spells: use SpellInfo class to get spellrank node instead of SpellMgr helpers
f5a44b1 Merge pull request #10320 from joschiwald/battlegroundCore/Battleground: use generic function to relocate players to closest g...
cd2c33c Merge pull request #10319 from joschiwald/castsCore/Misc: replace (Player*) casts with ToPlayer()
3a4e3a5 Core/Creatures: Removed vendor item check during loading, MAX_VENDOR_ITEMS should apply to filtered list of items depending on player opening the vendor, not global list sizeCloses #10330
3d6b88f Fixed compile warnings
2d6a488 Core/Spells: use SpellInfo class to get spell rank instead of SpellMgr helpers
380cf5d Core/Misc: replace (Player*) casts with ToPlayer()
ddb1183 Core/Battleground: use generic function to relocate players to closest graveyard
bf100ff Scripts/Icecrown: Fix a double function call typo in npc_margrave_dhakarThanks Josh
7ce340b Core/Dependencies: Update utf8-cpp to version 2.3.4
d04bb0d Merge pull request #10317 from FireEmerald/masterCollection of Feedback-PatchFixes / 20.07.2013
d2c1a4f Collection of Feedback-PatchFixes / 20.07.2013Including sql codestyle updates and check for accuracy. (one by one)
by FireEmerald / Thx @DDuarte for the base pull request.
Including:
- DB/Spell: Update: Correct Spell Power Coefficient (107.43%) for Tranquility | by lendan (@6232)
- DB/LOS: Add: Ignore LOS for Ignite Horde Siege Engine | by dr-j (@6718)
- DB/SmartAI: Update: Correct casted spell by Defias Rogue Wizard | by Rochet2 (@9976)
- DB/Quest: Fix: Bloody Imp-ossible! (10924) | by Kirkhammett (@10276)
- DB/Quest: Fix: Mistcaller Yngvar (14102) / Add missing event script and conditions. | (@3563)
- DB/SmartAI: Update: Give quest credit for The Ring of Blood: The Final Challenge (9977) | by JunkyBulgaria (@7724)
- DB/Waypoints: Add: Missing waypoints for Mmmrrrggglll | by Hobbilis (@9602)
- DB/Conditions: Add: Missing conditions for Displacing Temporal Rift | by FireEmerald
0ce5fcf DB/Gameobject: Proper instance entrance portals for DTK and Gundrak south.
1ac4f0a SQL: Rename in correct name
0b9a8cc Core/Misc: Change creatures and gameobject phasemask from 16 to 32 bitsSigned-off-by: Nay <dnpd.dd@gmail.com>
ebd9090 DB/NPCs: Fix Margrave Dhakar equipment
0691a43 Scripts/Icecrown: Use guid instead of cached Creature* to avoid crashes in npc_margrave_dhakar
ca73773 CMake/MSVC: Fix VS 2013 compile -- Zm500 hack is no longer requiredSigned-off-by: Nay <dnpd.dd@gmail.com>
ff01602 Scripts/Icecrown: Fix code style and use "best practices" on previous commit (c536ba510)
c536ba5 Scripts/Icecrown: Fix quest The Flesh Giant ChampionCloses #9040
Closes #10294
7dd26ce Merge pull request #10306 from joschiwald/devourer_of_soulsScripts/ForgeOfSouls: move "Mirrored Soul" into SpellScripts
d52ce57 Scripts/ForgeOfSouls: move "Mirrored Soul" into SpellScripts
922fba3 Merge pull request #10305 from joschiwald/koralonScripts/VaultOfArchavon/Koralon: Fix Meteor Fists
06d54ba Scripts/VaultOfArchavon/Koralon: Fix Meteor Fists
eca90db Scripts/Commands/Arena: Replace a call of GetPlayerNameByGUID by GetCharacterNameData
1c2213d DB/Condition: Correct target of spell 63126Fix by dr-j closes #10281
4ba3c2e Misc: Some cleanup
d40725f SQL: Fix sql import error
8cec422 DB/Gossip: Add some missing gossip.
8462a09 DB/Gossip: Added missing gossip for Royal Historian Archesonus. Removed cpp script.
83a31ea DB/Conditions: Fix error in a previous commit.
e00fc19 Core/SmartScripts
6fe47e7 Core/Conditions: Missing grid search support for CONDITION_CREATURE_TYPE
6820ca8 Core/Conditions: Implement CONDITION_CREATURE_TYPE - 24
4c041ea Core/Spells: Added fuzzyEq(_range, 0) condition to AnyGroupedUnitInObjectRangeCheckFix #189
Signed-off-by: dr.skull <dr.skull@centrum.sk>
170e93e Core/Logs: Added functions GetMapAreaAndZoneString() and GetCoordsMapAreaAndZoneString().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment