code-review-checklist.md

Implementation

• Does this change accomplish what it's supposed to do?
• Could this solution be simplified?
• Could the maintainability or readability be improved?
• Does similar functionality already exist in the code? If so, why is it not used?
• Does the solution use hard-coded variables? If so, could they be changed?
• Are there any best practices that could substantially improve this code?

Logic errors

• Can you think of any use case in which the code doesn't behave as intended?
• Can you think of any inputs or external events that break the code?

Error handling

• Is error handling done correctly?
• Should logging be added or removed?
• Are error messages user-friendly?
• Is the code testable?

Testing

• Is the code testable?
• Do existing tests cover the code change?
• Are there some edge cases that should be tested in addition?
• Was this feature tested manually?

External opinions

• Will this change impact external teams?
• Do you think a specific expert should look over the change before it is merged?