good_change_checklist.md

1. Is the problem well defined
   1. why is the problem occurring
   2. what is the outcome of the problem
   3. why hasn't it come up earlier
   4. what are possible solutions
2. can you reproduce it in automated manner
   1. write automated test reproducing error
   2. if a problem is rather statistical, can you measure changes in a very fast and repeatable way
   3. describe manual tests if they were performed
3. can you check if the change doesn't break anything else
   1. check if other automated test are exhaustive
4. write change in best way
   1. DRY (if applies)
   2. does the change follows single responsibility principle?
   3. is the code readable
   4. is the code self documenting
      1. interfaces should have documentation and description if required
      2. are all names self explaining
   5. is the code as simple as possible (not overly long and over engineered)
   6. is the code following style guides
5. have you thought about performance implications
   1. if a change can introduce problem, have you measured it and included in MR
6. has the code been reviewed and discussed
   1. does MR/issue contains responds for question 1
   2. does it contain future improvements and possible weak points
7. have you introduced any changes to this list