Created
September 25, 2021 00:27
-
-
Save FrenchBen/479367337a2fc2029e9eee97c3e9968e to your computer and use it in GitHub Desktop.
helm make test with golang-ci v1.42.1 and using `revive`
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make test | |
GO111MODULE=on go build -trimpath -tags '' -ldflags '-w -s -X helm.sh/helm/v3/internal/version.metadata=unreleased -X helm.sh/helm/v3/internal/version.gitCommit=9fafb4ad6811afb017cc464b630be2ff8390ac63 -X helm.sh/helm/v3/internal/version.gitTreeState=clean -X helm.sh/helm/v3/pkg/lint/rules.k8sVersionMajor=1 -X helm.sh/helm/v3/pkg/lint/rules.k8sVersionMinor=22 -X helm.sh/helm/v3/pkg/chartutil.k8sVersionMajor=1 -X helm.sh/helm/v3/pkg/chartutil.k8sVersionMinor=22' -o '/go/src/helm/bin'/helm ./cmd/helm | |
go: downloading github.com/Masterminds/semver/v3 v3.1.1 | |
go: downloading github.com/docker/docker v17.12.0-ce-rc1.0.20200618181300-9dc6525e6118+incompatible | |
.... | |
GO111MODULE=on golangci-lint run | |
GO111MODULE=on golangci-lint run | |
pkg/helmpath/lazypath_unix.go:13: File is not `gofmt`-ed with `-s` (gofmt) | |
pkg/helmpath/home_unix_test.go:13: File is not `gofmt`-ed with `-s` (gofmt) | |
pkg/helmpath/lazypath_unix_test.go:13: File is not `gofmt`-ed with `-s` (gofmt) | |
pkg/chartutil/validate_name.go:43:19: errorf: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (revive) | |
errInvalidName = errors.New(fmt.Sprintf( | |
"invalid release name, must match regex %s and the length must not be longer than 53", | |
validName.String())) | |
pkg/chartutil/validate_name.go:49:29: errorf: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (revive) | |
errInvalidKubernetesName = errors.New(fmt.Sprintf( | |
"invalid metadata name, must match regex %s and the length must not be longer than 253", | |
validName.String())) | |
internal/experimental/registry/client.go:243:15: errorf: should replace errors.New(fmt.Sprintf(...)) with fmt.Errorf(...) (revive) | |
return nil, errors.New( | |
fmt.Sprintf("manifest does not contain minimum number of descriptors (%d), descriptors found: %d", | |
minNumDescriptors, numDescriptors)) | |
pkg/cli/environment_test.go:40:3: var-naming: don't use leading k in Go names; struct field kAsUser should be asUser (revive) | |
kAsUser string | |
^ | |
pkg/cli/environment_test.go:41:3: var-naming: don't use leading k in Go names; struct field kAsGroups should be asGroups (revive) | |
kAsGroups []string | |
^ | |
pkg/cli/environment_test.go:42:3: var-naming: don't use leading k in Go names; struct field kCaFile should be caFile (revive) | |
kCaFile string | |
^ | |
cmd/helm/completion_test.go:50:4: errorf: should replace t.Error(fmt.Sprintf(...)) with t.Errorf(...) (revive) | |
t.Error(fmt.Sprintf("Unexpected directive ShellCompDirectiveNoFileComp when completing '%s'", cmdName)) | |
^ | |
cmd/helm/completion_test.go:53:4: errorf: should replace t.Error(fmt.Sprintf(...)) with t.Errorf(...) (revive) | |
t.Error(fmt.Sprintf("Did not receive directive ShellCompDirectiveNoFileComp when completing '%s'", cmdName)) | |
^ | |
cmd/helm/install.go:258:2: sigchanyzer: misuse of unbuffered os.Signal channel as argument to signal.Notify (govet) | |
signal.Notify(cSignal, os.Interrupt, syscall.SIGTERM) | |
^ | |
cmd/helm/upgrade.go:191:4: sigchanyzer: misuse of unbuffered os.Signal channel as argument to signal.Notify (govet) | |
signal.Notify(cSignal, os.Interrupt, syscall.SIGTERM) | |
^ | |
make: *** [Makefile:116: test-style] Error 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment