Created
October 21, 2021 16:05
-
-
Save ImaginaryDevelopment/cf34358be033704c88655f41652c320c to your computer and use it in GitHub Desktop.
Code cleaning comparison
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onNotifyAcknowledgedPositions() { | |
const companyState = this.memberState; | |
if (companyState && | |
companyState['BUY'] && companyState['SELL'] && | |
(isFalsy(companyState['BUY'].addedRequests) || companyState['BUY'].addedRequests.length === 0) && | |
(isFalsy(companyState['BUY'].updatedRequests) || companyState['BUY'].updatedRequests.length === 0) && | |
(isFalsy(companyState['BUY'].deletedRequests) || companyState['BUY'].deletedRequests.length === 0) && | |
(isFalsy(companyState['BUY'].addedComments) || companyState['BUY'].addedComments.length === 0) && | |
(isFalsy(companyState['BUY'].deletedComments) || companyState['BUY'].deletedComments.length === 0) && | |
(isFalsy(companyState['SELL'].addedRequests) || companyState['SELL'].addedRequests.length === 0) && | |
(isFalsy(companyState['SELL'].updatedRequests) || companyState['SELL'].updatedRequests.length === 0) && | |
(isFalsy(companyState['SELL'].deletedRequests) || companyState['SELL'].deletedRequests.length === 0) && | |
(isFalsy(companyState['SELL'].addedComments) || companyState['SELL'].addedComments.length === 0) && | |
(isFalsy(companyState['SELL'].deletedComments) || companyState['SELL'].deletedComments.length === 0) | |
) { | |
this.memberState.showAlert = false; | |
} | |
} | |
onNotifyAcknowledgedPositions2() { | |
const companyState = this.memberState; | |
const buyState: IMSBuy = companyState && companyState.BUY; | |
const sellState = companyState && companyState.SELL; | |
if (isFalsy(companyState) || isFalsy(buyState) || isFalsy(sellState)) { return; } | |
const isFalsyOrEmpty = (item: any[] | undefined) => isFalsy(item) || item.length === 0; | |
let emptyish = [ | |
buyState.addedRequests, | |
buyState.updatedRequests, | |
buyState.deletedRequests, | |
buyState.addedComments, | |
buyState.deletedComments, | |
sellState.addedRequests, | |
sellState.updatedRequests, | |
sellState.deletedRequests, | |
sellState.addedComments, | |
sellState.deletedComments, | |
].map(isFalsyOrEmpty).reduce((x, y) => x && y); | |
if (emptyish) { | |
this.memberState.showAlert = false; | |
} | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment