asterisk_comments.txt

addons/chan_mobile.c:1814:/* XXX this does not work with the do_sco_listen() thread (which also bind()s
addons/chan_mobile.c:3584:		/* XXX this channel probably does not need to be associated with this pvt */
addons/chan_mobile.c:3716:			/* XXX gnu specific strerror_r is assummed here, this
addons/chan_mobile.c:3912:			/* XXX volume change requested, we will just
addons/chan_ooh323.c:114:	.bridge = ast_rtp_instance_bridge,		/* XXX chan unlocked ? */
addons/chan_ooh323.c:3919:	/* XXX Deal with Video */
agi/eagi-test.c:91:				/* XXX Process the audio with sphinx here XXX */
apps/app_dahdibarge.c:163:		/* XXX Make sure we're not running on a pseudo channel XXX */
apps/app_dahdibarge.c:291:		/* XXX Should prompt user for pin if pin is required XXX */
apps/app_dial.c:1370:					/* XXX this should be saved like AST_CONTROL_CONNECTED_LINE for !single || caller_entertained */
apps/app_dial.c:1375:					/* XXX this should be saved like AST_CONTROL_CONNECTED_LINE for !single || caller_entertained */
apps/app_dial.c:1669:			/* XXX can we have both, or they are mutually exclusive ? */
apps/app_dial.c:1726:		/* XXX should we set status to DENY ? */
apps/app_dial.c:1736:		/* XXX should we set status to DENY ? */
apps/app_dial.c:1737:		/* XXX what about the privacy flags ? */
apps/app_dial.c:2644:			if (theapp && !res) { /* XXX why check res here ? */
apps/app_externalivr.c:99:/* XXX the parser in gcc 2.95 gets confused if you don't put a space between 'name' and the comma */
apps/app_externalivr.c:381:	if (!(entry = ast_calloc(1, sizeof(*entry) + strlen(filename) + 10))) /* XXX why 10 ? */
apps/app_followme.c:1179:	/* XXX TODO: Reinsert the db check value to see whether or not follow-me is on or off */
apps/app_jack.c:204:	/* XXX Hard coded 8 kHz */
apps/app_jack.c:977:	/* XXX TODO */
apps/app_meetme.c:2621:		/* XXX Make sure we're not running on a pseudo channel XXX */
apps/app_minivm.c:1901:	/* XXX This file needs to be in temp directory */
apps/app_queue.c:2513:			S_COR(qe->chan->caller.id.number.valid, qe->chan->caller.id.number.str, "unknown"),/* XXX somewhere else it is <unknown> */
apps/app_queue.c:2515:			S_COR(qe->chan->connected.id.number.valid, qe->chan->connected.id.number.str, "unknown"),/* XXX somewhere else it is <unknown> */
apps/app_queue.c:5187:			/* XXX future changes should beware of this assumption!! */
apps/app_queue.c:5283:	/* XXX In all other cases, we use the membername, but since this affects all queues, we cannot */
apps/app_sms.c:402:		/* XXX 0 is invalid ? */
apps/app_sms.c:884:						/* XXX Why aren't we using ast_strptime here? */
apps/app_sms.c:1375:			/* XXX depending on what we are.. */
apps/app_sms.c:2045:	res = h.err;                            /* XXX */
apps/app_voicemail.c:6118:			/* XXX We should really give a prompt too short/option start again, with leave_vm_out called only after a timeout XXX */
apps/app_voicemail.c:7000:	if (cmd == 't' || cmd == 'S') /* XXX entering this block with a value of 'S' is probably no longer possible. */
apps/app_voicemail.c:7084:		/* XXX possible imap issue, should category be NULL XXX */
apps/app_voicemail.c:7293:				/* XXX Optimization for the future.  When we encounter a single bad extension,
apps/app_voicemail.c:7697:		/* XXX Why are we playing messages above, and then playing the same language-specific stuff here? */
apps/app_voicemail.c:9475:					ast_fileexists(prefile, NULL, NULL) > 0 ? /* XXX always true ? */
apps/app_voicemail.c:9866:	/* XXX This is, admittedly, some pretty horrendous code.  For some
cdr/cdr_pgsql.c:260:				/* XXX Might want to handle dates, times, and other misc fields here XXX */
cdr/cdr_sqlite3_custom.c:268:	/* XXX This seems awful arbitrary... */
cel/cel_pgsql.c:263:					/* XXX Might want to handle dates, times, and other misc fields here XXX */
cel/cel_sqlite3_custom.c:269:	/* XXX This seems awful arbitrary... */
channels/chan_agent.c:500:		/* XXX check what is this exactly */
channels/chan_agent.c:1119:		/* XXX Is this really all we copy form the originating channel?? */
channels/chan_dahdi.c:8507:					/* XXX This section needs much more error checking!!! XXX */
channels/chan_dahdi.c:12691:			/* XXX Waiting to hear back from Jim if these should be adjustable XXX */
channels/chan_gtalk.c:209:	/* XXX TODO native bridging is causing odd problems with DTMF pass-through with
channels/chan_gtalk.c:904:	/* XXX this is a blocking action.  We send a STUN request to the server
channels/chan_h323.c:1410:#if 0 /* XXX Port channel variables functionality from chan_sip XXX */
channels/chan_h323.c:1533:#if 0 /* XXX Port channel variables functionality from chan_sip XXX */
channels/chan_h323.c:2237:					return NULL;	/* XXX: Hmmm... Why to setup context if we drop connection immediately??? */
channels/chan_h323.c:2401:		/* XXX to be completed
channels/chan_h323.c:3233:	/* XXX Deal with Video */
channels/chan_iax2.c:2019:	/* XXX Prolly don't need locks here XXX */
channels/chan_iax2.c:2035:	/* XXX Prolly don't need locks here XXX */
channels/chan_iax2.c:3292:	/* XXX Ideally we should figure out why an error occurred and then abort those
channels/chan_iax2.c:3516:							iax2_queue_frame(callno, &fr); /* XXX */
channels/chan_iax2.c:4058:		/* XXX should really just empty until when > 0.. */
channels/chan_iax2.c:10182:						/* XXX Maybe we should handle its ack to us, but then again, it's probably outdated anyway, and if
channels/chan_jingle.c:646:		/* XXX We should really stun for this one not just go with externip XXX */
channels/chan_mgcp.c:748:	/* XXX Should schedule retransmission XXX */
channels/chan_mgcp.c:822:	/* XXX find tail. We could also keep tail in the data struct for faster access */
channels/chan_mgcp.c:1985:	/* XXX This could block for a long time, and block the main thread! XXX */
channels/chan_mgcp.c:2194:	/* XXX We break with the "recommendation" and send our IP, in order that our
channels/chan_mgcp.c:2836:						/* XXX delete this one
channels/chan_mgcp.c:2875:							/* XXX cleanup if we think we are offhook XXX */
channels/chan_mgcp.c:2981:			/* XXX Redundant?  We should already be playing dialtone */
channels/chan_mgcp.c:3457:						/* XXX Need to check for state up ??? */
channels/chan_mgcp.c:3458:						/* XXX Need a way to indicate the current call, or maybe the call that's waiting */
channels/chan_mgcp.c:3480:						/* XXX - What do we do now? */
channels/chan_mgcp.c:3554:				/* XXX MUST queue this frame to all subs in threeway call if threeway call is active */
channels/chan_mgcp.c:3800:		/* XXX THIS IS COMPLETELY HOSED */
channels/chan_mgcp.c:4148:				/* XXX Should we really check for uniqueness?? XXX */
channels/chan_mgcp.c:4217:							/* XXX Should find a way to clean up our memory */
channels/chan_mgcp.c:4258:				/* XXX Should we really check for uniqueness?? XXX */
channels/chan_mgcp.c:4271:					/* XXX potential issue due to reload */
channels/chan_mgcp.c:4338:						/* XXX Should find a way to clean up our memory */
channels/chan_mgcp.c:4418:	/* XXX Is there such thing as video support with MGCP? XXX */
channels/chan_misdn.c:3793:	/* XXX Is this supposed to not do anything? XXX */
channels/chan_misdn.c:4324:	/* XXX Wow, this does... a whole lot of nothing... XXX */
channels/chan_misdn.c:6840:	/* XXX Modify this callback to support Asterisk controlling the length of DTMF */
channels/chan_oss.c:316:	.duplex = M_UNSET,			/* XXX check this */
channels/chan_oss.c:702:	/* XXX can be simplified returning &ast_null_frame */
channels/chan_oss.c:831:	console_video_start(get_video_desc(c), c); /* XXX cleanup */
channels/chan_oss.c:853:		/* XXX we could default to 'dsp' perhaps ? */
channels/chan_oss.c:1043:	if (!o->owner && !o->hookstate) { /* XXX maybe only one ? */
channels/chan_oss.c:1070:	if (!o->owner) {			/* XXX maybe !o->hookstate too ? */
channels/chan_oss.c:1464:		/* XXX we could default to 'dsp' perhaps ? */
channels/chan_oss.c:1465:		/* XXX should cleanup allocated memory etc. */
channels/chan_phone.c:242:	/* XXX Modify this callback to let Asterisk support controlling the length of DTMF */
channels/chan_phone.c:352:	/* XXX Is there anything we can do to really hang up except stop recording? */
channels/chan_phone.c:808:		/* XXX Internet Phone Jack does not handle the 4-byte VAD frame properly! XXX 
channels/chan_phone.c:856:		/* XXX Switching formats silently causes kernel panics XXX */
channels/chan_phone.c:929:	/* XXX Do something XXX */
channels/chan_phone.c:956:					/* XXX This should probably be justified better XXX */
channels/chan_sip.c:1616:	.bridge = ast_rtp_instance_bridge,			/* XXX chan unlocked ? */
channels/chan_sip.c:1961:	/* XXX The entity attribute is currently set to the peer name associated with the
channels/chan_sip.c:3097:		/* XXX Todo - if we have proxy port, don't do SRV */
channels/chan_sip.c:4528:	/* XXX IMPORTANT: Anytime you add a new parameter to be updated, you
channels/chan_sip.c:4556:	/* XXX note that sip_cfg.regcontext is both a global 'enable' flag and
channels/chan_sip.c:5264:	/* XXX TODO: get flags directly from peer only as they are needed using dialog->relatedpeer */
channels/chan_sip.c:5289:	/* XXX TODO: get fields directly from peer only as they are needed using dialog->relatedpeer */
channels/chan_sip.c:5515:		/* XXX fails on possible deadlock */
channels/chan_sip.c:7081:	/* XXX Why are we choosing a codec from the native formats?? */
channels/chan_sip.c:8835:	p->lastrtprx = p->lastrtptx = time(NULL); /* XXX why both ? */
channels/chan_sip.c:9239:					/* XXX Would it be reasonable to drop the DSP at this point? XXX */
channels/chan_sip.c:10060:	/* XXX bug here if string has been trimmed to sizeof(hostname) */
channels/chan_sip.c:10517:	p->do_history = 0;	/* XXX do we need it ? isn't already all 0 ? */
channels/chan_sip.c:10540:	/* XXX the structure may be dirty from previous usage.
channels/chan_sip.c:10802:	/* XXX Convert \n's to \r\n's XXX */
channels/chan_sip.c:11285:	/* XXX We should not change properties in the SIP dialog until
channels/chan_sip.c:11353:		/* XXX note, Video and Text are negated - 'true' means 'no' */
channels/chan_sip.c:11394:			if (debug) {  /* XXX should I use tdest below ? */
channels/chan_sip.c:11473:		/* XXX don't think you can have ptime for video */
channels/chan_sip.c:11477:		/* XXX don't think you can have ptime for text */
channels/chan_sip.c:11649:	p->lastrtprx = p->lastrtptx = time(NULL); /* XXX why both ? */
channels/chan_sip.c:11679:	/* XXX this function can encounter memory allocation errors, perhaps it
channels/chan_sip.c:11727:	/* XXX Hardcode "NR" as the m reason for now. This should perhaps be changed
channels/chan_sip.c:11797:		if ( *e == '<' ) { /* XXX the spec says it must not be in <> ! */
channels/chan_sip.c:11921:	const char *l = NULL;	/* XXX what is this, exactly ? */
channels/chan_sip.c:11922:	const char *n = NULL;	/* XXX what is this, exactly ? */
channels/chan_sip.c:13642:			enum sip_auth_type code = p->options ? p->options->auth_type : PROXY_AUTH; /* XXX force 407 if unknown */
channels/chan_sip.c:13896:	/* XXX This could block for a long time XXX */
channels/chan_sip.c:14053:		/* XXX This could block for a long time XXX */
channels/chan_sip.c:14419:	if (strcasecmp(p->randdata, keys[K_NONCE].s) || p->stalenonce) { /* XXX it was 'n'casecmp ? */
channels/chan_sip.c:15341:	/* XXX Why is this done in get_destination? Isn't it already done?
channels/chan_sip.c:15836:			/* XXX add error checking */
channels/chan_sip.c:15840:				;	/* XXX add error checking */
channels/chan_sip.c:15948:	/* XXX what about p->prefs = peer->prefs; ? */
channels/chan_sip.c:15966:	/* XXX is this correct before a successful auth ? */
channels/chan_sip.c:16026:			/* XXX this takes the name from the caller... can we override ? */
channels/chan_sip.c:16108:	/* XXX here tries to map the username for invite things */
channels/chan_sip.c:18317:	/* XXX indentation preserved to reduce diff. Will be fixed later */
channels/chan_sip.c:19317:	/* XXX We hard code our qop to "auth" for now.  XXX */
channels/chan_sip.c:20722:		/* XXX todo: try to save the extra call */
channels/chan_sip.c:21192:				/* XXX Locking issues?? XXX */
channels/chan_sip.c:21716:	if( (sep = strchr(event, ';')) ) {	/* XXX bug here - overwriting string ? */
channels/chan_sip.c:22392:			ptr = ast_skip_blanks(ptr); /* XXX maybe unnecessary ? */
channels/chan_sip.c:23680:		/* XXX - what to we put in CEL 'extra' for attended transfers to external systems? NULL for now */
channels/chan_sip.c:24615:		event = (char *) eventheader;		/* XXX is this legal ? */
channels/chan_sip.c:25508:		return s->fd; /* XXX whether reconnection is ever necessary here needs to be investigated further */
channels/chan_sip.c:25827:		/* XXX TODO The scheduler usage in this module does not have sufficient
channels/chan_sip.c:27278:		/* XXX should unregister ? */
channels/chan_sip.c:27760:		/* XXX May need to revisit the final argument; does the realtime DB store whether
channels/chan_sip.c:27875:			sip_register(reg_string, 0); /* XXX TODO: count in registry_count */
channels/chan_skinny.c:155:	SKINNY_CODEC_G726_32 = 82, /* XXX Which packing order does this translate to? */
channels/chan_skinny.c:404:/* XXX When do we need to use this? */
channels/chan_skinny.c:1030:/* XXX This is the combined size of the variables above.  (len, res, e)
channels/chan_skinny.c:1496:			/* XXX I have no idea what the buttons look like on these. */
channels/chan_skinny.c:1506:			/* XXX I don't know if this is right. */
channels/chan_skinny.c:1731:		return AST_FORMAT_G726_AAL2; /* XXX Is this right? */
channels/chan_skinny.c:1752:	case AST_FORMAT_G726_AAL2: /* XXX Is this right? */
channels/chan_skinny.c:2280:	/* XXX okay, I don't quite know what this is, but here's what happens (on a 7960).
channels/chan_skinny.c:2288:	/* XXX the value here doesn't seem to change anything.  Must be higher than 0.
channels/chan_skinny.c:2593:		/* XXX I wanted to get the size of the array dynamically, but that wasn't wanting to work.
channels/chan_skinny.c:3786:#if 1	/* XXX This code is probably not necessary */
channels/chan_skinny.c:4585:		/* XXX Need to figure out how to handle CFwdNoAnswer */
channels/chan_skinny.c:4958:		/* XXX MUST queue this frame to all lines in threeway call if threeway call is active */
channels/chan_skinny.c:4961:		/* XXX This seriously needs to be fixed */
channels/chan_skinny.c:5117:		/* XXX determine the best way to pull off a conference.  Meetme? */
channels/chan_skinny.c:6125:		/* XXX determine the best way to pull off a conference.  Meetme? */
channels/chan_skinny.c:6157:		/* XXX How is this different from CONFRN? */
channels/chan_skinny.c:6347:		/* XXX umm...okay?  Why do I care? */
channels/chan_skinny.c:6350:		/* XXX I have no clue what this is for, but my phone was sending it, so... */
channels/chan_unistim.c:922:	unsigned int tick = 0;	/* XXX what is this for, anyways */
channels/chan_unistim.c:1473:			/* XXX Deal with IP authentication */
channels/chan_unistim.c:2585:	usleep(150000);			 /* XXX Less than perfect, blocking an important thread is not a good idea */
channels/chan_vpb.cc:1756:	/* XXX Modify this callback to let Asterisk control the length of DTMF */
channels/console_board.c:112:	b->v_h = b->p_h * 10; /* XXX 10 times larger */
channels/console_board.c:182:		int c = b->text[i] - 32;	/* XXX first 32 chars are not printable */
channels/console_gui.c:272:		if (env->in == NULL)	/* XXX should not happen - decoder not ready */
channels/console_gui.c:341:#ifdef notyet /* XXX for future implementation */
channels/console_gui.c:379:		if (env->gui->bd_msg) /* XXX not strictly necessary ... */
channels/console_gui.c:638:	/* XXX this should be extended for clicks on different audio device markers */
channels/console_gui.c:729:	/* XXX for future implementation
channels/console_gui.c:757:#ifdef notyet /* XXX for future implementations */
channels/console_gui.c:1065:	gui->kb_output = KO_MESSAGE;	/* XXX temp */
channels/console_gui.c:1072:	/* XXX load image */
channels/console_gui.c:1083:		/* XXX hardwired constants - 3 rows of 32 chars */
channels/console_video.c:380:	dev->last_frame = now; /* XXX actually, should correct for drift */
channels/console_video.c:422:	/* XXX this should be a codec callback */
channels/console_video.c:518:		/* XXX rtp_callback ?
channels/console_video.c:649:	/* XXX img_convert is deprecated, and does not do rescaling, PiP not supported */
channels/console_video.c:652:#else /* XXX replacement */
channels/console_video.c:673:#endif /* XXX replacement */
channels/console_video.c:905:		struct timespec t = { 0, 50000000 };	/* XXX 20 times/sec */
channels/console_video.c:925:		/* XXX here we should always check for events,
channels/console_video.c:1181:	/* XXX the string is allocated but NEVER deallocated,
channels/h323/ast_h323.cxx:249:	/* XXX: Probably we need to crash here */
channels/h323/ast_h323.cxx:800:	/* XXX Is it possible to have this information for outgoing calls too? XXX */
channels/h323/ast_h323.cxx:2491:			/* XXX Maybe we should fire a new thread to attempt to re-register later and not kill asterisk here? */
channels/sig_analog.c:3190:					/* XXX This section needs much more error checking!!! XXX */
channels/sig_analog.h:269:	/* XXX: Option Variables - Set by allocator of private structure */
channels/sig_analog.h:307:	/* XXX: All variables after this are internal */
channels/sig_ss7.c:466:	/* XXX the use of state here seems questionable about matching up with the linkset channels */
channels/sig_ss7.c:1198:				/* XXX Call ptr should be passed up from libss7! */
channels/sig_ss7.c:1226:					/* XXX FAR and FAA used for something dealing with transfers? */
channels/sig_ss7.c:1234:						/* XXX We seem to be leaking the isup call structure here. */
channels/sip/include/sip.h:466:		/* XXX maybe this is the same as AUTH_NOT_FOUND */
channels/sip/include/sip.h:762:	/* XXX Do we need to unref socket.ser when the request goes away? */
channels/sip/include/sip.h:1174:/* XXX field 'name' must be first otherwise sip_addrcmp() will fail, as will astobj2 hashing of the structure */
channels/sip/include/sip.h:1751:} sip_options[] = {	/* XXX used in 3 places */
channels/sip/reqresp_parser.c:2102:	/* XXX It would be really nice if we could just use parse_uri_full() here
channels/vcodecs.c:528:	/* XXX check whether these are supported */
channels/vcodecs.c:636:			} else {	/* XXX to be completed */
channels/vcodecs.c:651:		/* XXX to do: if not aligned, fix sbit and ebit,
channels/vcodecs.c:666:/* XXX We only drop the header here, but maybe we need more. */
channels/vcodecs.c:682:	return fbuf_append(b, data, len, 0, 0);	/* XXX no bit alignment support yet */
channels/vcodecs.c:792:		if (i - start < 4)	/* XXX too short ? */
channels/vcodecs.c:1229:	/* XXX call dec_init() ? */
codecs/codec_gsm.c:90:			/* XXX what's the point here! we should just work
codecs/codec_gsm.c:98:		/* XXX maybe we don't need to check */
codecs/codec_gsm.c:126:	/* XXX We should look at how old the rest of our stream is, and if it
codecs/codec_ilbc.c:128:	/* XXX We should look at how old the rest of our stream is, and if it
codecs/codec_lpc10.c:95:/* XXX note lpc10_encode() produces one bit per word in bits[] */
codecs/codec_lpc10.c:122:		INT32 bits[LPC10_BITS_IN_COMPRESSED_FRAME]; /* XXX see note */
codecs/codec_lpc10.c:167:	INT32 bits[LPC10_BITS_IN_COMPRESSED_FRAME];	/* XXX what ??? */
codecs/codec_speex.c:70:static float pp_agc_level = 8000; /* XXX what is this 8000 ? */
codecs/codec_speex.c:187:	/* XXX fout is a temporary buffer, may have different types */
codecs/codec_speex.c:239:	/* XXX We should look at how old the rest of our stream is, and if it
codecs/codec_speex.c:303:			/* XXX what now ? format etc... */
codecs/codec_speex.c:357:	.buf_size = BUFFER_SAMPLES * 2, /* XXX maybe a lot less ? */
codecs/codec_speex.c:385:	.buf_size = BUFFER_SAMPLES * 2, /* XXX maybe a lot less ? */
config.guess:1387:    if (strncmp(un.version, "V1", 2) == 0) { /* XXX is V1 correct? */
formats/format_g723.c:47:	/* XXX is this ignored ? */
formats/format_g723.c:84:	/* XXX there used to be a check s->fr means a read stream */
formats/format_g729.c:58:		if (res && (res != 10))	/* XXX what for ? */
formats/format_h263.c:95:	s->fr.samples = fs->lastts;	/* XXX what ? */
formats/format_h263.c:170:	return offset;	/* XXX totally bogus, needs fixing */
formats/format_h264.c:76:		len = BUF_SIZE;	/* XXX truncate */
formats/format_h264.c:159:	return offset; /* XXX totally bogus, needs fixing */
formats/format_pcm.c:46:/* #define REALTIME_WRITE */	/* XXX does it work at all ? */
formats/format_pcm.c:463:/* XXX check this, probably incorrect */
formats/format_pcm.c:604:	/* XXX better init ? */
formats/format_wav_gsm.c:443:	/* XXX this might fail... if the input is a multiple of MSGSM_FRAME_SIZE
formats/format_wav_gsm.c:471:		update_header(s->f); /* XXX inefficient! */
formats/format_wav_gsm.c:491:	/* XXX ideally, should round correctly */
funcs/func_channel.c:431:		/* XXX - should we be forcing this here? */
funcs/func_odbc.c:1554:/* XXX need to revise usecount - set if query_lock is set */
include/asterisk/channel.h:650:/* XXX not ideal to evaluate x twice... */
include/asterisk/cli.h:189:/* XXX the parser in gcc 2.95 gets confused if you don't put a space
include/asterisk/manager.h:217:/* XXX the parser in gcc 2.95 gets confused if you don't put a space
main/app.c:178:	/* XXX Merge with full version? XXX */
main/app.c:574:		offset = *offsetms * 8; /* XXX Assumes 8kHz */
main/asterisk.c:190:/* XXX tmpdir is a subdir of the spool directory, and no way to remap it */
main/asterisk.c:1290:			/* XXX This will only work if it is the first command, and I'm not sure fixing it is worth the effort. */
main/asterisk.c:3522:			break; /* XXX Should we exit() here? XXX */
main/astobj2.c:406:	/* XXX maybe consistency check on arguments ? */
main/astobj2.c:428:	/* XXX maybe consistency check on arguments ? */
main/astobj2.c:440:	/* XXX maybe consistency check on arguments ? */
main/astobj2.c:644:		start = i = -1;		/* XXX this must be fixed later. */
main/audiohook.c:695:				/* XXX IGNORE FAILURE */
main/cdr.c:1088:			/* Destination information */ /* XXX privilege macro* ? */
main/channel.c:144:#if 0	/* XXX AstData: ast_callerid no longer exists. (Equivalent code not readily apparent.) */
main/channel.c:352:#if 0	/* XXX AstData: ast_callerid no longer exists. (Equivalent code not readily apparent.) */
main/channel.c:435:#if 0	/* XXX AstData: ast_callerid no longer exists. (Equivalent code not readily apparent.) */
main/channel.c:3204:	if (sizeof(int) == 4) {	/* XXX fix timeout > 600000 on linux x86-32 */
main/channel.c:3234:		*ms = 0;	/* XXX use 0 since we may not have an exact timeout. */
main/channel.c:3479:/* XXX never to be called with ms = -1 */
main/channel.c:3898:		/* XXX why not the same for frames from the channel ? */
main/channel.c:4182:					/* XXX what does this do ? */
main/channel.c:4816:		res = 0;	/* XXX explain, why 0 ? */
main/channel.c:4845:			res = 0;	/* XXX explain, why 0 ? */
main/channel.c:4902:		/* XXX Handle translation of video codecs one day XXX */
main/channel.c:5001:			/* XXX must explain this code */
main/channel.c:6165:	/* XXX Is this always correct?  We have to in order to keep MACROS working XXX */
main/channel.c:6443:	/* XXX This operation is a bit odd.  We're essentially putting the guts of
main/channel.c:6686:	/* XXX What about blocking, softhangup, blocker, and lock and blockproc? XXX */
main/channel.c:6738:		/* XXX - should we try to lock original->_bridge here? */
main/channel.c:7170:		/* XXX do we want to pass on also frames not matched above ? */
main/cli.c:293:		/* XXX reload has multiple error returns, including -1 on error and 2 on success */
main/cli.c:919:					S_OR(c->data, ""),	/* XXX different from verbose ? */
main/cli.c:1315:		/* XXX remember to handle the optional "off" */
main/cli.c:2071:	/* XXX check that usage and command are filled up */
main/cli.c:2205:		/* XXX watch out, should stop to the non-generator parts */
main/cli.c:2284:	/* XXX put a NULL in the last argument, because some functions that take
main/cli.c:2395:		strcat(matchstr, " "); /* XXX */
main/cli.c:2402:		/* XXX repeated code */
main/config.c:1227:				return 0;	/* XXX is this correct ? or we should return -1 ? */
main/config.c:1231:			return 0;	/* XXX is this correct ? or we should return -1 ? */
main/config.c:1240:			return 0;	/* XXX is this correct ? or we should return -1 ? */
main/config.c:1285:		/* XXX otherwise what ? the default return is 0 anyways */
main/data.c:370:	/* XXX avoid allocating a new data node for searching... */
main/db1-ast/btree/bt_split.c:408:			/* XXX mpool_free(t->bt_mp, r->pgno); */
main/db1-ast/btree/bt_split.c:644:			isbigkey = 0;		/* XXX: not really known. */
main/db1-ast/mpool/mpool.c:172:	u_int flags;				/* XXX not used? */
main/dsp.c:812:		/* XXX So then why is MF_GSIZE defined as 120? */
main/editline/chared.c:438:	el->el_state.inputmode		= MODE_INSERT; /* XXX: save a default */
main/editline/chared.c:475:	el->el_state.inputmode		= MODE_INSERT; /* XXX: save a default */
main/editline/common.c:160:#ifdef notdef			/* XXX */
main/editline/config.guess:1337:    if (strncmp(un.version, "V1", 2) == 0) { /* XXX is V1 correct? */
main/editline/el.c:138:	ch_reset(el);		/* XXX: Do we want that? */
main/editline/el.c:301:#if 0				/* XXX */
main/editline/el.c:370:#endif /* XXX */
main/editline/read.c:270:				/* XXX: In the future to run a user function */
main/editline/readline.c:1608:		/* XXX notice there is no range checking of ``c'' */
main/editline/readline.c:1657:	/* XXX - int -> char conversion can lose on multichars */
main/editline/refresh.c:109:		if (oldv == el->el_refresh.r_cursor.v) { /* XXX */
main/editline/term.c:271:	{ "MT", "Has meta key" },			/* XXX? */
main/editline/term.c:286:private FILE *term_outfile = NULL;	/* XXX: How do we fix that? */
main/editline/term.c:410:		(void) strcpy(*str, cap);	/* XXX strcpy is safe */
main/editline/term.c:417:						/* XXX strcpy is safe */
main/editline/term.c:443:					/* XXX strcpy is safe */
main/editline/tty.c:574:	/* XXX: Maybe reset to an initial state? */
main/features.c:4780:				/* XXX Maybe we could do something with packets, like dial "0" for operator or something XXX */
main/features.c:4794:				goto std;	/* XXX Ick: jumping into an else statement??? XXX */
main/features.c:7067:				S_COR(cur->chan->caller.id.number.valid, cur->chan->caller.id.number.str, ""),	/* XXX in other places it is <unknown> */
main/features.c:7069:				S_COR(cur->chan->connected.id.number.valid, cur->chan->connected.id.number.str, ""),	/* XXX in other places it is <unknown> */
main/file.c:177:		/* XXX If they try to send us a type of frame that isn't the normal frame, and isn't
main/file.c:214:	char buf[4096];	/* XXX make it lerger. */
main/file.c:231:		/* XXX handle partial writes */
main/file.c:277:/* XXX need a better algorithm */
main/file.c:1068:	/* XXX need to fix this - we should just do the fopen,
main/frame.c:143:	if (!s->len || ast_tvzero(f->delivery) || ast_tvzero(s->delivery)) {	/* XXX really ? */
main/frame.c:271:	s->f.samples = len * s->samplesperbyte;	/* XXX rounding */
main/frame.c:793:	/* XXX We should probably print one each of voice and video when the format changes XXX */
main/frame.c:1521:	/* XXX Still need speex, and lpc10 XXX */	
main/image.c:43:/* XXX Why don't we just use the formats struct for this? */
main/loader.c:140:/* XXX: should we check for duplicate resource names here? */
main/loader.c:709:			reload_classes[i].reload_fn();	/* XXX should check error ? */
main/logger.c:1208:		result = ast_str_set_va(&buf, BUFSIZ, fmt, ap); /* XXX BUFSIZ ? */
main/manager.c:961:				/* XXX need to document which fields it is protecting */
main/manager.c:1854:			/* XXX We may wish to trim whitespace from the strings. */
main/manager.c:2900:		/* XXX maybe put an upper bound, or prevent the use of 0 ? */
main/manager.c:2929:	/* XXX should this go inside the lock ? */
main/manager.c:3646:	ast_cli_command(fd, cmd);	/* XXX need to change this to use a FILE * */
main/manager.c:5096:/* XXX see if can be moved inside the function */
main/manager.c:6096:		/* XXX Now request method are hardcoded in A2 */
main/pbx.c:2369:		return 0x40000;	/* XXX make this entry go last... */
main/pbx.c:2487:			return (mode == E_MATCHMORE) ? lp > ld : 1; /* XXX should consider '!' and '/' ? */
main/pbx.c:2509:			end = strchr(pattern+1, ']'); /* XXX should deal with escapes ? */
main/pbx.c:2818:				/* XXX keep status = STATUS_NO_CONTEXT ? */
main/pbx.c:2970:			/* XXX keep status = STATUS_NO_CONTEXT ? */
main/pbx.c:4923:			if (pos < buflen - 1) {	/* XXX maybe error otherwise ? */
main/pbx.c:4944:		/* XXX and now what ? */
main/pbx.c:4961:		/* XXX the original code used the existing priority in the call to
main/pbx.c:4981:		int pos = 0;		/* XXX should check bounds */
main/pbx.c:5144:				error = 1; /* XXX disable message */
main/pbx.c:5172:						found = 1; /* XXX disable message */
main/pbx.c:5188:						found = 1; /* XXX disable message */
main/pbx.c:6366:/* XXX not verified */
main/pbx.c:6743:		/* XXX note- an empty context is not printed */
main/pbx.c:6772:				/* XXX maybe make this conditional, if p != e ? */
main/pbx.c:6954:	struct ast_str *vars = ast_str_alloca(BUFSIZ * 4); /* XXX large because we might have lots of channel vars */
main/pbx.c:7368:/* XXX this does not check that multiple contexts are merged */
main/pbx.c:8597:			errno = EEXIST;	/* XXX do we care ? */
main/pbx.c:8598:			return 0; /* XXX should we return -1 maybe ? */
main/pbx.c:9742:		args.lang = (char *)chan->language;	/* XXX this is const */
main/say.c:3809:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:3845:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:4041:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:4066:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:4244:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:4269:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:4402:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:4437:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:4592:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:4747:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:4772:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:4968:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:4993:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:5178:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:5408:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:5878:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:5903:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:6164:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:6189:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:7569:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:7594:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:7772:				/* XXX As emphasized elsewhere, this should the native way in your
main/say.c:7808:				/* XXX As emphasized elsewhere, this should the native way in your
main/stun.c:400:	for (retry = 0; retry++ < 3;) {	/* XXX make retries configurable */
main/stun.c:437:		/* XXX pass sizeof(rsp_buf) - 1 in the size, because stun_handle_packet might
main/tcptls.c:199:						/* XXX Probably should do a gethostbyname on the hostname and compare that as well */
main/translate.c:339:	/* XXX hmmm... check this below */
main/xmldoc.c:1807:		/* XXX Don't modify ast_str internals manually */
pbx/pbx_config.c:139:		if (isblank(*p) /* XXX order is important */ && !in_blank) {
pbx/pbx_config.c:362:	/* XXX original overwrote argv[3] */
pbx/pbx_config.c:367:		return CLI_FAILURE; /* XXX malloc failure */
pbx/pbx_config.c:426:			/* XXX locking ? */
pbx/pbx_config.c:488:			/* XXX locking on c ? */
pbx/pbx_config.c:503:				/* XXX lock e ? */
pbx/pbx_config.c:717:	/* XXX the code here is quite loose, a pathname with .conf in it
pbx/pbx_config.c:799:		/* XXX do we need this ? */
pbx/pbx_config.c:1121:		/* XXX skip first three words 'dialplan' 'add' 'ignorepat' */
pbx/pbx_config.c:1230:						/* XXX do i stop on c, or skip it ? */
pbx/pbx_config.c:1243:	} else if (a->pos == 5) { /* XXX check this */
pbx/pbx_dundi.c:524:	/* XXX Would be nice to be more random XXX */
pbx/pbx_dundi.c:3632:				/* XXX Would be nice to have a way to poll/select here XXX */
pbx/pbx_dundi.c:3633:				/* XXX this is a busy wait loop!!! */
pbx/pbx_lua.c:897:	/* XXX do we ever need to destroy this? pbx_config does not */
res/ael/ael.flex:93:static char pbcstack[400];	/* XXX missing size checks */
res/ael/ael.flex:102:static char pbcstack2[400];	/* XXX missing size checks */
res/ael/ael.flex:111:static char pbcstack3[400];	/* XXX missing size checks */
res/ael/ael.flex:124:char *prev_word;		/* XXX document it */
res/ael/ael.tab.c:3043:    { /* XXX word_list maybe ? */
res/ael/ael.tab.c:3119:		/* XXX need to advance the pointer or the loop is very inefficient */
res/ael/ael.tab.c:3299:		/* XXX original code had @2 but i think we need @5 */
res/ael/ael.tab.c:3412:		(yyval.pval) = npval2(PV_CASE, &(yylsp[(1) - (4)]), &(yylsp[(3) - (4)])); /* XXX 3 or 4 ? */
res/ael/ael.tab.c:3432:		(yyval.pval) = npval2(PV_PATTERN, &(yylsp[(1) - (4)]), &(yylsp[(4) - (4)])); /* XXX@3 or @4 ? */
res/ael/ael.tab.c:3545:		prev_word=0; /* XXX sure ? */ }
res/ael/ael.y:130:/* XXX lr changes */
res/ael/ael.y:254:/* XXX this matches missing arguments, is this desired ? */
res/ael/ael.y:486:			{reset_parencount(parseio->scanner);} word RP statement { /* XXX word_list maybe ? */
res/ael/ael.y:519:		/* XXX need to advance the pointer or the loop is very inefficient */
res/ael/ael.y:578:/* XXX please document the form of jumptarget */
res/ael/ael.y:589:		/* XXX original code had @2 but i think we need @5 */
res/ael/ael.y:598:/* XXX application_call_head must be revised. Having 'word LP { ...'
res/ael/ael.y:638:		$$ = npval2(PV_CASE, &@1, &@3); /* XXX 3 or 4 ? */
res/ael/ael.y:646:		$$ = npval2(PV_PATTERN, &@1, &@4); /* XXX@3 or @4 ? */
res/ael/ael.y:693:		prev_word=0; /* XXX sure ? */ }
res/ael/ael_lex.c:843:static char pbcstack[400];	/* XXX missing size checks */
res/ael/ael_lex.c:852:static char pbcstack2[400];	/* XXX missing size checks */
res/ael/ael_lex.c:861:static char pbcstack3[400];	/* XXX missing size checks */
res/ael/ael_lex.c:874:char *prev_word;		/* XXX document it */
res/ais/evt.c:53:/* XXX HACK */
res/res_agi.c:1692:		/* XXX argv should be deprecated in favor of passing agi_argX paramaters */
res/res_agi.c:2136:		/* XXX this doesn't belong here, but in the 'say' module */
res/res_agi.c:2254:	/* XXX EAGI FIXME XXX */
res/res_calendar.c:1332:	/* XXX Eventually we will support unnamed calendars, so if we don't find one, we parse
res/res_calendar_caldav.c:445:		/* XXX Technically you can check RELATED to see if the event fires from the END of the event
res/res_calendar_caldav.c:491:	/* XXX Parse the calendar blurb for recurrence events in the time range,
res/res_calendar_exchange.c:498:		"        <cal:alldayevent dt:dt=\"boolean\">0</cal:alldayevent>\n" /* XXX need to add event support for all day events */
res/res_calendar_icalendar.c:299:		/* XXX Technically you can check RELATED to see if the event fires from the END of the event
res/res_fax_spandsp.c:530:	/* XXX do we need to lock here? */
res/res_fax_spandsp.c:567:	/* XXX do we need to lock here? */
res/res_jabber.c:4218:	/* XXX Does Matt really want everyone to use his personal address for tests? */ /* XXX yes he does */
res/res_musiconhold.c:1138:	/* XXX This isn't correct.  Args is an application for custom mode. XXX */
res/res_musiconhold.c:1424:						/* XXX This code is impossible to reach */
res/res_musiconhold.c:1951:	/* XXX This check shouldn't be required if module ref counting was being used
res/snmp/agent.c:47:#define HAVE_DMALLOC_H 0	/* XXX we shouldn't do this */
utils/extconf.c:3125:	/* XXX may need locking on the channel ? */
utils/extconf.c:4547:		return 0x40000;	/* XXX make this entry go last... */
utils/extconf.c:4803:			return (mode == E_MATCHMORE) ? lp > ld : 1; /* XXX should consider '!' and '/' ? */
utils/extconf.c:4821:			end = strchr(pattern+1, ']'); /* XXX should deal with escapes ? */
utils/extconf.c:5033:			/* XXX keep status = STATUS_NO_CONTEXT ? */
utils/extconf.c:5446:			errno = EEXIST;	/* XXX do we care ? */
utils/extconf.c:5447:			return 0; /* XXX should we return -1 maybe ? */
utils/extconf.c:6080:				data = strsep(&stringp, ""); /* XXX what for ? */
utils/extconf.c:6179:		/* XXX remove previous contexts from same registrar */
utils/extconf.c:6188:		/* XXX remove contexts with the same name */