Jesse Warden JesterXL

Elm Review Rules Architectural Design Record

Status

Proposed

Context

While Elm has an idiomatic way to do things regarding the architecture, there are various ways to use types and code. Much like JavaScript and Python have linting rules, Elm does as well to help enforce best practices that the team deems important.

	app "AoC Day 2 - Rock Paper Scissors"
	packages { pf: "https://github.com/roc-lang/basic-cli/releases/download/0.1.1/zAoiC9xtQPHywYk350_b7ust04BmWLW00sjb9ZPtSQk.tar.br" }
	imports [pf.Stdout, pf.Path, pf.File, pf.Task]
	provides [main] to pf

	# saysYeah = \yup ->
	# "\(yup) yeah!"

	# expect saysYeah "cactus" == "cactus yeah!"

	class Ok {
	constructor(data) {
	this.data = data
	this._type = "Ok"
	this.then.bind(this)
	this.match.bind(this)
	}

	then(func) {
	const result = func(this.data)

	const binaryBody = await res.buffer()
	const body = binaryBody.toString('binary')
	debug("first 255 of string body: %s", body.substr(0, 255))
	const { isAnError, parsedResult } = verifyNotJSONErrorMessage(body)
	debug("isAnError: %o", isAnError)
	if(isAnError) {
	return failure({ isAnError, parsedResult })
	}
	const boundaryHeader = res.headers.get('content-type')
	debug("boundaryHeader: %s", boundaryHeader)

	module Main exposing (main)

	import Browser
	import Html exposing (Html, button, div, text)
	import Html.Events exposing (onClick)
	import Html.Attributes exposing (style)
	import Draggable


	type alias Model =


	type applicationLoadBalancerEvent = {
	path: string,
	httpMethod: string,
	queryStringParameters: option<string>,
	body: option<string>
	}

	type header = (string, string)

	// keep in mind this does NOT do paths
	const getOr = (defaultValue, prop, object) =>
	(object ?? {})?.[prop] ?? defaultValue

	local module = {}

	function module.puzzleInput()
	return [[light red bags contain 1 bright white bag, 2 muted yellow bags.
	dark orange bags contain 3 bright white bags, 4 muted yellow bags.
	bright white bags contain 1 shiny gold bag.
	muted yellow bags contain 2 shiny gold bags, 9 faded blue bags.
	shiny gold bags contain 1 dark olive bag, 2 vibrant plum bags.
	dark olive bags contain 3 faded blue bags, 4 dotted black bags.
	vibrant plum bags contain 5 faded blue bags, 6 dotted black bags.

	local module = {}

	local Puzzle1Input = require(script.Parent.Puzzle1Input)
	local LuaFP = require(script.Parent.Parent.LuaFP)
	local map, filter, some, reduce = LuaFP.collection.map, LuaFP.collection.filter, LuaFP.collection.some, LuaFP.collection.reduce
	local repr = require(workspace.repr)

	local function containsCount(targetLetter, list)
	return reduce(
	function(acc, letter)