Created
August 15, 2014 13:57
-
-
Save John-Lin/1a63c06d6f6b1ae7b379 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> 1. why not just using Pull Request, i think it's more convenient than email | |
> the patch | |
> | |
> PR is open and anyone logged in GitHub can see it and leave comments for it | |
> or discussion. | |
I think that it's matter of taste. Linux kernel, one of the biggest | |
and most successful OSS projects, uses a way to email patches. I don't | |
think that there is the _best_ development process for everyone. | |
Our mailing list is open and anyone can see patches from other | |
developers and comment on them. | |
> 2. If i write a patch, how do i know if the patch is accepted or rejected. | |
> | |
> if accepted, maybe i can see it from github, but for rejected, how do i | |
> know and how do i know why | |
I try to comment all the patches. But I sometimes overlook or take | |
time. Please poke me if you feel that your patch is not reviewed. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment