Skip to content

Instantly share code, notes, and snippets.

@Kasahs
Created June 4, 2019 11:36
Show Gist options
  • Save Kasahs/63f51cc6a5cae028826f4bf907732126 to your computer and use it in GitHub Desktop.
Save Kasahs/63f51cc6a5cae028826f4bf907732126 to your computer and use it in GitHub Desktop.
a template for creating pull requests

Description

Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes #<asana-id>

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change requires a data migration
  • This change requires indexing

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Manual testing locally
  • Manual Testing on staging
  • Unit tests locally
  • Integration tests locally
  • Integration tests in integration environment
  • Regression Tests
  • Penetration Tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment