-
We Code Review after each story, and I use them as a place to have discussions where we have the opportunity to learn from one another.
-
I trust the other developers on my team, especially since they will have more context on their own work, so anything I suggest is merely a suggestion, and so I always "Approve" my github review. I give them the benefit of the doubt that if I point out something, it is more than likely I misunderstood.
-
It is entirely reasonable for people to use their discretion to disagree with or defer my suggestions for improvement.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- | |
Complete feature detection for ES modules. Covers: | |
1. Static import: import * from './foo.js'; | |
2. Dynamic import(): import('./foo.js').then(module => {...}); | |
Demo: http://jsbin.com/tilisaledu/1/edit?html,output | |
Thanks to @_gsathya, @kevincennis, @rauschma, @malyw for the help. | |
--> |