-
We Code Review after each story, and I use them as a place to have discussions where we have the opportunity to learn from one another.
-
I trust the other developers on my team, especially since they will have more context on their own work, so anything I suggest is merely a suggestion, and so I always "Approve" my github review. I give them the benefit of the doubt that if I point out something, it is more than likely I misunderstood.
-
It is entirely reasonable for people to use their discretion to disagree with or defer my suggestions for improvement.
-
Mistakes are something to thank people for making, so we can all vicariously learn from them.
-
Solving problems is hard, and after they are already solved, sometimes it is easier to see improved solutions we can all learn from.
-
Everyone has room to improve, and everyone has experience and knowledge worth learning from.
-
All feedback is precious and to be respected, even when it could have been better expressed.
-
Inaccurate review comments tell me my code does not communicate intent well enough.
-
Review comments are suggestions, and as long as I have diligently responded, I will rely on my judgement and discretion.
-
I feel free to disagree with or defer suggested improvements or changes, as long as I state that I am consciously doing so.
-
Since we all have collective ownership of the code, other developers are free to expand or improve upon my work at their discretion. This includes immediately implementing their own suggested improvements if I deferred or disagreed. If they want to put in their own effort to try something out, we will both learn something valuable.