MilesChou

Laravel Redis "reconnect-without-retry" reproducer

This reproducer demonstrates an inconsistency in Laravel's framework code:

• Illuminate\Database\Connection reconnects and retries on lost connection — caller sees a transparent recovery.
• Illuminate\Redis\Connections\PhpRedisConnection reconnects on lost connection but immediately throws — the rebuilt \Redis client is wasted, the caller still sees an exception.

It also shows that phpredis' built-in OPT_MAX_RETRIES / backoff options (integrated into Laravel via #54191) don't help here. Those options retry connection-loss detected before sending a command (via redis_check_eof); they don't engage on the "command already sent, read timed out" path that this reproducer simulates.

What this reproducer does

MilesChou

<?php

// See https://github.com/web-token/jwt-framework/tree/v1.3.9 for about JWT

function createAppleIDSecret()
{
    $privateKey = file_get_contents('/path/to/your/key');
    $keyId = 'key_id';
    $teamId = 'team_id';
    $clientId = 'client_id';

MilesChou

# Docker files
.dockerignore
Dockerfile

# Git files
.git

# Node files
node_modules

MilesChou

<?php

$totalScore = 0;

foreach ($exam as $value) {
    foreach ($value->mocks as $mock) {
        foreach ($mock->items as $item) {
            $totalScore += (int)$item->ext->score;
        }
    }

MilesChou

<?php

if (!function_exists('mysql_connect')) {
    function mysql_connect($host, $username, $password) {
        mysqli_connect($host, $username, $password);
    }
}

mysql_connect('127.0.0.1', 'root', 'password');

MilesChou

<?php

class Client
{
    public $greetingRules = [];

    public function __construct()
    {
        $this->greetingRules[] = new MorningGreeting();
        $this->greetingRules[] = new AfternoonGreeting();

MilesChou

Code review

程式碼審查

類型

• Pair Programming (直接的做法 - 時間短 - feedback 慢 - 高密度)
• 可使用在新人加入時

MilesChou

#!/usr/bin/make -f
IMAGE := $(shell basename $(shell pwd))
VERSION := latest

.PHONY: all build rebuild shell run

# ------------------------------------------------------------------------------

all: build

MilesChou

// ignore import

public class TestFragment extends Fragment
{

	@Override
	public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState)
	{
		return inflater.inflate(R.layout.fragment, container, false);
	}

MilesChou

<?php

/**
 * class 教學
 *
 * class 全域需注意的重點：
 * 1.全域：跟function一樣，一經宣告後，任何地方皆可使用。
 * 2.不可重載：跟function一樣，一經宣告後，不可再宣告同名的class
 *
 * 建立class的重點：