- Make sure you are aware of the problem/feature.
- Don't be rude, be polite.
- Give suggestions and make clear why do you think you suggestion is better than the current approach.
- Don't point out just the bad things, tell about what do you think is great as well.
- Make it part of your daily workflow. (use github notifications)
- http://www.dein.fr/2015-02-18-maslows-pyramid-of-code-review.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker run -p 8080:80 -v ./myconfig.conf:/etc/nginx/nginx.conf nginx |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const express = require('express'); | |
const cors = require('cors'); | |
const axios = require('axios'); | |
const app = express(); | |
app.use(cors()); | |
app.use(express.json()); | |
console.log( 'running server') | |
app.get('/api', async (req, res) => { |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{ | |
"name": "spriter", | |
"version": "0.0.0", | |
"main": "spriter.js", | |
"scripts": { | |
"start": "node spriter.js" | |
}, | |
"author": "Andrea D. <[email protected]>", | |
"license": "MIT", | |
"dependencies": { |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function emptyRequest() { | |
return { | |
_destroy: undefined, | |
_read: undefined, | |
accepted: [], | |
accepts: undefined, | |
acceptsCharsets: undefined, | |
acceptsEncodings: undefined, | |
acceptsLanguages: undefined, | |
addListener: undefined, |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$stateProvider | |
.state('competition', {url: '/:lang/'+ getLocalizedString('URL.COMPETITION'), ...}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javascript: (function(){ | |
[ | |
"angular", | |
"bower", | |
"css", | |
"django", | |
"dom", | |
"dom_events", | |
"ember", | |
"express", |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/** | |
* Returns `true` if any of the given string contains a palindrome. | |
* @param {String} s the string to test | |
*/ | |
function PalindromeFinder(s) { | |
//build an array of characters from the string `s` | |
var chars = s.split(''); | |
//store how many of the same char within the string (so the array) | |
var charsOccurences = {}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!DOCTYPE html> | |
<html lang="en"> | |
<head> | |
<meta charset="utf-8"> | |
<meta http-equiv="X-UA-Compatible" content="IE=edge"> | |
<meta name="viewport" content="width=device-width, initial-scale=1"> | |
<title>Input Sample</title> | |
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/twitter-bootstrap/3.3.5/css/bootstrap.css"> | |
<script src="http://cdnjs.cloudflare.com/ajax/libs/angular.js/1.2.1/angular.js"></script> |
NewerOlder