- Make sure you are aware of the problem/feature.
- Don't be rude, be polite.
- Give suggestions and make clear why do you think you suggestion is better than the current approach.
- Don't point out just the bad things, tell about what do you think is great as well.
- Make it part of your daily workflow. (use github notifications)
- http://www.dein.fr/2015-02-18-maslows-pyramid-of-code-review.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
// base64.decode(base64.encode('💩')); | |
// Browsers | |
const base64 = { | |
encode: str => btoa(unescape(encodeURIComponent(str))), | |
decode: str => decodeURIComponent(escape(atob(str))) | |
}; | |
/* ES3 compat version | |
var base64 = { |
A Runtime ImportMap Example - now as a module
While it's not possible to define a <script type="importmap">
within a module, it is possible to define it in a synchronous <script>
tag, as long as it's before any module starts executing.
Example (works in Chrome / Edge / WebKit / Safari / Firefox)
<!DOCTYPE html>
<html lang="en">
<head>
OlderNewer