- Make sure you are aware of the problem/feature.
- Don't be rude, be polite.
- Give suggestions and make clear why do you think you suggestion is better than the current approach.
- Don't point out just the bad things, tell about what do you think is great as well.
- Make it part of your daily workflow. (use github notifications)
- http://www.dein.fr/2015-02-18-maslows-pyramid-of-code-review.html
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$stateProvider | |
.state('competition', {url: '/:lang/'+ getLocalizedString('URL.COMPETITION'), ...}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function emptyRequest() { | |
return { | |
_destroy: undefined, | |
_read: undefined, | |
accepted: [], | |
accepts: undefined, | |
acceptsCharsets: undefined, | |
acceptsEncodings: undefined, | |
acceptsLanguages: undefined, | |
addListener: undefined, |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{ | |
"name": "spriter", | |
"version": "0.0.0", | |
"main": "spriter.js", | |
"scripts": { | |
"start": "node spriter.js" | |
}, | |
"author": "Andrea D. <[email protected]>", | |
"license": "MIT", | |
"dependencies": { |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
const express = require('express'); | |
const cors = require('cors'); | |
const axios = require('axios'); | |
const app = express(); | |
app.use(cors()); | |
app.use(express.json()); | |
console.log( 'running server') | |
app.get('/api', async (req, res) => { |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker run -p 8080:80 -v ./myconfig.conf:/etc/nginx/nginx.conf nginx |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/* ==UserStyle== | |
@name Google Photos without slide transition | |
@description Disable the sliding transition between photos and videos in Google Photos | |
@match https://photos.google.com/* | |
@version 1.0 | |
@namespace https://greasyfork.org/users/971713 | |
==/UserStyle== */ | |
.TTxCae { | |
transform: matrix(1, 0, 0, 1, 0, 0) !important; |
OlderNewer