Last active
August 14, 2022 10:04
-
-
Save OrkhanAlikhanov/18ad8988323bb694ea9f6a83348e23d7 to your computer and use it in GitHub Desktop.
Patch to add support for https://github.com/facebook/react/issues/16873
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diff --git a/node_modules/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js b/node_modules/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js | |
index 441442f..a536c7a 100644 | |
--- a/node_modules/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js | |
+++ b/node_modules/eslint-plugin-react-hooks/cjs/eslint-plugin-react-hooks.development.js | |
@@ -735,7 +735,29 @@ var ExhaustiveDeps = { | |
}, | |
enableDangerousAutofixThisMayCauseInfiniteLoops: { | |
type: 'boolean' | |
- } | |
+ }, | |
+ staticHooks: { | |
+ type: 'object', | |
+ additionalProperties: { | |
+ oneOf: [ | |
+ { | |
+ type: 'boolean', | |
+ }, | |
+ { | |
+ type: 'array', | |
+ items: { | |
+ type: 'boolean', | |
+ }, | |
+ }, | |
+ { | |
+ type: 'object', | |
+ additionalProperties: { | |
+ type: 'boolean', | |
+ }, | |
+ }, | |
+ ], | |
+ }, | |
+ }, | |
} | |
}] | |
}, | |
@@ -743,9 +765,12 @@ var ExhaustiveDeps = { | |
// Parse the `additionalHooks` regex. | |
var additionalHooks = context.options && context.options[0] && context.options[0].additionalHooks ? new RegExp(context.options[0].additionalHooks) : undefined; | |
var enableDangerousAutofixThisMayCauseInfiniteLoops = context.options && context.options[0] && context.options[0].enableDangerousAutofixThisMayCauseInfiniteLoops || false; | |
+ var staticHooks = (context.options && context.options[0] && context.options[0].staticHooks) || {}; | |
+ | |
var options = { | |
additionalHooks: additionalHooks, | |
- enableDangerousAutofixThisMayCauseInfiniteLoops: enableDangerousAutofixThisMayCauseInfiniteLoops | |
+ enableDangerousAutofixThisMayCauseInfiniteLoops: enableDangerousAutofixThisMayCauseInfiniteLoops, | |
+ staticHooks: staticHooks, | |
}; | |
function reportProblem(problem) { | |
@@ -954,6 +979,33 @@ var ExhaustiveDeps = { | |
return true; | |
} | |
} | |
+ } else if (options.staticHooks[name]) { | |
+ const staticParts = options.staticHooks[name]; | |
+ if (staticParts === true) { | |
+ // entire return value is static | |
+ return true; | |
+ } else if (Array.isArray(staticParts)) { | |
+ // destructured tuple return where some elements are static | |
+ if ( | |
+ id.type === 'ArrayPattern' && | |
+ id.elements.length <= staticParts.length && | |
+ Array.isArray(resolved.identifiers) | |
+ ) { | |
+ // find index of the resolved ident in the array pattern | |
+ const idx = id.elements.findIndex( | |
+ ident => ident === resolved.identifiers[0], | |
+ ); | |
+ if (idx >= 0) { | |
+ return staticParts[idx]; | |
+ } | |
+ } | |
+ } else if (typeof staticParts === 'object' && id.type === 'ObjectPattern') { | |
+ // destructured object return where some properties are static | |
+ const property = id.properties.find(p => p.key === resolved.identifiers[0]) | |
+ if (property) { | |
+ return staticParts[property.key.name] | |
+ } | |
+ } | |
} // By default assume it's dynamic. | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment