Last active
May 8, 2019 14:09
-
-
Save Panman82/d7ad266b4c3d3a46baeaae6c503133f7 to your computer and use it in GitHub Desktop.
diff my-classic-addon my-octane-addon
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- a/my-classic-addon/.travis.yml | |
+++ b/my-octane-addon/.travis.yml | |
@@ -19,37 +19,20 @@ env: | |
global: | |
# See https://git.io/vdao3 for details. | |
- JOBS=1 | |
- | |
-branches: | |
- only: | |
- - master | |
- # npm version tags | |
- - /^v\d+\.\d+\.\d+/ | |
- | |
-jobs: | |
- fail_fast: true | |
- allow_failures: | |
- - env: EMBER_TRY_SCENARIO=ember-canary | |
- | |
- include: | |
- # runs linting and tests with current locked deps | |
- | |
- - stage: "Tests" | |
- name: "Tests" | |
- script: | |
- - npm run lint:hbs | |
- - npm run lint:js | |
- - npm test | |
- | |
+ matrix: | |
# we recommend new addons test the current and previous LTS | |
# as well as latest stable release (bonus points to beta/canary) | |
- - stage: "Additional Tests" | |
- env: EMBER_TRY_SCENARIO=ember-lts-2.18 | |
- - env: EMBER_TRY_SCENARIO=ember-lts-3.4 | |
- - env: EMBER_TRY_SCENARIO=ember-release | |
- - env: EMBER_TRY_SCENARIO=ember-beta | |
+ - EMBER_TRY_SCENARIO=ember-lts-2.18 | |
+ - EMBER_TRY_SCENARIO=ember-lts-3.4 | |
+ - EMBER_TRY_SCENARIO=ember-release | |
+ - EMBER_TRY_SCENARIO=ember-beta | |
+ - EMBER_TRY_SCENARIO=ember-canary | |
+ - EMBER_TRY_SCENARIO=ember-default | |
+ | |
+matrix: | |
+ fast_finish: true | |
+ allow_failures: | |
- env: EMBER_TRY_SCENARIO=ember-canary | |
- - env: EMBER_TRY_SCENARIO=ember-default-with-jquery | |
before_install: | |
- npm config set spin false | |
@@ -57,4 +40,8 @@ before_install: | |
- npm --version | |
script: | |
- - node_modules/.bin/ember try:one $EMBER_TRY_SCENARIO | |
+ - npm run lint:hbs | |
+ - npm run lint:js | |
+ # Usually, it's ok to finish the test scenario without reverting | |
+ # to the addon's original dependency state, skipping "cleanup". | |
+ - |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- a/my-classic-addon/config/ember-try.js | |
+++ b/my-octane-addon/config/ember-try.js | |
@@ -6,18 +6,15 @@ module.exports = function() { | |
return Promise.all([ | |
getChannelURL('release'), | |
getChannelURL('beta'), | |
- getChannelURL('canary') | |
+ getChannelURL('canary'), | |
]).then((urls) => { | |
return { | |
+ useYarn: true, | |
scenarios: [ | |
{ | |
name: 'ember-lts-2.18', | |
- env: { | |
- EMBER_OPTIONAL_FEATURES: JSON.stringify({ 'jquery-integration': true }) | |
- }, | |
npm: { | |
devDependencies: { | |
- '@ember/jquery': '^0.5.1', | |
'ember-source': '~2.18.0' | |
} | |
} | |
@@ -54,28 +51,11 @@ module.exports = function() { | |
} | |
} | |
}, | |
- // The default `.travis.yml` runs this scenario via `npm test`, | |
- // not via `ember try`. It's still included here so that running | |
- // `ember try:each` manually or from a customized CI config will run it | |
- // along with all the other scenarios. | |
{ | |
name: 'ember-default', | |
npm: { | |
devDependencies: {} | |
} | |
- }, | |
- { | |
- name: 'ember-default-with-jquery', | |
- env: { | |
- EMBER_OPTIONAL_FEATURES: JSON.stringify({ | |
- 'jquery-integration': true | |
- }) | |
- }, | |
- npm: { | |
- devDependencies: { | |
- '@ember/jquery': '^0.5.1' | |
- } | |
- } | |
} | |
] | |
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- a/my-classic-addon/package.json | |
+++ b/my-octane-addon/package.json | |
@@ -17,35 +17,35 @@ | |
"lint:hbs": "ember-template-lint .", | |
"lint:js": "eslint .", | |
"start": "ember serve", | |
- "test": "ember test", | |
- "test:all": "ember try:each" | |
+ "test": "ember test" | |
}, | |
"dependencies": { | |
- "ember-cli-babel": "^7.1.2" | |
+ "ember-cli-babel": "^7.7.0", | |
+ "ember-cli-htmlbars": "^3.0.0" | |
}, | |
"devDependencies": { | |
- "@ember/optional-features": "^0.6.3", | |
- "broccoli-asset-rev": "^2.7.0", | |
- "ember-cli": "~3.9.0", | |
- "ember-cli-dependency-checker": "^3.1.0", | |
- "ember-cli-eslint": "^4.2.3", | |
- "ember-cli-htmlbars": "^3.0.0", | |
- "ember-cli-htmlbars-inline-precompile": "^1.0.3", | |
- "ember-cli-inject-live-reload": "^1.8.2", | |
+ "babel-eslint": "^8.0.2", | |
+ "@ember/optional-features": "^0.7.0", | |
+ "@glimmer/component": "^0.14.0-alpha.3", | |
+ "broccoli-asset-rev": "^3.0.0", | |
+ "ember-auto-import": "^1.2.20", | |
+ "ember-cli": "<%= emberCLI %>", | |
+ "ember-cli-app-version": "^3.2.0", | |
+ "ember-cli-dependency-checker": "^3.0.0", | |
+ "ember-cli-eslint": "^5.0.0", | |
+ "ember-cli-htmlbars-inline-precompile": "^2.0.0", | |
+ "ember-cli-inject-live-reload": "^2.0.1", | |
"ember-cli-sri": "^2.1.1", | |
"ember-cli-template-lint": "^1.0.0-beta.1", | |
"ember-cli-uglify": "^2.1.0", | |
- "ember-disable-prototype-extensions": "^1.1.3", | |
"ember-export-application-global": "^2.0.0", | |
- "ember-load-initializers": "^1.1.0", | |
+ "ember-load-initializers": "^2.0.0", | |
"ember-maybe-import-regenerator": "^0.1.6", | |
- "ember-qunit": "^3.4.1", | |
- "ember-resolver": "^5.0.1", | |
- "ember-source": "~3.9.0", | |
- "ember-source-channel-url": "^1.1.0", | |
- "ember-try": "^1.0.0", | |
- "eslint-plugin-ember": "^5.2.0", | |
- "eslint-plugin-node": "^7.0.1", | |
+ "ember-qunit": "^4.1.2", | |
+ "ember-resolver": "^5.1.3", | |
+ "ember-source": "<%= emberCanaryVersion %>", | |
+ "eslint-plugin-ember": "^6.0.1", | |
+ "eslint-plugin-node": "^8.0.1", | |
"loader.js": "^4.7.0", | |
"qunit-dom": "^0.8.0" | |
}, |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--- a/my-classic-addon/tests/dummy/config/targets.js | |
+++ b/my-octane-addon/tests/dummy/config/targets.js | |
@@ -1,18 +1,8 @@ | |
-'use strict'; | |
- | |
-const browsers = [ | |
- 'last 1 Chrome versions', | |
- 'last 1 Firefox versions', | |
- 'last 1 Safari versions' | |
-]; | |
- | |
-const isCI = !!process.env.CI; | |
-const isProduction = process.env.EMBER_ENV === 'production'; | |
- | |
-if (isCI || isProduction) { | |
- browsers.push('ie 11'); | |
-} | |
- | |
module.exports = { | |
- browsers | |
+ browsers: [ | |
+ 'ie 11', | |
+ 'last 1 Chrome versions', | |
+ 'last 1 Firefox versions', | |
+ 'last 1 Safari versions' | |
+ ] | |
}; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment