Last active
July 6, 2022 09:23
-
-
Save Rotemy/ce5eb81c49af78744dac63d5d087c591 to your computer and use it in GitHub Desktop.
Request for Opensea to add the option to execute static call before or after the sale
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In Wyvren Protocol there was an option to call a static target with data after a sale and in that static call to verify the sale.
However, in Seaport Protocol, there isn’t any option to do that.
After going thoroughly over Seaport protocol's code, I believe the proper place to add this functionality is in a Zone. Reciting from Seaport documentation:
So it seems like
isValidOrder
orisValidOrderIncludingExtraData
is the right place to add this functionality.Another option, is to allow order creators to set their own zone and not block it. Right now, when I try to use my own zone I get this error:
However, if they allow it, order creators would be able to utilize the
ZoneHash
parameter, reciting again from Seaport documentation:I would be happy to have a closer discussion with Opensea's developer about this matter.
Thank you