Created
February 18, 2016 04:19
-
-
Save SpencerCooley/7a8ea953ac4df35c88c9 to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem: | |
The revolution slider requires that you include your layers and images inside of a <li> item. | |
when a plugin is editable it wraps the plugin in a div with a unique class id, in this case cms-plugin-16646. | |
I assume this is so it has a way to reference the element on double click in the visual editor. | |
<div class="cms-plugin cms-plugin-16646" style="display: inline;"> | |
<li data-transition="slideright"> | |
<!-- MAIN IMAGE --> | |
<img src="http://www.spca.org/image/2014-redesign/landing-page-banne.jpg" alt=""> | |
</li> | |
</div> | |
this breaks the visual editor because revolution slider simply expects a <li> item: | |
<li data-transition="slideright"> | |
<!-- MAIN IMAGE --> | |
<img src="http://www.spca.org/image/2014-redesign/landing-page-banne.jpg" alt=""> | |
</li> | |
solutions: | |
1. we ignore the visual editor and only make slides attributes editable on the structure ui. Let the content editor view just sort of stay broken. | |
2. build a visual editor for when we are in edit mode. So when in the content editor mode we have a sort of gallery view to that the user can click on to edit each slide. | |
we can check if we are in edit mode: | |
{% if request.toolbar.edit_mode %} | |
we build an alternate template that is more editable friendly. | |
{% endif %} | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment