Created
April 10, 2016 14:37
-
-
Save Terrance/158a4c436baa64c4324803467844b00f to your computer and use it in GitHub Desktop.
Limit concurrent jQuery ajax requests to at most 3 at a time, and queue the rest.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var ajaxReqs = 0; | |
var ajaxQueue = []; | |
var ajaxActive = 0; | |
var ajaxMaxConc = 3; | |
function addAjax(obj) { | |
ajaxReqs++; | |
var oldSuccess = obj.success; | |
var oldError = obj.error; | |
var callback = function() { | |
ajaxReqs--; | |
if (ajaxActive === ajaxMaxConc) { | |
$.ajax(ajaxQueue.shift()); | |
} else { | |
ajaxActive--; | |
} | |
} | |
obj.success = function(resp, xhr, status) { | |
callback(); | |
if (oldSuccess) oldSuccess(resp, xhr, status); | |
}; | |
obj.error = function(xhr, status, error) { | |
callback(); | |
if (oldError) oldError(xhr, status, error); | |
}; | |
if (ajaxActive === ajaxMaxConc) { | |
ajaxQueue.push(obj); | |
} else { | |
ajaxActive++; | |
$.ajax(obj); | |
} | |
} |
- The mistake in the original code is that it doesn't check if
ajaxQueue
still contains elements. If at some pointajaxQueue
gets empty, the code ends up with a (harmless) no-op$.ajax(undefined)
, and importantly,ajaxActive
isn't decremented, which leads to various issues. - Your fixed code has a mistake, there is an extraneous
ajaxActive--;
. You may either:- Remove the "else" branch having the
ajaxActive--;
- Remove the first
ajaxActive--;
, and theajaxActive < ajaxMaxConc
and theajaxActive++;
(whencallback()
triggers a new request, the number of active requests stays the same)
- Remove the "else" branch having the
ajaxActive
cannot exceedajaxMaxConc
, and this is ensured whenaddAjax()
is called. Therefore it is irrelevant to check it incallback()
.- Btw, notice the
ajaxReqs
variable is useless.
Considering the above points, I ended up with the following code for callback()
:
var callback = function () {
if (ajaxQueue.length > 0) {
$.ajax(ajaxQueue.shift());
} else {
ajaxActive--;
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
(yes a reply to an old post, perhaps someone can use it in the future).
The fix mentioned also does not work for my. The original one fires more requests then I add and no longer works when I re-add at a later moment. The fix only does a single "batch" then stops.
For me it works like this: