Skip to content

Instantly share code, notes, and snippets.

@Trott

Trott/test-os.md

Created September 24, 2016 16:48
Show Gist options
  • Save Trott/045d95d284f82979991265917c148867 to your computer and use it in GitHub Desktop.
Save Trott/045d95d284f82979991265917c148867 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
test-os.md

In test/parallel/test-os.js:

  • Two instances of == that are better as ===
  • Several instances of .indexOf() that can be rewritten using .includes() for more clarity
  • Bonus optional change: The os module has an undocumented and deprecated function os.getNetworkInterfaces() that is not tested at all. Write a minimal test for it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment