Created
November 22, 2018 08:31
-
-
Save ZacSweers/41ed9db9ebe473c72b49bc4b3b2231df to your computer and use it in GitHub Desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> Task :compileJava | |
warning: [options] bootstrap class path not set in conjunction with -source 1.6 | |
warning: [options] source value 1.6 is obsolete and will be removed in a future release | |
warning: [options] target value 1.6 is obsolete and will be removed in a future release | |
warning: [options] To suppress warnings about obsolete options, use -Xlint:-options. | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Single.java:135: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new SingleAmb<T>(null, sources)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Single.java:163: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new SingleAmb<T>(sources, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Single.java:792: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableSingleSingle<T>(observableSource, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Single.java:3051: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new SingleOnErrorReturn<T>(this, resumeFunction, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Single.java:3070: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new SingleOnErrorReturn<T>(this, null, value)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Single.java:3664: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(timeout, unit, Schedulers.computation(), null); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Single.java:3684: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(timeout, unit, scheduler, null); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Single.java:3986: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new FlowableSingleSingle<T>(source, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:94: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new FlowableAmb<T>(null, sources)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:130: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new FlowableAmb<T>(sources, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:2017: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new FlowableFromFuture<T>(future, 0L, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:4484: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new FlowableZip<T, R>(null, sources, zipper, bufferSize(), false)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:5328: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new FlowableZip<T, R>(sources, null, zipper, bufferSize, delayError)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:5389: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new FlowableZip<T, R>(null, sources, zipper, bufferSize, delayError)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:9353: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new FlowableElementAtSingle<T>(this, index, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:10623: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new FlowableGroupBy<T, K, V>(this, keySelector, valueSelector, bufferSize, delayError, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:10980: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new FlowableLastSingle<T>(this, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:13879: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new FlowableSingleSingle<T>(this, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:16186: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(null, itemTimeoutIndicator, null); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:16225: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(null, itemTimeoutIndicator, other); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:16254: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(timeout, timeUnit, null, Schedulers.computation()); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:16355: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(timeout, timeUnit, null, scheduler); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Flowable.java:16395: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(firstTimeoutIndicator, itemTimeoutIndicator, null); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:122: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableAmb<T>(null, sources)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:155: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableAmb<T>(sources, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:301: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableCombineLatest<T, R>(null, sources, combiner, s, false)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:396: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableCombineLatest<T, R>(sources, null, combiner, s, false)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:975: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableCombineLatest<T, R>(sources, null, combiner, s, true)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:1069: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableCombineLatest<T, R>(null, sources, combiner, s, true)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:1814: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableFromFuture<T>(future, 0L, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:4094: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableZip<T, R>(null, sources, zipper, bufferSize(), false)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:4888: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableZip<T, R>(sources, null, zipper, bufferSize, delayError)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:4949: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableZip<T, R>(null, sources, zipper, bufferSize, delayError)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:8329: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableElementAtSingle<T>(this, index, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:9538: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableLastSingle<T>(this, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:11580: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new ObservableSingleSingle<T>(this, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:13506: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(null, itemTimeoutIndicator, null); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:13540: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(null, itemTimeoutIndicator, other); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:13565: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(timeout, timeUnit, null, Schedulers.computation()); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:13650: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(timeout, timeUnit, null, scheduler); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Observable.java:13685: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(firstTimeoutIndicator, itemTimeoutIndicator, null); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Scheduler.java:320: warning: [TypeParameterUnusedInFormals] Declaring a type parameter that is only used in the return type is a misuse of generics: operations on the type parameter are unchecked, it hides unsafe casts at invocations of the method, and it interacts badly with method overload resolution. | |
public <S extends Scheduler & Disposable> S when(@NonNull Function<Flowable<Flowable<Completable>>, Completable> combine) { | |
^ | |
(see https://errorprone.info/bugpattern/TypeParameterUnusedInFormals) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Scheduler.java:494: warning: [UnnecessaryParentheses] Unnecessary use of grouping parentheses | |
startInNanoseconds = nextTick - (periodInNanoseconds * (++count)); | |
^ | |
(see https://errorprone.info/bugpattern/UnnecessaryParentheses) | |
Did you mean 'startInNanoseconds = nextTick - (periodInNanoseconds * ++count);'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Notification.java:160: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
static final Notification<Object> COMPLETE = new Notification<Object>(null); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Maybe.java:130: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new MaybeAmb<T>(null, sources)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Maybe.java:157: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new MaybeAmb<T>(sources, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Maybe.java:789: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new MaybeFromFuture<T>(future, 0L, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Maybe.java:3570: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new MaybeToSingle<T>(this, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Maybe.java:4469: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new MaybeTimeoutMaybe<T, U>(this, timeoutIndicator, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Maybe.java:4514: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new MaybeTimeoutPublisher<T, U>(this, timeoutIndicator, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Completable.java:131: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new CompletableAmb(sources, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Completable.java:153: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new CompletableAmb(null, sources)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Completable.java:2422: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(timeout, unit, Schedulers.computation(), null); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Completable.java:2467: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return timeout0(timeout, unit, scheduler, null); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Completable.java:2631: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new CompletableToSingle<T>(this, completionValueSupplier, null)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/Completable.java:2652: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
return RxJavaPlugins.onAssembly(new CompletableToSingle<T>(this, null, completionValue)); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/observers/TestObserver.java:75: error: [NullAway] initializer method does not guarantee @NonNull field qd is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
public TestObserver(Observer<? super T> downstream) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/observers/TestObserver.java:225: error: [NullAway] passing @Nullable parameter 'upstream.get()' where @NonNull is required | |
return DisposableHelper.isDisposed(upstream.get()); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/observers/BaseTestConsumer.java:61: error: [NullAway] initializer method does not guarantee @NonNull fields lastThread, tag are initialized along all control-flow paths (remember to check for exceptions or early returns). | |
public BaseTestConsumer() { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/observers/BaseTestConsumer.java:227: warning: [UnnecessaryParentheses] Unnecessary use of grouping parentheses | |
boolean d = done.getCount() == 0 || (done.await(time, unit)); | |
^ | |
(see https://errorprone.info/bugpattern/UnnecessaryParentheses) | |
Did you mean 'boolean d = done.getCount() == 0 || done.await(time, unit);'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/observers/BaseTestConsumer.java:740: error: [NullAway] passing @Nullable parameter 'errorMessage' where @NonNull is required | |
if (!ObjectHelper.equals(message, errorMessage)) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/observers/BaseTestConsumer.java:914: warning: [ThreadPriorityCheck] Relying on the thread scheduler is discouraged; see Effective Java Item 72 (2nd edition) / 84 (3rd edition). | |
Thread.yield(); | |
^ | |
(see https://errorprone.info/bugpattern/ThreadPriorityCheck) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/observables/GroupedObservable.java:41: error: [NullAway] initializer method does not guarantee @NonNull field key is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
protected GroupedObservable(@Nullable K key) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/observables/GroupedObservable.java:42: error: [NullAway] assigning @Nullable expression to @NonNull field | |
this.key = key; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/flowables/GroupedFlowable.java:41: error: [NullAway] initializer method does not guarantee @NonNull field key is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
protected GroupedFlowable(@Nullable K key) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/flowables/GroupedFlowable.java:42: error: [NullAway] assigning @Nullable expression to @NonNull field | |
this.key = key; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/subscribers/TestSubscriber.java:118: error: [NullAway] initializer method does not guarantee @NonNull field qs is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
public TestSubscriber(Subscriber<? super T> actual, long initialRequest) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/disposables/SequentialDisposable.java:77: error: [NullAway] passing @Nullable parameter 'get()' where @NonNull is required | |
return DisposableHelper.isDisposed(get()); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/disposables/CompositeDisposable.java:36: error: [NullAway] initializer method does not guarantee @NonNull field resources is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
public CompositeDisposable() { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/disposables/CompositeDisposable.java:77: error: [NullAway] assigning @Nullable expression to @NonNull field | |
resources = null; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/disposables/CompositeDisposable.java:198: error: [NullAway] assigning @Nullable expression to @NonNull field | |
resources = null; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/disposables/SerialDisposable.java:52: error: [NullAway] passing @Nullable parameter 'next' where @NonNull is required | |
return DisposableHelper.set(resource, next); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/disposables/SerialDisposable.java:63: error: [NullAway] passing @Nullable parameter 'next' where @NonNull is required | |
return DisposableHelper.replace(resource, next); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/disposables/SerialDisposable.java:86: error: [NullAway] passing @Nullable parameter 'resource.get()' where @NonNull is required | |
return DisposableHelper.isDisposed(resource.get()); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelFilter.java:75: error: [NullAway] initializer method does not guarantee @NonNull field upstream is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
BaseFilterSubscriber(Predicate<? super T> predicate) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelPeek.java:98: error: [NullAway] initializer method does not guarantee @NonNull field upstream is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
ParallelPeekSubscriber(Subscriber<? super T> actual, ParallelPeek<T> parent) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelMapTry.java:88: error: [NullAway] initializer method does not guarantee @NonNull field upstream is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
ParallelMapTrySubscriber(Subscriber<? super R> actual, Function<? super T, ? extends R> mapper, | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelMapTry.java:200: error: [NullAway] initializer method does not guarantee @NonNull field upstream is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
ParallelMapTryConditionalSubscriber(ConditionalSubscriber<? super R> actual, | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelRunOn.java:135: error: [NullAway] initializer method does not guarantee @NonNull fields upstream, error are initialized along all control-flow paths (remember to check for exceptions or early returns). | |
BaseRunOnSubscriber(int prefetch, SpscArrayQueue<T> queue, Worker worker) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelRunOn.java:397: error: [NullAway] passing @Nullable parameter 'v' where @NonNull is required | |
if (a.tryOnNext(v)) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/queue/SpscArrayQueue.java:97: error: [NullAway] passing @Nullable parameter 'null' where @NonNull is required | |
soElement(offset, null); // StoreStore | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelCollect.java:138: error: [NullAway] assigning @Nullable expression to @NonNull field | |
collection = null; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelCollect.java:149: error: [NullAway] assigning @Nullable expression to @NonNull field | |
collection = null; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/subscribers/DeferredScalarSubscriber.java:42: error: [NullAway] initializer method does not guarantee @NonNull field upstream is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
public DeferredScalarSubscriber(Subscriber<? super R> downstream) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/subscribers/DeferredScalarSubscriber.java:59: error: [NullAway] assigning @Nullable expression to @NonNull field | |
value = null; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/subscriptions/DeferredScalarSubscription.java:68: error: [NullAway] initializer method does not guarantee @NonNull field value is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
public DeferredScalarSubscription(Subscriber<? super T> downstream) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/subscriptions/DeferredScalarSubscription.java:86: error: [NullAway] assigning @Nullable expression to @NonNull field | |
value = null; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/subscriptions/DeferredScalarSubscription.java:144: error: [NullAway] assigning @Nullable expression to @NonNull field | |
value = null; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/subscriptions/DeferredScalarSubscription.java:165: error: [NullAway] assigning @Nullable expression to @NonNull field | |
value = null; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/subscriptions/DeferredScalarSubscription.java:179: error: [NullAway] assigning @Nullable expression to @NonNull field | |
value = null; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/subscriptions/DeferredScalarSubscription.java:185: error: [NullAway] assigning @Nullable expression to @NonNull field | |
value = null; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelDoOnNextTry.java:87: error: [NullAway] initializer method does not guarantee @NonNull field upstream is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
ParallelDoOnNextSubscriber(Subscriber<? super T> actual, Consumer<? super T> onNext, | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelDoOnNextTry.java:197: error: [NullAway] initializer method does not guarantee @NonNull field upstream is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
ParallelDoOnNextConditionalSubscriber(ConditionalSubscriber<? super T> actual, | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelFilterTry.java:82: error: [NullAway] initializer method does not guarantee @NonNull field upstream is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
BaseFilterSubscriber(Predicate<? super T> predicate, BiFunction<? super Long, ? super Throwable, ParallelFailureHandling> errorHandler) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelReduceFull.java:105: error: [NullAway] returning @Nullable expression from method with @NonNull return type | |
return null; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelReduceFull.java:175: error: [NullAway] initializer method does not guarantee @NonNull field value is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
ParallelReduceFullInnerSubscriber(ParallelReduceFullMainSubscriber<T> parent, BiFunction<T, T, T> reducer) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelReduceFull.java:198: error: [NullAway] dereferenced expression get() is @Nullable | |
get().cancel(); | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelReduceFull.java:235: error: [NullAway] @NonNull field first not initialized | |
T first; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelReduceFull.java:237: error: [NullAway] @NonNull field second not initialized | |
T second; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelReduce.java:139: error: [NullAway] assigning @Nullable expression to @NonNull field | |
accumulator = null; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelReduce.java:149: error: [NullAway] assigning @Nullable expression to @NonNull field | |
accumulator = null; | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelMap.java:81: error: [NullAway] initializer method does not guarantee @NonNull field upstream is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
ParallelMapSubscriber(Subscriber<? super R> actual, Function<? super T, ? extends R> mapper) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelMap.java:154: error: [NullAway] initializer method does not guarantee @NonNull field upstream is initialized along all control-flow paths (remember to check for exceptions or early returns). | |
ParallelMapConditionalSubscriber(ConditionalSubscriber<? super R> actual, Function<? super T, ? extends R> mapper) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/parallel/ParallelFromPublisher.java:99: error: [NullAway] initializer method does not guarantee @NonNull fields upstream, queue, error are initialized along all control-flow paths (remember to check for exceptions or early returns). | |
ParallelDispatcher(Subscriber<? super T>[] subscribers, int prefetch) { | |
^ | |
(see http://t.uber.com/nullaway ) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/util/ExceptionHelper.java:142: warning: [UnsynchronizedOverridesSynchronized] Unsynchronized method fillInStackTrace overrides synchronized method in Throwable | |
public Throwable fillInStackTrace() { | |
^ | |
(see https://errorprone.info/bugpattern/UnsynchronizedOverridesSynchronized) | |
Did you mean 'public synchronized Throwable fillInStackTrace() {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/queue/SpscLinkedArrayQueue.java:57: warning: [IntLongMath] Expression of type int may overflow before being assigned to a long | |
producerLookAhead = mask - 1; // we know it's all empty to start with | |
^ | |
(see https://errorprone.info/bugpattern/IntLongMath) | |
Did you mean 'producerLookAhead = mask - 1L;'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableGroupJoin.java:239: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
if (mode == LEFT_VALUE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'if (Objects.equals(mode, LEFT_VALUE)) {' or 'if (mode.equals(LEFT_VALUE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableGroupJoin.java:291: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
else if (mode == RIGHT_VALUE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'else if (Objects.equals(mode, RIGHT_VALUE)) {' or 'else if (mode.equals(RIGHT_VALUE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableGroupJoin.java:325: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
else if (mode == LEFT_CLOSE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'else if (Objects.equals(mode, LEFT_CLOSE)) {' or 'else if (mode.equals(LEFT_CLOSE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableGroupJoin.java:334: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
else if (mode == RIGHT_CLOSE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'else if (Objects.equals(mode, RIGHT_CLOSE)) {' or 'else if (mode.equals(RIGHT_CLOSE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableJoin.java:216: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
if (mode == LEFT_VALUE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'if (Objects.equals(mode, LEFT_VALUE)) {' or 'if (mode.equals(LEFT_VALUE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableJoin.java:276: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
else if (mode == RIGHT_VALUE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'else if (Objects.equals(mode, RIGHT_VALUE)) {' or 'else if (mode.equals(RIGHT_VALUE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableJoin.java:337: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
else if (mode == LEFT_CLOSE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'else if (Objects.equals(mode, LEFT_CLOSE)) {' or 'else if (mode.equals(LEFT_CLOSE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableJoin.java:343: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
else if (mode == RIGHT_CLOSE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'else if (Objects.equals(mode, RIGHT_CLOSE)) {' or 'else if (mode.equals(RIGHT_CLOSE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableCache.java:315: warning: [NonAtomicVolatileUpdate] This update of a volatile variable is non-atomic | |
size++; | |
^ | |
(see https://errorprone.info/bugpattern/NonAtomicVolatileUpdate) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/BlockingFlowableIterable.java:70: warning: [IntLongMath] Expression of type int may overflow before being assigned to a long | |
this.limit = batchSize - (batchSize >> 2); | |
^ | |
(see https://errorprone.info/bugpattern/IntLongMath) | |
Did you mean 'this.limit = (long) batchSize - (batchSize >> 2);'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableBufferTimed.java:247: warning: [JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not. | |
this.buffers = new LinkedList<U>(); | |
^ | |
(see https://errorprone.info/bugpattern/JdkObsolete) | |
Did you mean 'this.buffers = new ArrayList<U>();'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableReplay.java:576: warning: [TypeParameterUnusedInFormals] Declaring a type parameter that is only used in the return type is a misuse of generics: operations on the type parameter are unchecked, it hides unsafe casts at invocations of the method, and it interacts badly with method overload resolution. | |
<U> U index() { | |
^ | |
(see https://errorprone.info/bugpattern/TypeParameterUnusedInFormals) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableReplay.java:628: warning: [NonAtomicVolatileUpdate] This update of a volatile variable is non-atomic | |
size++; | |
^ | |
(see https://errorprone.info/bugpattern/NonAtomicVolatileUpdate) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableReplay.java:634: warning: [NonAtomicVolatileUpdate] This update of a volatile variable is non-atomic | |
size++; | |
^ | |
(see https://errorprone.info/bugpattern/NonAtomicVolatileUpdate) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableReplay.java:640: warning: [NonAtomicVolatileUpdate] This update of a volatile variable is non-atomic | |
size++; | |
^ | |
(see https://errorprone.info/bugpattern/NonAtomicVolatileUpdate) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/flowable/FlowableWindowTimed.java:621: warning: [JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not. | |
this.windows = new LinkedList<UnicastProcessor<T>>(); | |
^ | |
(see https://errorprone.info/bugpattern/JdkObsolete) | |
Did you mean 'this.windows = new ArrayList<UnicastProcessor<T>>();'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableWindowTimed.java:543: warning: [JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not. | |
this.windows = new LinkedList<UnicastSubject<T>>(); | |
^ | |
(see https://errorprone.info/bugpattern/JdkObsolete) | |
Did you mean 'this.windows = new ArrayList<UnicastSubject<T>>();'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableReplay.java:463: warning: [TypeParameterUnusedInFormals] Declaring a type parameter that is only used in the return type is a misuse of generics: operations on the type parameter are unchecked, it hides unsafe casts at invocations of the method, and it interacts badly with method overload resolution. | |
<U> U index() { | |
^ | |
(see https://errorprone.info/bugpattern/TypeParameterUnusedInFormals) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableReplay.java:515: warning: [NonAtomicVolatileUpdate] This update of a volatile variable is non-atomic | |
size++; | |
^ | |
(see https://errorprone.info/bugpattern/NonAtomicVolatileUpdate) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableReplay.java:521: warning: [NonAtomicVolatileUpdate] This update of a volatile variable is non-atomic | |
size++; | |
^ | |
(see https://errorprone.info/bugpattern/NonAtomicVolatileUpdate) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableReplay.java:527: warning: [NonAtomicVolatileUpdate] This update of a volatile variable is non-atomic | |
size++; | |
^ | |
(see https://errorprone.info/bugpattern/NonAtomicVolatileUpdate) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableBufferTimed.java:237: warning: [JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not. | |
this.buffers = new LinkedList<U>(); | |
^ | |
(see https://errorprone.info/bugpattern/JdkObsolete) | |
Did you mean 'this.buffers = new ArrayList<U>();'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableGroupJoin.java:235: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
if (mode == LEFT_VALUE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'if (Objects.equals(mode, LEFT_VALUE)) {' or 'if (mode.equals(LEFT_VALUE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableGroupJoin.java:280: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
else if (mode == RIGHT_VALUE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'else if (Objects.equals(mode, RIGHT_VALUE)) {' or 'else if (mode.equals(RIGHT_VALUE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableGroupJoin.java:314: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
else if (mode == LEFT_CLOSE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'else if (Objects.equals(mode, LEFT_CLOSE)) {' or 'else if (mode.equals(LEFT_CLOSE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableGroupJoin.java:323: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
else if (mode == RIGHT_CLOSE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'else if (Objects.equals(mode, RIGHT_CLOSE)) {' or 'else if (mode.equals(RIGHT_CLOSE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableJoin.java:212: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
if (mode == LEFT_VALUE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'if (Objects.equals(mode, LEFT_VALUE)) {' or 'if (mode.equals(LEFT_VALUE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableJoin.java:255: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
else if (mode == RIGHT_VALUE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'else if (Objects.equals(mode, RIGHT_VALUE)) {' or 'else if (mode.equals(RIGHT_VALUE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableJoin.java:299: warning: [ReferenceEquality] Comparison using reference equality instead of value equality | |
else if (mode == LEFT_CLOSE) { | |
^ | |
(see https://errorprone.info/bugpattern/ReferenceEquality) | |
Did you mean 'else if (Objects.equals(mode, LEFT_CLOSE)) {' or 'else if (mode.equals(LEFT_CLOSE)) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/operators/observable/ObservableCache.java:304: warning: [NonAtomicVolatileUpdate] This update of a volatile variable is non-atomic | |
size++; | |
^ | |
(see https://errorprone.info/bugpattern/NonAtomicVolatileUpdate) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/util/LinkedArrayList.java:68: warning: [NonAtomicVolatileUpdate] This update of a volatile variable is non-atomic | |
size++; | |
^ | |
(see https://errorprone.info/bugpattern/NonAtomicVolatileUpdate) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/util/LinkedArrayList.java:72: warning: [NonAtomicVolatileUpdate] This update of a volatile variable is non-atomic | |
size++; | |
^ | |
(see https://errorprone.info/bugpattern/NonAtomicVolatileUpdate) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/util/NotificationLite.java:179: warning: [TypeParameterUnusedInFormals] Declaring a type parameter that is only used in the return type is a misuse of generics: operations on the type parameter are unchecked, it hides unsafe casts at invocations of the method, and it interacts badly with method overload resolution. | |
public static <T> T getValue(Object o) { | |
^ | |
(see https://errorprone.info/bugpattern/TypeParameterUnusedInFormals) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/disposables/ListCompositeDisposable.java:36: warning: [JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not. | |
this.resources = new LinkedList<Disposable>(); | |
^ | |
(see https://errorprone.info/bugpattern/JdkObsolete) | |
Did you mean 'this.resources = new ArrayList<Disposable>();'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/disposables/ListCompositeDisposable.java:45: warning: [JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not. | |
this.resources = new LinkedList<Disposable>(); | |
^ | |
(see https://errorprone.info/bugpattern/JdkObsolete) | |
Did you mean 'this.resources = new ArrayList<Disposable>();'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/disposables/ListCompositeDisposable.java:83: warning: [JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not. | |
set = new LinkedList<Disposable>(); | |
^ | |
(see https://errorprone.info/bugpattern/JdkObsolete) | |
Did you mean 'set = new ArrayList<Disposable>();'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/disposables/ListCompositeDisposable.java:102: warning: [JdkObsolete] It is very rare for LinkedList to out-perform ArrayList or ArrayDeque. Avoid it unless you're willing to invest a lot of time into benchmarking. Caveat: LinkedList supports null elements, but ArrayDeque does not. | |
set = new LinkedList<Disposable>(); | |
^ | |
(see https://errorprone.info/bugpattern/JdkObsolete) | |
Did you mean 'set = new ArrayList<Disposable>();'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/schedulers/RxThreadFactory.java:75: warning: [ThreadPriorityCheck] Relying on the thread scheduler is discouraged; see Effective Java Item 72 (2nd edition) / 84 (3rd edition). | |
t.setPriority(priority); | |
^ | |
(see https://errorprone.info/bugpattern/ThreadPriorityCheck) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/internal/schedulers/SchedulerPoolFactory.java:71: warning: [FutureReturnValueIgnored] Return value of methods returning Future must be checked. Ignoring returned Futures suppresses exceptions thrown from the code that completes the Future. | |
next.scheduleAtFixedRate(new ScheduledTask(), PURGE_PERIOD_SECONDS, PURGE_PERIOD_SECONDS, TimeUnit.SECONDS); | |
^ | |
(see https://errorprone.info/bugpattern/FutureReturnValueIgnored) | |
Did you mean to remove this line? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/processors/BehaviorProcessor.java:516: warning: [LockNotBeforeTry] Prefer releasing the lock on wl inside a finally block. | |
wl.lock(); | |
^ | |
(see https://errorprone.info/bugpattern/LockNotBeforeTry) | |
Did you mean 'wl.lock();try {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/processors/BehaviorProcessor.java:576: warning: [LockNotBeforeTry] Prefer releasing the lock on readLock inside a finally block. | |
readLock.lock(); | |
^ | |
(see https://errorprone.info/bugpattern/LockNotBeforeTry) | |
Did you mean 'readLock.lock();try {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/processors/ReplayProcessor.java:643: warning: [NonAtomicVolatileUpdate] This update of a volatile variable is non-atomic | |
size++; | |
^ | |
(see https://errorprone.info/bugpattern/NonAtomicVolatileUpdate) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/processors/MulticastProcessor.java:185: warning: [InconsistentCapitalization] Found the field 'refcount' with the same name as the parameter 'refCount' but with different capitalization. | |
public static <T> MulticastProcessor<T> create(boolean refCount) { | |
^ | |
(see https://errorprone.info/bugpattern/InconsistentCapitalization) | |
Did you mean 'public static <T> MulticastProcessor<T> create(boolean refcount) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/processors/MulticastProcessor.java:212: warning: [InconsistentCapitalization] Found the field 'refcount' with the same name as the parameter 'refCount' but with different capitalization. | |
public static <T> MulticastProcessor<T> create(int bufferSize, boolean refCount) { | |
^ | |
(see https://errorprone.info/bugpattern/InconsistentCapitalization) | |
Did you mean 'public static <T> MulticastProcessor<T> create(int bufferSize, boolean refcount) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/processors/MulticastProcessor.java:224: warning: [InconsistentCapitalization] Found the field 'refcount' with the same name as the parameter 'refCount' but with different capitalization. | |
MulticastProcessor(int bufferSize, boolean refCount) { | |
^ | |
(see https://errorprone.info/bugpattern/InconsistentCapitalization) | |
Did you mean 'MulticastProcessor(int bufferSize, boolean refcount) {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/subjects/ReplaySubject.java:645: warning: [NonAtomicVolatileUpdate] This update of a volatile variable is non-atomic | |
size++; | |
^ | |
(see https://errorprone.info/bugpattern/NonAtomicVolatileUpdate) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/subjects/ReplaySubject.java:652: warning: [NonAtomicVolatileUpdate] This update of a volatile variable is non-atomic | |
size++; | |
^ | |
(see https://errorprone.info/bugpattern/NonAtomicVolatileUpdate) | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/subjects/BehaviorSubject.java:464: warning: [LockNotBeforeTry] Prefer releasing the lock on writeLock inside a finally block. | |
writeLock.lock(); | |
^ | |
(see https://errorprone.info/bugpattern/LockNotBeforeTry) | |
Did you mean 'writeLock.lock();try {'? | |
/Users/zsweers/dev/java/contributing/RxJava/src/main/java/io/reactivex/subjects/BehaviorSubject.java:520: warning: [LockNotBeforeTry] Prefer releasing the lock on lock inside a finally block. | |
lock.lock(); | |
^ | |
(see https://errorprone.info/bugpattern/LockNotBeforeTry) | |
Did you mean 'lock.lock();try {'? | |
100 errors | |
59 warnings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment