gistfile1.txt

# Bad code:
class Foo:
    def one(self, normalize):
        self.normalize = normalize     
        self.username = os.geteuid()         
        self.token = os.environ['TOKEN']

        data = self.do_a_thing()
        if some_check():
            data2 = self.do_a_thing()
        data3 = self.do_a_thing()

    def do_a_thing(self):
        data = ask_server('retrieve', self.username, token=self.token)
        if self.normalize:
            data = correct_data(data)
        return data

Better to do it like this:
class Foo:
    def __init__(self, username, token):
        self.username = username
        self.token = self.token

Or like this:
class ThingDoer:
    def __init__(self, username, token, normalize):
        self.username = username
        self.token = token
        self.normalize = normalize
    def __call__(self):
        data = ask_server('retrieve', self.username, token=self.token)
        if self.normalize:
            data = correct_data(data)
        return data
class Foo:
    def one(self, normalize):
        do_a_thing = ThingDoer(username, token, normalize)
        data = do_a_thing()