abadger

import pytest


@pytest.fixture
def system_cert_with_target_path(request):
    print(pytest.__version__)
    print(request.node)
    print(dir(request.node))
    if pytest.__version__.split('.') <= ('3', '6', '0'):
        mark = request.node.get_marker("cert_filename")

abadger

diff --git a/convert2rhel/unit_tests/conftest.py b/convert2rhel/unit_tests/conftest.py
index 40ccf0b..acdd1d1 100644
--- a/convert2rhel/unit_tests/conftest.py
+++ b/convert2rhel/unit_tests/conftest.py
@@ -82,8 +82,11 @@ def system_cert_with_target_path(monkeypatch, tmpdir, request):
     .. seealso::
         https://docs.pytest.org/en/7.1.x/how-to/fixtures.html#using-markers-to-pass-data-to-fixtures
     """
+    if pytest.__version__.split('.') <= ('3', '6', '0'):
+        mark = request.node.get_marker("cert_filename")

abadger

def obj_inspector(obj):
    attributes = {}
    functions = {}
    special_functions = {}

    for attribute_name in dir(obj):
        attribute_value = getattr(obj, attribute_name)
        attribute_category = attributes

abadger

diff --git a/tests/integration/tier0/check-cve-2022-1662/main.fmf b/tests/integration/tier0/check-cve-2022-1662/main.fmf
index 7da180d..bf7c36b 100644
--- a/tests/integration/tier0/check-cve-2022-1662/main.fmf
+++ b/tests/integration/tier0/check-cve-2022-1662/main.fmf
@@ -3,4 +3,6 @@ summary: check cve-2022-1662 is fixed
 tier: 0
 
 test: |
+  yum install -y python3-devel
+  pip install psutil

abadger

+-------------------------------+------------+
|message id                     |occurrences |
+===============================+============+
|consider-using-f-string        |182         |  Disable until we can require python-3.6+
+-------------------------------+------------+
|logging-not-lazy               |123         |  `log.warn("Message %s" % var)` => `log.warn("Message %s", var)`
+-------------------------------+------------+
|useless-object-inheritance     |17          |  Add `__metaclass__ = type` to the top of all files and remove `object` from class
+-------------------------------+------------+
|logging-format-interpolation   |13          |

abadger

# Bad code:
class Foo:
    def one(self, normalize):
        self.normalize = normalize     
        self.username = os.geteuid()         
        self.token = os.environ['TOKEN']

        data = self.do_a_thing()
        if some_check():
            data2 = self.do_a_thing()

abadger

# Three ways to do for loops:

## The common way

Most of the time, you have an iterable (a list, dictionary, string, etc) and want to loop over it.
Python makes this the easiest way to use a for loop:

``` python
contestants = ["First place finisher", "Second is still good", "the first civilized age"]
for contestant in contestants:

abadger

import snake


@snake.key_map("<leader>R")
def reverse():
    """Test mapping.  Reverse a word"""
    snake.replace_word(snake.get_word()[::-1])


@snake.key_map("<c-p>")

abadger

diff --git a/convert2rhel/checks.py b/convert2rhel/checks.py
index 1bb5dff..ebe481f 100644
--- a/convert2rhel/checks.py
+++ b/convert2rhel/checks.py
@@ -105,7 +105,7 @@ def check_tainted_kmods():
         system76_io 16384 0 - Live 0x0000000000000000 (OE)  <<<<<< Tainted
         system76_acpi 16384 0 - Live 0x0000000000000000 (OE) <<<<< Tainted
     """
-    unsigned_modules, _ = run_subprocess("grep '(' /proc/modules")
+    unsigned_modules, _ = run_subprocess(["grep", "('", "/proc/modules"])

abadger

Background of security problem

When you call suprocess.Popen, you can pass the command to execute in two ways:

1. A string that corresponds to the commandline that you would run at the shell prompt command = "yum whatprovides 'java = 1.8.0'"
2. A list where each argument to the command is a separate entry: command = ["yum", "whatprovides", "java = 1.8.0"]

When you pass a string to subprocess.Popen, the command has to either have no arguments or be passed through the shell