Skip to content

Instantly share code, notes, and snippets.

@alanshaw
Last active July 1, 2016 07:36
Show Gist options
  • Select an option

  • Save alanshaw/8bbf86c3b1f380e91c2c0ee732815599 to your computer and use it in GitHub Desktop.

Select an option

Save alanshaw/8bbf86c3b1f380e91c2c0ee732815599 to your computer and use it in GitHub Desktop.
Coding horrors people have actually written
function findAllUsers (callback) {
  User.find({}).exec().then(function (users) {
    var userArr = []
    async.each(users,
      function (user, callback2) {
        userArr.push(user)
        callback2(null)
      },
      function (err) {
        if (err) return callback(err)
        // console.log("returning all users")
        return callback(null, userArr)
      }
    )
  }).catch(callback)
}

This database query isn't slow enough.

function checkHttpStatus(response) {
  if (response.status >= 200 && response.status < 300) {
    return Promise.resolve(response);
  } else {
    const error = new Error(response.statusText);
    error.response = response;
    return Promise.reject(error);
  }
}

If in doubt, wrap it in a Promise.

cb = cb || function (err, data) {
  if (err) return console.info('user data saved')
  console.info('user data saved')
}

Phew, looks like the data got saved anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment