Skip to content

Instantly share code, notes, and snippets.

@alexandrtovmach
Last active February 4, 2022 10:30
Show Gist options
  • Save alexandrtovmach/89b94bfc6148c15bd34b6c08c4f86bc3 to your computer and use it in GitHub Desktop.
Save alexandrtovmach/89b94bfc6148c15bd34b6c08c4f86bc3 to your computer and use it in GitHub Desktop.

Pre-screen

  1. Conventional commits

General

  • lodash/underscore?
  • moment.js/date-fn?
  • prettier/eslint?
  • webpack/parcel?
  • docker?
  • You have legacy code, and you need to make it great, how and in what ordrer you'd work on it?
    • CI/CD
    • Pull Request flow
    • eslint
    • prettier
    • bug tracking system

Code review

Which function you'd approve?

const one = (arr) => {
  const result = [];
  for (let i = 0; i < arr.length; i++) {
    result[i] = arr[i] * 2;
  }
  return result
}
const two = (arr) => arr.map(el => el * 2)

Review commits

  1. link

Tech task

Task 0 (TypeScript)

Write typings for next data.

Expand data
{
    "key": "/works/OL85892W",
    "type": {
        "key": "/type/work"
    },
    "title": "Dracula",
    // optional
    "description": "It tells the story of Dracula's attempt to move from Transylvania to England so he may find new blood and spread undead curse, and the battle between Dracula and a small group of men and women led by Professor Abraham Van Helsing.",
    // optional
    "subjects": [
        "Fiction",
        "Horror",
        "Monsters",
        "Thriller",
        "Vampires"
    ],
    "authors": [
        {
            "author": {
                "key": "/authors/OL31727A"
            },
            "type": {
                "key": "/type/author_role"
            }
        }
    ],
    isVerified: true,
    isOfficial: true,
    "latest_revision": 96,
    "revision": 96,
    "created": {
        "type": "/type/datetime",
        "value": "2009-10-17T11:24:20.769455"
    },
    "last_modified": {
        "type": "/type/datetime",
        "value": "2021-12-09T08:36:23.821757"
    }
}

Task 1

https://codesandbox.io/s/upbeat-paper-5um22?file=/src/App.js

Create a functionality which will get data from server, and render list of users, fetched from server 652e2ef7-f158-4aeb-91af-0de0a4b35131

Task 2

Build progress bar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment