shell.sh

#!/bin/sh

# Before

set 1 2 3 4 5

while test $# -gt 0;do
	echo $1
	shift
done

# After

set 1 2 3 4 5

while test "${#}" -gt 0
do
	echo "${1}"
	shift
done

# - Always quote variables! They will look more visible and be more secure.
# - No need for ;do on the same line as while...
#
# Thanks!