alirezaandersen/pr-template.md

Forked from rrgayhart/pr-template.md

Last active July 18, 2016 17:39

Star (0) You must be signed in to star a gist
Fork (0) You must be signed in to fork a gist

Learn more about clone URLs
Clone this repository at <script src="https://gist.github.com/alirezaandersen/b6daf5ed3f512294e6c9549bda27342b.js"></script>
Save alirezaandersen/b6daf5ed3f512294e6c9549bda27342b to your computer and use it in GitHub Desktop.

Download ZIP

Modified Quick Left PR Template

Raw

pr-template.md

What's this PR do?

This PR is based on refactoring the quality.js - their were two places to in which repetitous code was used.

Where should the reviewer start?

The reviewer

How should this be manually tested?

  There is no javscript testing for qaulity.js

Any background context you want to provide?

Code is much cleaner and easier to follow.

Screenshots (if appropriate)

Totally not appropriate ;-)

What gif best describes this PR or how it makes you feel?

Makes me feel like there is still much learning I need to do for JavaScript but that OOP is a great resource and skill and to try to do all types of code with OOP in mind.

Raw

source

Source for inspiration for the above template comes from https://quickleft.com/blog/pull-request-templates-make-code-review-easier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment