Skip to content

Instantly share code, notes, and snippets.

@amireh
Last active December 12, 2015 05:48
Show Gist options
  • Save amireh/4724324 to your computer and use it in GitHub Desktop.
Save amireh/4724324 to your computer and use it in GitHub Desktop.
pushing to gerrit hangs
$ git push -v origin HEAD:refs/for/master/docs
Pushing to ssh://[email protected]:29418/canvas-lms
Counting objects: 42, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (20/20), done.
Writing objects: 100% (26/26), 4.46 KiB, done.
Total 26 (delta 9), reused 0 (delta 0)
Write failed: Broken pipe
fatal: The remote end hung up unexpectedly
fatal: recursion detected in die handler
$ git log -n 5
commit dec93080fe8f2ee46d64f20ab4c827dfc375e700
Author: Ahmad Amireh <[email protected]>
Date: Tue Feb 5 09:35:51 2013 +0300
integrate yard-appendix plugin with canvas YARD cfg
Useful things the commit brings:
1. Source documentation can now include images and out-of-source examples
2. Source documentation can now be supplemented by "appendixes" for
documenting advanced or uncommon usage, auxiliary examples, or any
supplementary content
3. An implementation of the YARD @see tag that utilizes the canvas
YARD linkify helper
Necessary changes for integration were:
* Gemfile now includes 'yard-appendix'
* Canvas YARD 'api' template now handles :appendix sections provided
by the plugin
* Rake task for generating API docs (doc:api) made more readable and
now supports asset migration (images and examples)
---
Testing:
To verify that the changes do not alter or affect the current API docs,
fire up a terminal and do the following (inline comments for directions):
```bash
cd /path/to/canvas;
# generate the original docs before pulling these changes
bundle exec rake doc:api
mv public/doc public/doc_original
# checkout these changes into a branch... after that:
bundle install
bundle exec rake doc:api
diff -r -y -q public/doc_original/api public/doc/api
```
The output of the last command should look like this:
Only in doc/api: examples
Only in doc/api: images
Change-Id: Id667b77ff8d36b0f503e0f6752045e3d05bc3649
commit 733627461dc769f1c2dd4a258758bb4da68ba84d
Author: Ryan Florence <[email protected]>
Date: Tue Feb 5 13:26:53 2013 -0700
added CollectionView
test plan:
- see specs
Change-Id: Id31eb15c0a9215ec00c8b805afd35cf74128cfe5
Reviewed-on: https://gerrit.instructure.com/17476
Reviewed-by: Jon Jensen <[email protected]>
Tested-by: Jenkins <[email protected]>
QA-Review: Ryan Florence <[email protected]>
commit a809fddbdfe7fd6f5e3a853988cf730e304d110a
Author: Ryan Florence <[email protected]>
Date: Mon Feb 4 21:04:39 2013 -0700
added @optionProperty to View.coffee
also, quit pulling backbone off window
test plan:
- existing `template` spec covers this
Change-Id: I42916bed9791ca3deae9259eff62afd8fcd1949c
Reviewed-on: https://gerrit.instructure.com/17475
Reviewed-by: Jon Jensen <[email protected]>
Tested-by: Jenkins <[email protected]>
QA-Review: Ryan Florence <[email protected]>
commit ce056cf82fef8c23f3496073f5b94f5b79814978
Author: Brian Palmer <[email protected]>
Date: Tue Feb 5 14:16:12 2013 -0700
Don't mark MediaTracksController as an API
Further API infrastructure needs to be done to support API methods that
don't require a logged-in user or auth token, so these aren't actual
APIs yet.
Change-Id: I6080a1c37e3554ac1285b431e275812ebf4f96eb
Reviewed-on: https://gerrit.instructure.com/17479
Reviewed-by: Bracken Mosbacker <[email protected]>
QA-Review: Bracken Mosbacker <[email protected]>
Reviewed-by: Rob Orton <[email protected]>
QA-Review: Rob Orton <[email protected]>
Tested-by: Jenkins <[email protected]>
commit 890859f8cb4d08d9dce09717dfb4c1d6f6ad95e6
Author: Jon Jensen <[email protected]>
Date: Tue Feb 5 11:29:15 2013 -0700
make sure there is a space between the last update and the WHERE
test plan:
1. run migrations in mysql
2. they should not asplode
Change-Id: I34f564141c99f174311bb4c974630b7594e2096e
Reviewed-on: https://gerrit.instructure.com/17465
Tested-by: Jenkins <[email protected]>
Reviewed-by: Cody Cutrer <[email protected]>
QA-Review: Jon Jensen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment