Pull request template

pull_request_template.md

Status	Type	Ticket
Ready/Hold	Feature/Bug/Tooling/Refactor/Hotfix	Link

NOTE: use notes like this to emphasize something about the PR. This could include other PRs this PR is built on top of; new or removed environment variables; reasons for why the PR is on hold; or anything else you would like to draw attention to.

DEV Checklist (all are mandatory)

• qunit tests pass
• lint tests pass
• all requests are mocked using Mirage
• commits follow the Conventional Commits Spec

Change summary (mark all that apply)

Layout

NOTE: if common CSS was changed, it's implied that it's been verified that layout was is not broken on other devices

• ⚠️ desktop only layout changes
• ⚠️ tablet only layout changes
• ⚠️ mobile only layout changes
• I've checked layout changes on all devices

Tests

• Did not add new tests / open for suggestions on tests to add

Other

• Solution required discussion with team members

Screenshots

BEFORE:

[insert screenshot here]

NOTE: use this only when a big, noticeable change is applied to the current UI

AFTER: [insert screenshot here]

New work items logged

NOTE: list new items that were logged in Jira as followup

Other changes

New dependencies:

• dependency : dependency details

New dev dependencies:

• dependency : dependency details

For other changes :

• notify if environment.js from ember was modified (please see https://ixxuswiki.atlassian.net/wiki/spaces/UCB/pages/931725686/Ember+config+file+update)
• please remove the dependencies requirements