andymckay

    def test_admin_flag(self):
        self.addon.update(admin_review=True)
        self.login_as_admin()
        response = self.client.post(self.url, {'action': 'info',
                                               'comments': 'hello sailor',
                                               'adminflag': True})
        eq_(response.status_code, 302)
        eq_(Addon.objects.get(pk=self.addon.pk).admin_review, False)

andymckay

~/sandboxes/webdev-blog/wp-content/themes/unstunst(master) $ svn diff
Index: sidebar-weare.php
===================================================================
--- sidebar-weare.php	(revision 99736)
+++ sidebar-weare.php	(working copy)
@@ -1,21 +1,4 @@
 <div class="contributors">
 <h2>We are</h2>
-<ul>
-<li><a href="#">Alex Buchanan</a></li>

andymckay

diff --git a/listener/normal/error/forms.py b/listener/normal/error/forms.py
index ec65f1f..699431b 100644
--- a/listener/normal/error/forms.py
+++ b/listener/normal/error/forms.py
@@ -77,9 +77,9 @@ class GroupForm(Filter):
 
 @memoize(prefix='get-domains', time=120)
 def get_domains():
-    domains = [('','')]
     errs = Error.objects.order_by().values_list('domain', flat=True).distinct()

andymckay

~/sandboxes/zamboni/vendor/src/django((40e28df...)) $ gd
diff --git a/django/core/management/base.py b/django/core/management/base.py
index 6b9ce6e..b7a853a 100644
--- a/django/core/management/base.py
+++ b/django/core/management/base.py
@@ -210,6 +210,7 @@ class BaseCommand(object):
             except ImportError, e:
                 # If settings should be available, but aren't,
                 # raise the error and quit.
+                raise

andymckay

~/sandboxes/zamboni(multiple-sites) $ ./manage.py --settings=market_site.settings_local runserver 0.0.0.0:8000
Validating models...

0 errors found
Django version 1.4 pre-alpha, using settings 'market_site.settings_local'



~/sandboxes/zamboni(multiple-sites) $ ./manage.py --settings=addons_site.settings_local runserver 0.0.0.0:8000
Validating models...

andymckay

diff --git a/apps/api/views.py b/apps/api/views.py
index 02296b7..198d3a9 100644
--- a/apps/api/views.py
+++ b/apps/api/views.py
@@ -219,7 +219,10 @@ class AddonDetailView(APIView):
 
     def process_request(self, addon_id):
         try:
-            addon = Addon.objects.id_or_slug(addon_id).get()
+            # untested!

andymckay

diff --git a/scripts/build.sh b/scripts/build.sh
index 5c6ad90..e27fa9b 100755
--- a/scripts/build.sh
+++ b/scripts/build.sh
@@ -56,6 +56,7 @@ LOG_LEVEL = logging.ERROR
 DATABASES['default']['NAME'] = 'zamboni_$1'
 DATABASES['default']['HOST'] = 'localhost'
 DATABASES['default']['USER'] = 'hudson'
+DATABASES['default']['ENGINE'] = 'mysql_pool'
 DATABASES['default']['TEST_NAME'] = 'test_zamboni_$1'

andymckay

diff --git a/mysql_pool/base.py b/mysql_pool/base.py
index b8be24f..5548602 100644
--- a/mysql_pool/base.py
+++ b/mysql_pool/base.py
@@ -27,7 +27,10 @@ Database = manage(Database, **getattr(settings, 'DATABASE_POOL_ARGS', {}))
 def serialize(**kwargs):
     # We need to figure out what database connection goes where
     # so we'll hash the args.
-    return hashlib.md5(str(kwargs)).hexdigest()
+    keys = sorted(kwargs.keys())

andymckay

Jan 23 15:38:33 celery-dev1.addons.phx1.mozilla.com: [][] z.celery:ERROR Celery TASK exception: KeyError: rdflib.term.Literal(u'{aa3c5121-dab2-40e2-81ca-7ea25febc110}') :/data/www/addons-dev.allizom.org/zamboni/vendor/src/nuggets/celeryutils.py:46#012Traceback (most recent call last):#012  File "/data/www/addons-dev.allizom.org/zamboni/vendor/src/nuggets/celeryutils.py", line 35, in wrapped#012    return fun(*args, **kw)#012  File "/data/www/addons-dev.allizom.org/zamboni/apps/amo/decorators.py", line 102, in wrapper#012    return f(*args, **kw)#012  File "/data/www/addons-dev.allizom.org/zamboni/apps/amo/decorators.py", line 94, in wrapper#012    return f(*args, **kw)#012  File "/data/www/addons-dev.allizom.org/zamboni/apps/devhub/tasks.py", line 45, in validator#012    result = run_validator(upload.path)#012  File "/data/www/addons-dev.allizom.org/zamboni/apps/devhub/tasks.py", line 154, in run_validator#012    timeout=settings.VALIDATOR_TIMEOUT)#012  File "/data/www/addons-dev.allizom.org/zamboni/vendor/sr

andymckay

    <em:targetApplication>
      <!-- Fennec Native Java UI -->
      <Description>
        <em:id>{aa3c5121-dab2-40e2-81ca-7ea25febc110}</em:id>
        <em:minVersion>10.0a1</em:minVersion>
        <em:maxVersion>12.*</em:maxVersion>
      </Description>
    </em:targetApplication>