Skip to content

Instantly share code, notes, and snippets.

Show Gist options
  • Select an option

  • Save appleby/613bdaf89e10c3893dedc72f6dfd0192 to your computer and use it in GitHub Desktop.

Select an option

Save appleby/613bdaf89e10c3893dedc72f6dfd0192 to your computer and use it in GitHub Desktop.
golang-http2-changelist-29243-patch-set-10-race-report
[ma@march http2]? go test -run '^TestTransportChecksRequestHeaderListSize$' -race
==================
WARNING: DATA RACE
Write at 0x00c42017a038 by goroutine 7:
golang.org/x/net/http2.TestTransportChecksRequestHeaderListSize()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport_test.go:1575 +0x99c
testing.tRunner()
/home/ma/src/repos/go/src/testing/testing.go:754 +0x16c
Previous read at 0x00c42017a038 by goroutine 13:
golang.org/x/net/http2.isConnectionCloseRequest()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:2207 +0x7b
golang.org/x/net/http2.(*clientConnReadLoop).endStreamError()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:1840 +0xe2
golang.org/x/net/http2.(*clientConnReadLoop).endStream()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:1829 +0x54
golang.org/x/net/http2.(*clientConnReadLoop).processData()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:1819 +0x1cb
golang.org/x/net/http2.(*clientConnReadLoop).run()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:1459 +0x9bd
golang.org/x/net/http2.(*ClientConn).readLoop()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:1351 +0x11c
Goroutine 7 (running) created at:
testing.(*T).Run()
/home/ma/src/repos/go/src/testing/testing.go:800 +0x597
testing.runTests.func1()
/home/ma/src/repos/go/src/testing/testing.go:1053 +0xb2
testing.tRunner()
/home/ma/src/repos/go/src/testing/testing.go:754 +0x16c
testing.runTests()
/home/ma/src/repos/go/src/testing/testing.go:1051 +0x50a
testing.(*M).Run()
/home/ma/src/repos/go/src/testing/testing.go:932 +0x206
main.main()
golang.org/x/net/http2/_test/_testmain.go:604 +0x1d3
Goroutine 13 (running) created at:
golang.org/x/net/http2.(*Transport).newClientConn()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:534 +0xe1a
golang.org/x/net/http2.(*Transport).dialClientConn()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:411 +0x191
golang.org/x/net/http2.(*dialCall).dial()
/home/ma/opt/godev/src/golang.org/x/net/http2/client_conn_pool.go:108 +0x80
==================
==================
WARNING: DATA RACE
Write at 0x00c4201862a0 by goroutine 7:
runtime.mapassign_faststr()
/home/ma/src/repos/go/src/runtime/hashmap_fast.go:598 +0x0
net/textproto.MIMEHeader.Add()
/home/ma/src/repos/go/src/net/textproto/header.go:15 +0x15b
net/http.Header.Add()
/home/ma/src/repos/go/src/net/http/header.go:24 +0x60
golang.org/x/net/http2.topUpHeaders()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport_test.go:1409 +0x402
golang.org/x/net/http2.TestTransportChecksRequestHeaderListSize()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport_test.go:1582 +0xb09
testing.tRunner()
/home/ma/src/repos/go/src/testing/testing.go:754 +0x16c
Previous read at 0x00c4201862a0 by goroutine 13:
runtime.mapaccess1_faststr()
/home/ma/src/repos/go/src/runtime/hashmap_fast.go:208 +0x0
golang.org/x/net/http2.isConnectionCloseRequest()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:2207 +0xae
golang.org/x/net/http2.(*clientConnReadLoop).endStreamError()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:1840 +0xe2
golang.org/x/net/http2.(*clientConnReadLoop).endStream()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:1829 +0x54
golang.org/x/net/http2.(*clientConnReadLoop).processData()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:1819 +0x1cb
golang.org/x/net/http2.(*clientConnReadLoop).run()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:1459 +0x9bd
golang.org/x/net/http2.(*ClientConn).readLoop()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:1351 +0x11c
Goroutine 7 (running) created at:
testing.(*T).Run()
/home/ma/src/repos/go/src/testing/testing.go:800 +0x597
testing.runTests.func1()
/home/ma/src/repos/go/src/testing/testing.go:1053 +0xb2
testing.tRunner()
/home/ma/src/repos/go/src/testing/testing.go:754 +0x16c
testing.runTests()
/home/ma/src/repos/go/src/testing/testing.go:1051 +0x50a
testing.(*M).Run()
/home/ma/src/repos/go/src/testing/testing.go:932 +0x206
main.main()
golang.org/x/net/http2/_test/_testmain.go:604 +0x1d3
Goroutine 13 (running) created at:
golang.org/x/net/http2.(*Transport).newClientConn()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:534 +0xe1a
golang.org/x/net/http2.(*Transport).dialClientConn()
/home/ma/opt/godev/src/golang.org/x/net/http2/transport.go:411 +0x191
golang.org/x/net/http2.(*dialCall).dial()
/home/ma/opt/godev/src/golang.org/x/net/http2/client_conn_pool.go:108 +0x80
==================
--- FAIL: TestTransportChecksRequestHeaderListSize (0.07s)
testing.go:707: race detected during execution of test
FAIL
exit status 1
FAIL golang.org/x/net/http2 0.099s
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment