Created
June 11, 2013 16:21
-
-
Save arialdomartini/5758313 to your computer and use it in GitHub Desktop.
Come lo rifattorizzeresti? Il codice è quasi uguale, ci sono pochissime diferenze (un else e un save)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package JE.AdvertSearchEngine; | |
import JE.Advert; | |
import JE.AdvertLifecycle.ProgressCategory; | |
import JE.AdvertLifecycle.Scheduling.Data.AdvertSchedule; | |
import Util.DateTime; | |
public class AdvertScheduleService { | |
public AdvertSchedule scheduleAdvert(Advert advert) { | |
AdvertSchedule advertSchedule = AdvertSchedule.GetByAdvertId(advert.Id()); | |
String progressCategory = ProgressCategory.GetCategoryForAdv(advert); | |
if (advertSchedule==null) { | |
advertSchedule = AdvertSchedule.Create(advert.Website, progressCategory, advert.Id(), DateTime.Now()); | |
} | |
else | |
{ | |
advertSchedule.LifecycleCategory = progressCategory; | |
} | |
advertSchedule.$Save(); | |
return advertSchedule; | |
} | |
public AdvertSchedule createAdvertSchedule(Advert advert) { | |
AdvertSchedule advertSchedule = AdvertSchedule.GetByAdvertId(advert.Id()); | |
String progressCategory = ProgressCategory.GetCategoryForAdv(advert); | |
if (advertSchedule == null) { | |
advertSchedule = AdvertSchedule.Create(advert.Website, progressCategory, advert.Id(), DateTime.Now()); | |
} | |
return advertSchedule; | |
} | |
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Mah, i 2 metodi mi sembrano molto simili, tenterei di mettere in comune il codice.
Non capisco perche' progressCategory debba essere passato 2 volte ad advertSchedule.