Skip to content

Instantly share code, notes, and snippets.

@arn-e
Created December 2, 2012 06:52
Show Gist options
  • Select an option

  • Save arn-e/4187417 to your computer and use it in GitHub Desktop.

Select an option

Save arn-e/4187417 to your computer and use it in GitHub Desktop.
raw_text_data_for_analysis
0 ::: Feature/commit bounding - Adding time-windowed commit methods ::: Added the commits_since, commits_before, commits_on and commits_between methods to specify windows on the commits retrieved. Also tidied up a couple of YARD failures in client/commits and client/repositories.
As these methods take parseable arguments, I've set them all to raise ArgumentError if the dates passed in are invalid (have pulled in 'date' in the commits.rb so I can use the DateTime.parse). Also had to switch to stub_http_method as the '+' in the iso8601 was giving the stub_get method some gyp.
1 ::: adding commit doc to readme ::: The commit method was very helpful for me and it would be awesome for it to be included in the README2 ::: Use new, more secure, gist comment uris pattern. ::: as described in the [recent changes blog](http://developer.github.com/changes/2012-10-31-gist-comment-uris/)3 ::: Language/Languages confusing behavior ::: Hey Guys,
Love the gem (I'm using 1.18.0), but running into some confusing behavior
Lets say I have a client object:
```client = Octokit::Client.new(:login => "scouttyg", :password => "mypassword")```
and I'll get one of my repos (a private repo) by calling:
```repo_i_want = client.repos.first```
I can get the main language by calling ```repo_i_want.language```, but I'd love to type ```repo_i_want.languages``` and get the same breakdown I get when I type ```client.languages("scouttyg/repo_i_want")```, since it seems at the minimum a little silly to pass in the username in a method that is being chained off an object that tells it which Username to refer to.
Is there a simpler solution to what I'm trying to do?4 ::: Implement new watchers api as subscriptions. ::: I was somewhat unsure of the naming so everything is based on subscribe instead of watch. The new methods are:
User#subscriptions
Repo#subscribers
Repo#update_subscription
Repo#subscription
Repo#delete_subscription
5 ::: Implement Notifications apis. ::: http://developer.github.com/v3/activity/notifications/6 ::: Change exception message ::: 7 ::: Change exception message ::: 8 ::: Document default_branch parameter for repos ::: Re: https://github.com/github/developer.github.com/commit/a4ade3c4288363a1ff59afd8ad6c97224447ee549 ::: Implement pull request review comments. Closes #161. ::: 10 ::: implement .key and .key_update ::: 11 ::: implement .key and .key_update ::: 12 ::: Fix .org_members. Implement .org_public_members. Closes #158. ::: This pull requires #163 for the build to pass.13 ::: Pull Request Review Comments ::: Create, Edit, Delete missing from octokit http://developer.github.com/v3/pulls/comments/14 ::: Fix .organization_members. Implement media_types. ::: Fixes #158.
All requests will now be mashified. ~~This makes the use of the raw paramter
everywhere unnecessary since it is primarily used to get the status code of
the request instead of the response body. I will remove it later.~~ Edit: This
actually won't be removed, I'm just tired and overlooked a small detail.
Mime types have started to begin due to a conflict with needing a request to
be "raw" to get the status code while also returning the mashified response
body and still working with the markdown results from the markdown api.
They are not fully implemented, just enough to keep the response.body
parser happy without breaking any code for the new changes.
This bunches a few things together that would usually be frowned upon
in a commit but I hope you will see it out.15 ::: Don't pass the :proxy Faraday option if it wasn't set ::: When the :proxy option isn't set in Faraday, it defaults to reading ENV['http_proxy']. However, having this env variable with Octokit doesn't have any effect because Octokit always includes the :proxy option, even if it's not set (nil value).16 ::: implement .update_pull_request Closes #146. ::: 17 ::: Implement tag api. #145. ::: Adds .tag and .create_tag methods.
The create method uses a lot of parameters, would a hash be better suited for this? I went with required fields as params since thats what it feels like the rest of octokit uses.
Also the tags created with this seem to be invisible. I created a tag on a private repo and I can retrieve the tag with the sha I get when creating it, but it doesn't show up anywhere and can't be used for anything I can see. The tags don't show up on the GitHub repo page. Pulling the repo from GitHub doesn't mention the creation of any new tags either.18 ::: Implement gist comment api. Closes #144. ::: implement .gist_comments
implement .gist_comment
implement .create_gist_comment
implement .update_gist_comment
implement .delete_gist_comment19 ::: Add yard docs to Repositories methods. Closes #147. ::: edit: messed up the closes #147 in the commit comment. ><20 ::: Add yard docs for Organizations. Closes #149. ::: 21 ::: Change Users#remove_key to return boolean ::: Currently returns the faraday response hash, should be boolean.22 ::: Add yard docs for Octokit::Users. Closes #148. ::: Please review and let me know what needs to be changed.23 ::: Finish yardoc'ing Organizations module ::: 24 ::: Finish yardoc'ing Users module ::: 25 ::: Finish yardoc'ing Repositories module ::: 26 ::: Implement update pull request method ::: Looks like we overlooked [Update](http://developer.github.com/v3/pulls/#update-a-pull-request).27 ::: Implement Tags API in Objects module ::: Docs here: http://developer.github.com/v3/git/tags/28 ::: Implement Gist Comments API ::: ... as found [here](http://developer.github.com/v3/gists/comments/)29 ::: Feature/add pull request comments ::: Added pull_comments method to retrieve comments for a pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment