Skip to content

Instantly share code, notes, and snippets.

@asakusuma
Last active September 20, 2018 22:48
Show Gist options
  • Save asakusuma/5e087b788644264157a0263d13aee2cf to your computer and use it in GitHub Desktop.
Save asakusuma/5e087b788644264157a0263d13aee2cf to your computer and use it in GitHub Desktop.
Repro no transition promise on qp redirect
import Ember from 'ember';
export default Ember.Controller.extend({
appName: 'Repro transition never resolves'
});
export function initialize(application) {
let router = application.lookup('router:main');
router.on('willTransition', (transition) => {
transition.then(() => {
console.log('completed transition');
}).catch((err) => {
console.error('transition error', err);
});
});
}
export default {
name: 'page-tracking',
initialize: initialize
};
import EmberRouter from '@ember/routing/router';
import config from './config/environment';
const Router = EmberRouter.extend({
location: 'none',
rootURL: config.rootURL
});
Router.map(function() {
this.route('redirect');
this.route('foo');
});
export default Router;
import Ember from 'ember';
export default Ember.Route.extend({
queryParams: {
fiz: {
refreshModel: true
}
}
});
import Ember from 'ember';
export default Ember.Route.extend({
redirect() {
this.transitionTo('foo', { queryParams: { fiz: 'baz' } });
}
});
<h1>{{appName}}</h1>
<br>
<br>
Open the console. You should see a "completed transition" log, logged by the page-tracking.js instance-initializer. This log happens when the transition resolves. Type in "/redirect" in the URL bar. Notice that "completed transition" is never logged.
{{outlet}}
<br>
<br>
{
"version": "0.15.0",
"EmberENV": {
"FEATURES": {}
},
"options": {
"use_pods": false,
"enable-testing": false
},
"dependencies": {
"jquery": "https://cdnjs.cloudflare.com/ajax/libs/jquery/3.3.1/jquery.js",
"ember": "3.2.2",
"ember-template-compiler": "3.2.2",
"ember-testing": "3.2.2"
},
"addons": {
"ember-data": "3.2.0"
}
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment