- Get together with your group and send a link of your team's GitHub Repo to the pair that is reviewing your project.
- Look over this guide with your project partner and highlight the pieces where your team can use assistance/you would like your reviewers to take a closer look
- Follow the instructions to clone down the repo you are given and start reviewing the codebase. Take notes for written feedback.
- Come back together in your larger group. This time should be used to have an in-person discussion about the feedback. Send your formal written feedback as a gist/document to the pair and your instructors.
While reviewing the code, ask yourself the following questions:
CODEBASE
- Does the code work? Does it perform its intended function, the logic is correct etc.
- Is all the code easily understood?
- Does it conform to Turing's Style Guide? These will usually cover location of braces, variable and function names, line length, indentations, formatting, and comments.
- Is there any redundant or duplicate code?
- Does the code follow the principle of single responsibility?
- Can any global variables be replaced?
- Is there any commented out code? Any console.logs?
- Do the names used in the application convey intent?
- Do tests exist, and are they comprehensive?
- Do unit tests actually test that the code is performing the intended functionality?
- Does the repo have a .gitignore file? Is there a .DS_Store file or node_modules directory committed that shouldn’t be?
README
- Does the README follow the conventions we discussed in class (i.e. Abstract listed first, install instructions second, everything else listed after)
- Is there a link to the DTR for the team available?
- Is there a wireframe for the project available?
- Is there anything that is confusing or hard to understand with what is written?
- Does the README do a goob of showcasing this project? If you were a random human who happened to come across this project, would you explore it further based on the current state of the README?
- What suggestions would you make for making the README better?
GITHUB/ISSUES/WORKFLOW
- Are issues being used to keep track of tasks, enhancements and bugs?
- Do the titles/descriptions of the issues provide all the relevant/necessary details for the issue? Would you be able to jump right in and assist?
- Are other strategies being used to keep track of issues (labels, milestones, assignments)?
- Is there effective communication happening in PRs outside of working school hours?
- Do the PRS follow the flow that we discussed in class?
- Summarize the changes that you made.
- Give the reason WHY you made those changes
- Ask for any insights
** can you please look at clarity and naming conventions in the code. is it easy to understand and should we break up some of our code more? we dont have a readme so you can skip that section. does our issues tab look fine on github? we moved all the dom manipulation stuff to the dom.js file let us know if we missed anything.
You will be writing a formal piece of feedback (with your partner) to give to the team whose project you reviewed this morning. Use these questions as a guide; however, you are also free to give additional project feedback on anything that may have been overlooked with the questions listed above. Feedback is due by the end of the session. Please save your feedback as a file or gist and send it to your instructors and the pair. Remember to follow the feedback guidelines you went over as part of your professional development in Mod 1.
Your design looks great--keep it up! The welcome screen looks great as well. My only comment is that it would be nice to be able to press enter after adding the last name to initialize the game. On the main screen, it would be nice to see the dollar value of the spin after the spin completes. Also, we should probably see the category of the puzzle somewhere on the DOM once the puzzle is selected. Otherwise, you're making great progress. Totally jealous of your wheel!
Good use of git issues. Don't forget to use pull requests to talk about what changes you make and why, and make it a conversation. Make sure you add DS_store to your gitignore file.
Tests look good so far. Check your 'should' statements to make sure they are descriptive enough. Keep up the good work!