Bryan Wain bdwain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const { parse } = require('acorn'); | |
| const MagicString = require('magic-string'); | |
| //this parses the returned source code and removes all functions from the main export {...}; | |
| //it then changes those functions from `function foo(){...}` to `export function foo(){...}` | |
| //if any variables in any file are named the same as an exported function, this will error out. | |
| //A full solution would need to be included as part of rollup. https://github.com/rollup/rollup/issues/1682 | |
| function plugin(){ | |
| return { |
bdwain
/ working.js
Created
May 17, 2017 23:07
this copy of the app works because babel polyfill was removed Raw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /******/ (function(modules) { // webpackBootstrap | |
| /******/ // The module cache | |
| /******/ var installedModules = {}; | |
| /******/ | |
| /******/ // The require function | |
| /******/ function __webpack_require__(moduleId) { | |
| /******/ | |
| /******/ // Check if module is in cache | |
| /******/ if(installedModules[moduleId]) { | |
| /******/ return installedModules[moduleId].exports; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /******/ (function(modules) { // webpackBootstrap | |
| /******/ // The module cache | |
| /******/ var installedModules = {}; | |
| /******/ | |
| /******/ // The require function | |
| /******/ function __webpack_require__(moduleId) { | |
| /******/ | |
| /******/ // Check if module is in cache | |
| /******/ if(installedModules[moduleId]) { | |
| /******/ return installedModules[moduleId].exports; |
bdwain
/ working.js
Created
May 17, 2017 22:57
this copy of the app works because babel polyfill was removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /******/ (function(modules) { // webpackBootstrap | |
| /******/ // The module cache | |
| /******/ var installedModules = {}; | |
| /******/ | |
| /******/ // The require function | |
| /******/ function __webpack_require__(moduleId) { | |
| /******/ | |
| /******/ // Check if module is in cache | |
| /******/ if(installedModules[moduleId]) { | |
| /******/ return installedModules[moduleId].exports; |
bdwain
/ uglifybug.js
Created
May 17, 2017 22:55
this demonstrates the issue where the reduce_vars option for uglify causes a bug with the string.split prototype
This file has been truncated, but you can view the full file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /******/ (function(modules) { // webpackBootstrap | |
| /******/ // The module cache | |
| /******/ var installedModules = {}; | |
| /******/ | |
| /******/ // The require function | |
| /******/ function __webpack_require__(moduleId) { | |
| /******/ | |
| /******/ // Check if module is in cache | |
| /******/ if(installedModules[moduleId]) { | |
| /******/ return installedModules[moduleId].exports; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class ThemeProvider extends React.Component { | |
| constructor(p, c) { | |
| super(p, c) | |
| this.getColor = this.getColor.bind(this) | |
| } | |
| getColor(){ | |
| return this.props.color //could be this.state.color | |
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| //I tried editing the webpack dev server prototype to use the middleware callback, but it had the same issue | |
| //new version | |
| Server.prototype.close = function(callback) { | |
| this.sockets.forEach(function(sock) { | |
| sock.close(); | |
| }); | |
| this.listeningApp.close(function() { | |
| //this is only reached the first call to close | |
| this.middleware.close(callback); |