Skip to content

Instantly share code, notes, and snippets.

@bjesuiter
Last active August 10, 2019 14:23
Show Gist options
  • Save bjesuiter/9c3b2c946e053afdfca3754b123c985f to your computer and use it in GitHub Desktop.
Save bjesuiter/9c3b2c946e053afdfca3754b123c985f to your computer and use it in GitHub Desktop.
DeckDeckGo Bugs / Improvements

DeckDeckGo Bugs / Improvements

Improvements

Show Slides in Presenter Mode

The presenter mode does not show the slide contents of the current slide. This is very unfortunate, since it requires looking at the beamer when presenting, especially when no notes are attached to a specific slide.

Allow 'reveal' effect for all child elements, not only li, p and img

Maybe you need some kind of marker on the elements, which should 'reveal' which have to be added by the slide developer, like a class 'reveal'. Then you could query all elements with class 'reveal' from the 'content' slot and change their properties.

Or we, the users, have to encapsulate all things, which should be revealable with an extra component or attribute. (I'm thinking, that the way angular directives work would be nice, but I think, stencil can't to these). You could allow p, li and img to be revealed per default and all other elements need an extra tag for that.

Add a deckgo-console slide type

Most developers doing presentations with this stuff need some console tooling. So it would be nice, to have a special type of slide for that. I tried to do it with the code slide, but wasn't successful for some reason I forgot until now. In the end, I build my console things from scratch with a simple <deckgo-slide-content> and css classes.

Replace the deckgo-lazy-img with plain ion-img (or at least highlight the benefits of deckgo-lazy-image over ion-img)

For some reason, lazy image did not load my images at all. So i used ion-img instead, which also does intersection observer and lazy loading now, in version 4. https://ionicframework.com/docs/api/img So maybe you don't need your own component anymore for that, which would be one thing less to maintain in the future :)

Bugs

Low: update dependencies

You have a warning vulnerability in your deckdeckgo webpack plugin, see

Moderate │ Regular Expression Denial of Service │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Package │ underscore.string │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Patched in │ >=3.3.5 │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Dependency of │ deckdeckgo-webpack-plugins [dev] │ ├───────────────┼──────────────────────────────────────────────────────────────┤ │ Path │ deckdeckgo-webpack-plugins > remarkable > argparse > │ │ │ underscore.string │

Low: Template Examples on deckdeckgo.com look broken / not understandable

see https://docs.deckdeckgo.com/slides/concept

Idea: mark the slots with different background-colors to show the distinction, that you mean the areas of the slide with slots.

Gif Slide fails to load gifs

For some reason, the gif slide does not load my gifs. I tried integrating som giffy ones and they didn't load. So I made my own slide with <deckgo-slide-content> again to display my gif.

Sidenote: Is it allowed to pass the gif url as video format, like vp9? I think this would improve performance and giphy does offer it :)

@peterpeterparker
Copy link

Some news:

  • the docs, the display of the slots has been improved and its already online. we received a cool PR from a contributor for that purpose (deckgo/deckdeckgo#214) 👍

  • I began to work on the "reveal" subject. I'm far of being done with the subject but the first concept already would allow the user to have more flexibility, let him/her select which elements should or should not be set as "revealed" (deckgo/deckdeckgo#224)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment