Skip to content

Instantly share code, notes, and snippets.

@blademirage

blademirage/TechChallengeReview_34_20181108.md

Last active November 15, 2018 03:24
Show Gist options
  • Save blademirage/4706492cc5f4fa61139b53030e998ffa to your computer and use it in GitHub Desktop.
Save blademirage/4706492cc5f4fa61139b53030e998ffa to your computer and use it in GitHub Desktop.
Download ZIP
Tech Challenge Review Result - 34 (20181108)
Raw
TechChallengeReview_34_20181108.md

Considered this submission as a FAILED case.

  • Submitted solution has a docker environment, all containers can be started normally by start.sh.
  • However when curl-ing to the endpoints from both docker host and container, no response nor error message has been returned.
  • Test cases could not be executed by following the instructions specified in the readme.md.
  • Emailed to candidate to request further configurations and test details, however the reply is just ask us to check our docker/docker-compose version and the same command in the readme.md to run the test.
  • Tested again with the same failed result after receiving the email reply.

Submitted tech challenge:

Pros:

  • Clean and tidy code.
  • Docker containers are running fine.
  • Demonstrated well use of existing frameworks/libraries.

Cons:

  • Incorrect/Missing information in documentation(readme.md).
  • API endpoints has no respond
  • Test cases are not able to run

Testing environment:

  • Droplet(instance) at DigitalOcean SGP1
  • Ubuntu 18.04 x64
  • Docker CE Client/Server v18.06.1-ce
  • Docker-Compose v1.22.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment