Skip to content

Instantly share code, notes, and snippets.

@blademirage

blademirage/TechChallengeReview_49_20190116.md

Last active January 16, 2019 04:30
Show Gist options
  • Save blademirage/73da359996f858ff65ef602fc6a57761 to your computer and use it in GitHub Desktop.
Save blademirage/73da359996f858ff65ef602fc6a57761 to your computer and use it in GitHub Desktop.
Download ZIP
Tech Challenge Review Result - 49 (20190116.md)
Raw
TechChallengeReview_49_20190116.md

Considered this submission as a FAILED case.

  • The start.sh failed to start with errors.
  • Started the docker containers alone successfully by following the instruction, but create and list returns error SQLSTATE[42S02]: Base table or view not found: 1146 Table 'laravel_docker.orders' doesn't exist ...

Submitted tech challenge:

Pros:

  • Clean and tidy code.
  • Sufficient documentation and examples.
  • Docker containers are running fine.
  • Demonstrated well use of existing frameworks/libraries.
  • Included test cases can be executed successfully in side the container.

Cons:

  • API endpoints sometimes returns unexpected HTML when db error occures
  • Test cases are not able to run by the start.sh

Testing environment:

  • Droplet(instance) at DigitalOcean SGP1
  • Ubuntu 18.04 x64
  • Docker CE Client/Server v18.06.1-ce
  • Docker-Compose v1.22.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment