Skip to content

Instantly share code, notes, and snippets.

@blademirage

blademirage/TechChallengeReview_38_20181114.md

Last active November 15, 2018 03:23
Show Gist options
  • Save blademirage/f8ffae380d848792e797a6b5ac7fd83e to your computer and use it in GitHub Desktop.
Save blademirage/f8ffae380d848792e797a6b5ac7fd83e to your computer and use it in GitHub Desktop.
Download ZIP
Tech Challenge Review - 38 (2018-11-14)
Raw
TechChallengeReview_38_20181114.md

Considered this submission as a PASS case.

Submitted tech challenge:

Pros:

  • Detailed and correct documentations.
  • API endpoints naming follows problem statement.
  • Clean and tidy code.
  • Docker containers are running fine.
  • Demonstrated well use of existing frameworks/libraries.
  • Have both integration and unit tests.
  • All endpoints working as expected.
  • All test cases can be executed successfully.

Cons:

  • Integration test cases have hapy only.
  • Unit test cases did not cover some of the fail cases.
  • Input validation code only check for latitude and longitude values.
  • Input validation code compare float value with integer.

Testing environment:

  • Droplet(instance) at DigitalOcean SGP1
  • Ubuntu 18.04 x64
  • Docker CE Client/Server v18.06.1-ce
  • Docker-Compose v1.22.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment